Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
  • 1
  • 16
  • 17
  • 18(current)
  • 19
  • 20
  • 31
[RELEASE] Artwork Downloader - Skin support
ID 13 is a built in function, try using a higher ID number.

(2012-03-20, 05:15)Balinus Wrote: Hello!

I've added support for Artwork Downloader in Shade and there's some strange behavior. I wouldn't be surprised the problem is my implementation but who knows..! The script works, but strangely.

Here's what happen : in the info screen (DialogVideoInfo.xml), I've added the following code :

PHP Code:
<control type="button" id="13">
               <
description>Get Artwork</description>
               <include>
ButtonInfoDialogsCommonValues</include>
        <
onclick condition="Container.Content(tvshows)">XBMC.RunScript(script.artwork.downloadermode=guimediatype=tvshowmedianame=$INFO[ListItem.TVShowTitle])</onclick>
        <
onclick condition="Container.Content(movies)">XBMC.RunScript(script.artwork.downloadermode=guimediatype=moviemedianame=$INFO[ListItem.Title],mediapath=$INFO[ListItem.Path])</onclick>
        <
visible>[Container.Content(tvshows)|Container.Content(movies)]+system.hasaddon(script.artwork.downloader)</visible>
              <
label>Get Artwork</label>                                                    
 </
control

Now, when I click Get Artwork for a movie, I have a dialog where i choose the movie, but then, it's just like the "information screen" is loaded again and the window where I could chose the type of artwork is behind the information screen. It's just when I escape from the information screen and go back to movie selection that the window to chose the type of media is shown.

Thanks for any help!

edit - Skin is available here in case someone would like to test it out : here or here
Reply
Please let me know if this fixes the problem. If so, I'll submit a PR:

https://github.com/jimfcarroll/xbmc/comm...31b6b2ede0

EDIT: This is meant to only fix the progress dialog deadlock. Please let me know if it does that.
EDIT2: If someone isn't sure how to apply this, let me know, I'll post instructions.
Reply
If someone can build a xbmc.exe or an XBMC installer for Windows, I can test it.
I have Visual C++ 2010 installed, I have download dialog.cpp from your GIT repository.

How can I compile xbmc.exe or create an XBMC installer with that ?
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-20, 12:48)jfcarroll Wrote: Please let me know if this fixes the problem. If so, I'll submit a PR:

https://github.com/jimfcarroll/xbmc/comm...31b6b2ede0

EDIT: This is meant to only fix the progress dialog deadlock. Please let me know if it does that.
EDIT2: If someone isn't sure how to apply this, let me know, I'll post instructions.

I started compile, I will back later with the result. approx. 2 hours max
thanks jfcarroll
Frost
For my bad English, sorry. I am French Canadian.
Admin @ Passion-XBMC.org
Reply
It's OK for me.
I tested 10 times and no freeze append. Wink
I will retested later, but actually work perfectly.

If any guys want testing... http://passion-xbmc.org/gros_fichiers/frost/XBMC.exe

Image


thanks again jfcarroll

frost
For my bad English, sorry. I am French Canadian.
Admin @ Passion-XBMC.org
Reply
Bas news.

Using xbmc.exe from Frostbox + Glass + Artwork downloader : freeze each time I call addon Sad

Maybe I will be able to produce traceback file on my PC with VC++ this evening (France time).
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-20, 06:25)giftie Wrote: ID 13 is a built in function, try using a higher ID number.

Thanks! Using ID 14 solved the problem. Smile

edit - Where could I see a list of ID associated with built-in functions? Is is here? : http://wiki.xbmc.org/index.php?title=Window_IDs
This would mean that ID 14 is also associated with a built-in function? In this case "weathersettings" ?

Reply
(2012-03-20, 13:59)FrostBox Wrote:
It's OK for me.
I tested 10 times and no freeze append. Wink
I will retested later, but actually work perfectly.

If any guys want testing... http://passion-xbmc.org/gros_fichiers/frost/XBMC.exe

frost

(2012-03-20, 14:23)mikebzh44 Wrote: Bas news.

Using xbmc.exe from Frostbox + Glass + Artwork downloader : freeze each time I call addon Sad

Maybe I will be able to produce traceback file on my PC with VC++ this evening (France time).

Ok. Did it fix it or not? Sounds like it did something. Should I submit the PR?
Reply
Update translate for portuguese (Brazil)
link for download here:
http://dl.dropbox.com/u/25170804/Artwork...trings.xml

Addon run fine for me with new xbmc.exe, don´t crash..

MediaBrazil forum Website - Youtube Channel
MQ9-1.6.0.29 - 09.15.2023 - Aeon MQ Skin Team
MarcosQui Website Donate and support us.
Reply
https://github.com/xbmc/xbmc/pull/790
Reply
(2012-03-20, 15:25)Balinus Wrote:
(2012-03-20, 06:25)giftie Wrote: ID 13 is a built in function, try using a higher ID number.

Thanks! Using ID 14 solved the problem. Smile

edit - Where could I see a list of ID associated with built-in functions? Is is here? : http://wiki.xbmc.org/index.php?title=Window_IDs
This would mean that ID 14 is also associated with a built-in function? In this case "weathersettings" ?

No these are window id's ...

here a list of built in controls ... in your case DialogVideoInfo.xml

http://wiki.xbmc.org/index.php?title=Lis...n_Controls
Reply
1 - For XBMC freezing when using Artwork Download, it's finally a Glass problem, even if patch is usefull for other issues. Fmronan and Frostbox are working on skin.

2 - When using mode=gui, is it possible to display only valid items for the movie instead of default list :

Poster
Fanart
Logo
Clearart
Disc art

For exemple, when using Artwork Downloader in GUI mode on Avatar movie, you can only download 3 items for the moment (1 clearlogo and 2 cdart) so items list should be :

Logo
Disc art
Sorry for my english, but, you know, I'm French so ...

Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Reply
(2012-03-20, 18:49)mikebzh44 Wrote: For exemple, when using Artwork Downloader in GUI mode on Avatar movie, you can only download 3 items for the moment (1 clearlogo and 2 cdart) so items list should be :

Logo
Disc art
I already thought about that Wink

Maybe next update. Need some code cleaning first
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
(2012-03-20, 15:50)Wanilton Wrote: Update translate for portuguese (Brazil)
link for download here:
http://dl.dropbox.com/u/25170804/Artwork...trings.xml

Addon run fine for me with new xbmc.exe, don´t crash..

XML contains English strings
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
(2012-03-20, 17:49)butchabay Wrote:
(2012-03-20, 15:25)Balinus Wrote:
(2012-03-20, 06:25)giftie Wrote: ID 13 is a built in function, try using a higher ID number.

Thanks! Using ID 14 solved the problem. Smile

edit - Where could I see a list of ID associated with built-in functions? Is is here? : http://wiki.xbmc.org/index.php?title=Window_IDs
This would mean that ID 14 is also associated with a built-in function? In this case "weathersettings" ?

Great, thanks a lot! Smile

No these are window id's ...

here a list of built in controls ... in your case DialogVideoInfo.xml

http://wiki.xbmc.org/index.php?title=Lis...n_Controls

Thanks!

Reply
  • 1
  • 16
  • 17
  • 18(current)
  • 19
  • 20
  • 31

Logout Mark Read Team Forum Stats Members Help
[RELEASE] Artwork Downloader - Skin support3