• 1
  • 5
  • 6
  • 7(current)
  • 8
  • 9
  • 140
Release script.skinshortcuts
#91
TBH I wasn't expecting a plugin to return a source. Never mind.

As a temporary solution, I've enabled the escaping of backslashes for plugins on the repofixes branch on github. Having asked for the newest version of the script to be pushed to the repo today, I'm going to take it relatively easy for the next few days, so it'll take me a little while to properly investigate what's going on and write a proper fix.
Reply
#92
I'm trying learn how to use this for Conq so I can have a sub menu and a widgets/favourites menu below that in the same style as Confluence so I thought I'd use Confluence Revamped to see how it all works but I just get a message that it can't build the menu.

Debug log

Cheers.
Reply
#93
Why do these bugs only every come up after I submit to repo? Uh ... I mean thanks for the bug report Smile

At some point I've managed to get a couple of brackets into the wrong position. This is now fixed on git.
Reply
#94
All good, thanks.
Reply
#95
Any chance of adding newlines to the generated files for easier reading/writing?

ie

Before -

PHP Code:
[[u'::LOCAL::20386'u'::SCRIPT::32014'u'DefaultRecentlyAddedMovies.png'u''u'ActivateWindow%28Videos%2CRecentlyAddedMovies%2Creturn%29'], [u'::LOCAL::20434'u'::LOCAL::342'u'DefaultSets.png'u''u'ActivateWindow%28Videos%2CMovieSets%2Creturn%29'], [u'::LOCAL::369'u'::LOCAL::342'u'DefaultMovieTitle.png'u''u'ActivateWindow%28Videos%2CMovieTitles%2Creturn%29'], [u'::LOCAL::135'u'::LOCAL::342'u'DefaultGenre.png'u''u'ActivateWindow%28Videos%2CMovieGenres%2Creturn%29'], [u'::LOCAL::562'u'::LOCAL::342'u'DefaultYear.png'u''u'ActivateWindow%28Videos%2CMovieYears%2Creturn%29'], [u'::LOCAL::344'u'::LOCAL::342'u'DefaultActor.png'u''u'ActivateWindow%28Videos%2CMovieActors%2Creturn%29']] 

After -

PHP Code:
[
[
u'::LOCAL::20386'u'::SCRIPT::32014'u'DefaultRecentlyAddedMovies.png'u''u'ActivateWindow%28Videos%2CRecentlyAddedMovies%2Creturn%29'], 
[
u'::LOCAL::20434'u'::LOCAL::342'u'DefaultSets.png'u''u'ActivateWindow%28Videos%2CMovieSets%2Creturn%29'], 
[
u'::LOCAL::369'u'::LOCAL::342'u'DefaultMovieTitle.png'u''u'ActivateWindow%28Videos%2CMovieTitles%2Creturn%29'], 
[
u'::LOCAL::135'u'::LOCAL::342'u'DefaultGenre.png'u''u'ActivateWindow%28Videos%2CMovieGenres%2Creturn%29'], 
[
u'::LOCAL::562'u'::LOCAL::342'u'DefaultYear.png'u''u'ActivateWindow%28Videos%2CMovieYears%2Creturn%29'], 
[
u'::LOCAL::344'u'::LOCAL::342'u'DefaultActor.png'u''u'ActivateWindow%28Videos%2CMovieActors%2Creturn%29']


Thanks.
Reply
#96
(2014-06-17, 18:07)Hitcher Wrote: Any chance of adding newlines to the generated files for easier reading/writing?

ie

Before -

PHP Code:
[[u'::LOCAL::20386'u'::SCRIPT::32014'u'DefaultRecentlyAddedMovies.png'u''u'ActivateWindow%28Videos%2CRecentlyAddedMovies%2Creturn%29'], [u'::LOCAL::20434'u'::LOCAL::342'u'DefaultSets.png'u''u'ActivateWindow%28Videos%2CMovieSets%2Creturn%29'], [u'::LOCAL::369'u'::LOCAL::342'u'DefaultMovieTitle.png'u''u'ActivateWindow%28Videos%2CMovieTitles%2Creturn%29'], [u'::LOCAL::135'u'::LOCAL::342'u'DefaultGenre.png'u''u'ActivateWindow%28Videos%2CMovieGenres%2Creturn%29'], [u'::LOCAL::562'u'::LOCAL::342'u'DefaultYear.png'u''u'ActivateWindow%28Videos%2CMovieYears%2Creturn%29'], [u'::LOCAL::344'u'::LOCAL::342'u'DefaultActor.png'u''u'ActivateWindow%28Videos%2CMovieActors%2Creturn%29']] 

After -

PHP Code:
[
[
u'::LOCAL::20386'u'::SCRIPT::32014'u'DefaultRecentlyAddedMovies.png'u''u'ActivateWindow%28Videos%2CRecentlyAddedMovies%2Creturn%29'], 
[
u'::LOCAL::20434'u'::LOCAL::342'u'DefaultSets.png'u''u'ActivateWindow%28Videos%2CMovieSets%2Creturn%29'], 
[
u'::LOCAL::369'u'::LOCAL::342'u'DefaultMovieTitle.png'u''u'ActivateWindow%28Videos%2CMovieTitles%2Creturn%29'], 
[
u'::LOCAL::135'u'::LOCAL::342'u'DefaultGenre.png'u''u'ActivateWindow%28Videos%2CMovieGenres%2Creturn%29'], 
[
u'::LOCAL::562'u'::LOCAL::342'u'DefaultYear.png'u''u'ActivateWindow%28Videos%2CMovieYears%2Creturn%29'], 
[
u'::LOCAL::344'u'::LOCAL::342'u'DefaultActor.png'u''u'ActivateWindow%28Videos%2CMovieActors%2Creturn%29']


Thanks.
Yes also the same with created playlist (maybe with indentation)... It's really hard to manually change these files
Reply
#97
(2014-06-17, 18:07)Hitcher Wrote: Any chance of adding newlines to the generated files for easier reading/writing?

ie

Before -

PHP Code:
snip 

After -

PHP Code:
snip 

Thanks.

I've put a quick-and-dirty hack on the repofixes branch to add newlines. My broad plan, though, is to replace these files with xml (if I can figure out a way to do it that doesn't break anything) in the not too distant future. Of course, those xml files might suffer the same issue because...

(2014-06-17, 18:51)phate89 Wrote: Yes also the same with created playlist (maybe with indentation)... It's really hard to manually change these files

... The library I'm using to write the xml for these (ElementTree) doesn't have a "pretty print" function, so this isn't as easy as it first appears. I'll look (again) into possible solutions (that don't require an additional/alternative library).
Reply
#98
(2014-06-17, 19:01)Unfledged Wrote: ... The library I'm using to write the xml for these (ElementTree) doesn't have a "pretty print" function, so this isn't as easy as it first appears. I'll look (again) into possible solutions (that don't require an additional/alternative library).

I'm not an expert but maybe this can help:
http://snipplr.com/view/25657/indent-xml...ementtree/
Reply
#99
(2014-06-17, 19:14)phate89 Wrote:
(2014-06-17, 19:01)Unfledged Wrote: ... The library I'm using to write the xml for these (ElementTree) doesn't have a "pretty print" function, so this isn't as easy as it first appears. I'll look (again) into possible solutions (that don't require an additional/alternative library).

I'm not an expert but maybe this can help:
http://snipplr.com/view/25657/indent-xml...ementtree/

It's a possibility, thanks Smile (though I'm not doing anything other than critical fixes and silly things like the new line hack for a few days, so bear with me till I look at implementing it)
Reply
(2014-06-17, 19:18)Unfledged Wrote: It's a possibility, thanks Smile (though I'm not doing anything other than critical fixes and silly things like the new line hack for a few days, so bear with me till I look at implementing it)
Sure no hurry for a minor fix like this Wink
Reply
Yeah, take your time I'm just throwing out suggestions. Wink
Reply
Suggestions are always very welcome, keep 'em coming Smile
Reply
Another one -

In Confluence Revamped there's a label ID=311 for the selected widget but it doesn't seem to be defined anywhere in the script.

Thanks.
Reply
(2014-06-18, 10:45)Hitcher Wrote: Another one -

In Confluence Revamped there's a label ID=311 for the selected widget but it doesn't seem to be defined anywhere in the script.

Thanks.

Now that one I know Smile I modded that version of confluence before I figured out why the label2's were being blocked (because the script was providing the label - I now recommend that the skin sets them), so I included an extra control for the widget name. Now, if yoh set the label for the button, you can do something like

Code:
<label2>$INFO[Container(211).ListItem.Property(widgetName)]</label2>

With backgroundName and displayPath being other useful properties to display.
Reply
Strange, it works as a separate label but not as label2 in the widget button.
Reply
  • 1
  • 5
  • 6
  • 7(current)
  • 8
  • 9
  • 140

Logout Mark Read Team Forum Stats Members Help
script.skinshortcuts8