[garbear]

@Levi.baker88 retroplayer is a custom version of Kodi. you download the installer in the OP and install it over Kodi

In the addon manager the "Game controllers" node shows up in an odd place right under "System" alongside "Dependencies" and "Running".

I'm fixing this by adding a "Game Add-ons" node to the add-on manager, similar to info providers. The sub-nodes will probably be:

• Standalone games (scripts that provide game and executable game add-ons)
  
• Emulators (non-executable game add-ons)
  
• Game providers (plugins that provide game)
  
• Game controllers
  

When controlling the default controller (using the Xbox 360 wireless controller) after pressing the button for Y it jumps over the "Start" button directly to the "Back" button.

Pressing the "Xbox button" for "Guide" doesn't work because it is caught by the windows tool to manage the controller.

This should be fixed. Pressing the Y button was emitting two button presses, one for Y and one for guide. Also, now the guide button is mappable on my test computer.

Having 2048 show up as a potential emulator when trying to start a ROM is very odd. Same goes for the libretro compatibility addon which both can't handle any ROMs.

This will be fixed in the next build

The rest of the comments I'm still looking into. Thanks for testing!

[Montellese]

Thanks for looking into it. The restructuring of the game-related addon categories makes sense IMO.

I've been looking into adjusting the nestopia addon to follow our dependency handling setup and I have it working on win32 but I'm not yet 100% happy (the setup is rather special). In case you're already interested I had to make 2 changes to Kodi (see https://github.com/Montellese/xbmc/commi...ngw_config) and some restructuring in game.libretro.nestopia (see https://github.com/Montellese/game.libre...3ff8e12edf ). The advantage would be that you could benefit from all the builtin features like automatically applying patches etc.

[futurepr0n]

Are you able to have both a Kodi 14 Media Center and Kodi 15 Isengrad RetroPlayer Test Build on Mac? Or will one overwrite/curropt the other??

Is it possible to have the functionality of both, or am I wrong to assume that you can only have one or the other? I was under the impression Retro Player can only play games - and not media, like Kodi TV does. I didn't want to lose Kodi as my media player, but I pretty badly want to have an integrated set up for launching roms for my htpc (mac mini)

[Montellese]

RetroPlayer is Kodi with the additional functionality to play games. You don't lose any of the media playback functionality. But this is not a stable version so there might be some issues.

[Montellese]

Thanks for looking into it. The restructuring of the game-related addon categories makes sense IMO.

I've been looking into adjusting the nestopia addon to follow our dependency handling setup and I have it working on win32 but I'm not yet 100% happy (the setup is rather special). In case you're already interested I had to make 2 changes to Kodi (see https://github.com/Montellese/xbmc/commi...ngw_config) and some restructuring in game.libretro.nestopia (see https://github.com/Montellese/game.libre...3ff8e12edf ). The advantage would be that you could benefit from all the builtin features like automatically applying patches etc.

With some helpful hints from ironic_monkey I was able to improve the changes to game.libretro.nestopia, see https://github.com/Montellese/game.libre...0c52265d59.

Let me know if you are interested in this.

[da-anda]

sorry if it has already mentioned, but the keyboard doesn't seem to work besides of the cursor keys. I noticed it because pressing "c" or "i" didn't trigger the according actions, so I suppose keymaps are not loaded for these atm

[Montellese]

Tried to reproduce the freeze when connecting my Xbox 360 controller while Kodi was running but it didn't happen anymore. I also finally managed to play NES games but I had to configure the NES controller explicitly i.e. simply configuring the default controller wasn't enough.
I also tried to get my NES30 controller to work but didn't see any recognized input.

Also all keymappings in the video and music library views don't work anymore.

[garbear]

1. The Windows installer will need some improvements as right now you can choose not to install game.libretro but to install game.libretro.nestopia (and/or any other libretro emulator) which will leave the installation in a non-working state.

I tried to exclude game.libretro by only adding game.libretro.* (extra .) to the installer: https://github.com/garbear/xbmc/commit/2...905ef3cR34 . apparently this didn't work

4. When I connected my Xbox 360 wireless controller to windows while Kodi was running it froze. I can reproduce this all the time and here's the part of the log http://pastebin.com/c4Hi4EWi. After that nothing will happen and I have to kill Kodi.

8. Sometimes pressing a button on the controller doesn't result in any action and then I have to press it again. Here's a log snippet where I had to press A twice to go into Games Files: http://pastebin.com/z8GX8Jvq

Haven't been able to reproduce yet. I'l keep trying

10. Using "Manage emulators..." from the context menu of a game ROM will freeze Kodi: http://pastebin.com/EKahJX6K

Fixed by removing the setting

11. Pressing any buttons on the controller after having started a game ROM with Nestopia will result in controlling the player and not the game. In the follow log snippet I pressed A which paused the player and then B which exited the player completely: http://pastebin.com/HkpjeExP. Funny enough pressing ENTER on the keyboard works in the game. But that's the only key that is working at all on the whole keyboard.

looking into this

EDIT: reading below it looks like you didn't map the 360 gamepad to the NES controller. Also you need to map the keyboard. I think the defaults for the keyboard are missing some buttons: https://github.com/kodi-game/peripheral....tonmap.xml

I also noticed another issue with the input configuration. When you start configuring a controller and then pause for a while until the screensaver kicks in and then continue to configure the controller the button presses are properly mapped but the screensaver is not disabled until the end of the configuration.

noted

With some helpful hints from ironic_monkey I was able to improve the changes to game.libretro.nestopia, see https://github.com/Montellese/game.libre...0c52265d59.

Let me know if you are interested in this.

I like this approach. being able to use the build system's features (like patching) for libretro cores would be nice

I also finally managed to play NES games but I had to configure the NES controller explicitly i.e. simply configuring the default controller wasn't enough.

When an add-on imports a controller (in addon.xml) then all input delivered to the add-on will be in the form of that controller. This allows every platform's controller to be configured separately. It also is a lot of work and leads to O(N*M) storage. I have a plan to make this better.

I also tried to get my NES30 controller to work but didn't see any recognized input.

If the controller doesn't support XInput it should fall back to DirectInput. This can also be tested with XInput controllers by removing this line: https://github.com/kodi-game/peripheral....s.txt#L113 (controller will fall back to DirectInput) . Does the controller get detected in the debug log?

Also all keymappings in the video and music library views don't work anymore.

looking into this

[garbear]

3. I was unable to exit game pad setup menu after button configuration no matter what I press/click/do there.

Confirmed. I'll look into this

4. Pressing menu key on keyboard on Files or Game addons does not work (it works if left clicked with mouse)

looking into this

EDIT: Fixed, will include in next build

1. When first started I don't see anything under Games. After closing Kodi, and starting again, Files and Game addons will show up.

Haven't been able to reproduce yet. I'l keep trying

2. Setting up Xbox 360 was a pain, as sometimes button will not get accepted (if ESC is pressed will that erase button assignment or assign ESC to button?)

ESC can't be mapped. it's used to cancel the configuration process. (btw moving the mouse will also cancel the current prompt.)

ATM the configuration GUI is the raw minimum needed to map keys. I'd like to improve it, so if you have any ideas, let me know! the thread for this is the Input thread: http://forum.kodi.tv/showthread.php?tid=211138

5. Didn't manage to start any game for now as I don't know if smc files are recognized by nestopia. I did add path but not sure how to proceed next.

You can check the supported extensions in the add-on manager. I've made an effort to list supported extensions in the description. (and I think .smc is Super Nintendo games)

[Scourge]

I got the Windows installation up and running. My game files are on my NAS and I connect through SMB. No problem. Running a game works, but I can't control the game. All button presses control the player, not the game.
Setting up the controllers, I get this:


I have an original NES controller hooked up via a Retroport USB. Trying to map any buttons after dismissing the pop-up above results in no responses. I can find the NES controller in the add-on section. It is enabled and I cannot manage anything there.

Am I doing something wrong?

[garbear]

can you post a debug log?

joystick support has been moved into an addon called peripheral.joystick. Kodi must not be loading this add-on

[Montellese]

I have updated my initial report by striking through all items that have been resolved.

1. The Windows installer will need some improvements as right now you can choose not to install game.libretro but to install game.libretro.nestopia (and/or any other libretro emulator) which will leave the installation in a non-working state.

I tried to exclude game.libretro by only adding game.libretro.* (extra .) to the installer: https://github.com/garbear/xbmc/commit/2...905ef3cR34 . apparently this didn't work

I'll try to take a stab at it. The ideal solution would be to only install game.libretro if another game.libretro.* addon has been selected.

4. When I connected my Xbox 360 wireless controller to windows while Kodi was running it froze. I can reproduce this all the time and here's the part of the log http://pastebin.com/c4Hi4EWi. After that nothing will happen and I have to kill Kodi.

8. Sometimes pressing a button on the controller doesn't result in any action and then I have to press it again. Here's a log snippet where I had to press A twice to go into Games Files: http://pastebin.com/z8GX8Jvq

Haven't been able to reproduce yet. I'l keep trying

Wasn't able to reproduce #4 either today.

10. Using "Manage emulators..." from the context menu of a game ROM will freeze Kodi: http://pastebin.com/EKahJX6K

Fixed by removing the setting

This has been fixed by my last PR with the updated addons:// paths so shouldn't be any need to remove the setting.

11. Pressing any buttons on the controller after having started a game ROM with Nestopia will result in controlling the player and not the game. In the follow log snippet I pressed A which paused the player and then B which exited the player completely: http://pastebin.com/HkpjeExP. Funny enough pressing ENTER on the keyboard works in the game. But that's the only key that is working at all on the whole keyboard.

looking into this

I'm still not sure how the whole controller configuration is supposed to work so maybe I just did it the wrong way. As mentioned in my previous post I only configured the default controller but not the NES controller when I tried this.

With some helpful hints from ironic_monkey I was able to improve the changes to game.libretro.nestopia, see https://github.com/Montellese/game.libre...0c52265d59.

Let me know if you are interested in this.

I like this approach. being able to use the build system's features (like patching) for libretro cores would be nice

Would be nice if we could first test this on linux and osx before creating a PR for it.

I also tried to get my NES30 controller to work but didn't see any recognized input.

If the controller doesn't support XInput it should fall back to DirectInput. This can also be tested with XInput controllers by removing this line: https://github.com/kodi-game/peripheral....s.txt#L113 (controller will fall back to DirectInput) . Does the controller get detected in the debug log?

Without any modifications I didn't see anything in the debug log when I pressed the buttons. But in the Joystick/Controller configuration tool of windows 7 all button presses and the D-Pad are recognized. I'll try to find some time to debug this as it would be awesome.

[natethomas]

11. Pressing any buttons on the controller after having started a game ROM with Nestopia will result in controlling the player and not the game. In the follow log snippet I pressed A which paused the player and then B which exited the player completely: http://pastebin.com/HkpjeExP. Funny enough pressing ENTER on the keyboard works in the game. But that's the only key that is working at all on the whole keyboard.

looking into this

I'm still not sure how the whole controller configuration is supposed to work so maybe I just did it the wrong way. As mentioned in my previous post I only configured the default controller but not the NES controller when I tried this.

You have to configure the controller you want to use with each platform. So if you want to play NES games on your Xbox controller, you have to configure the controller for NES.

Maybe it'd be easier if Kodi looked to see if the controller had been configured for the gaming platform, and if it hadn't, it could pop up a quick config window.

[garbear]

I'm uploading a new build that fixes most of the points brought up so far. I'll post when windows and OSX builds are up

two comments:

Would be nice if we could first test this on linux and osx before creating a PR for it.

I'm on it

Maybe it'd be easier if Kodi looked to see if the controller had been configured for the gaming platform, and if it hadn't, it could pop up a quick config window.

Good idea, this should be easy to do. I'm open to other ideas for the configuration utility as well. It's a bit clunky right now but I have a plan to make things better. gotta fix the bigger bugs first tho

[garbear]

New builds are up for windows and OSX!

Would be nice if we could first test this on linux and osx before creating a PR for it.

I'm on it

The add-on builds successfully on ubuntu and OSX. Runtime tested on OSX, roms still load