[wesk05]

Here are the logs:

1) VidOn XBMC log (start from line 475): http://pastebin.com/N1B7uGFn

I haven't added or removed any addons. The ones that you see in the log are the default ones.

2) Logcat from Minix U1 (check line 87): http://pastebin.com/MW9E7Vaw

@wrxtasy: here is the codec info overlay from VidOn XBMC



This is only the left eye, my capture card, Blackmagic Design DeckLink 4K Extreme 12G does dual stream 3D capture (one stream/file for each eye).

@Wolly:
If there is some mistake, please excuse me because I am not an Android developer or may be just ignorant or may be saying things based on common sense or past experience.

[nickr]

If the player is incorporated into the Kodi app, and distributed within it, and not separate and external, then it isn't by definition, external.

You've hit on the key question... within the VidOn APK, is there an embedded video player (making it an internal solution), or is the VidOn app calling the AML player via an API (external solution)? I think Wolly was saying it was the latter.

Wolly can't make up his mind, he says what suits him.

[nickr]

You all know where I stand on using an Open Source solution.
Closed source code is not the way forward to progress the Kodi code base going into the future.

From VidOn log, it appeared to me that it is calling some external libraries *.so for playback. This is how it is done on Xidoo X6. It calls some rk library. I will post the log when I get a chance to remote to my home PC.

Are these libs just for the DVD and BluRay menus or for video Playback as well ?

A OSD Codec info screenshot (if possible) on an AMLogic device running VidOn XBMC would be very helpful.
I have a crippled version, so no video playback possible.

No a bloody linker output as I already suggested is what would be helpful. Stop the bloody guesswork.

apks are just a zip file aren't they? How about a file listing?

Has anyone actually tried compiling the vidon github code?

[Wolly]

It's meaningless to discuss this issue, we have forwarded this question to Amlogic and we are waiting for their answer.
Why we need to let Amlogic deal with this issue?
Now we know that HiSilicon and Allwinner said clearly that they absolutely support frame-packed 3D output, so our VidOn Box absolutely outputs frame-packed 3D. But on Amlogic, we can sure that we don't do any compress and Amlogic also told us that they don't do any compress too, so the picture is 1920*1080, that's no problem, unless they lied.
You should know that whether it's frame-packed output or not, it's the work of the display output module of the under-layer hardware, it's not the work of XBMC, not the upper-layer software.
What I can say is that (again) we don't compress the picture and Amlogic also said they don't compress the picture too, so the two pictures we output are full 1920*1080, not half-resolution. We do our work based on the hardware.
Of course you can keep guessing...

[Koying]

From a quick look at the sources, vidon calling libraries from inside Kodi, not actual external player.

Now, I'm surely not a GPL specialist, but saying that a lib called from a GPL app must be GPL just seems BS to me.
It's true for an app that CALLS a GPL lib (unless it's LGPL), iirc, but not the contrary, that just doesn't make sense.

That would just mean that no GPL app could run on windows unless Microsoft open-source all Windows system dll

[noggin]

Here are the logs:

1) VidOn XBMC log (start from line 475): http://pastebin.com/N1B7uGFn

I haven't added or removed any addons. The ones that you see in the log are the default ones.

That really doesn't look like an external player log does it?

Code:

22:48:40 T:18446744072297037448  NOTICE: Creating video thread
22:48:40 T:18446744072297037448  NOTICE: Creating audio thread
22:48:40 T:18446744072296210680  NOTICE: Thread DVDPlayerVideo start, auto delete: false
22:48:40 T:18446744072296210680  NOTICE: running thread: video_thread
22:48:40 T:18446744072294736312  NOTICE: Thread DVDPlayerAudio start, auto delete: false

and

Code:

22:48:40 T:18446744072297037448  NOTICE: Opening stream: 0 source: 256
22:48:40 T:18446744072297037448  NOTICE: Creating video codec with codec id: 28
22:48:40 T:18446744072296210680  NOTICE: Creating next video codec with codec id: 28
22:48:40 T:18446744072296210680   DEBUG: CDVDFactoryCodec: compiled in hardware support: RKCodec:yes AMCodec:yes AWCodec:yes MediaCodec:yes OpenMax:no libstagefright:yes VDPAU:no VAAPI:no iMXVPU:no A31Codec:yes
22:48:40 T:18446744072296210680   DEBUG: SECTION:LoadDLL(lib3DMode.so)
22:48:40 T:18446744072296210680   DEBUG: Loading: /data/app/org.vidonme.xbmc-1/lib/arm/lib3DMode.so
22:48:40 T:18446744072295864616 WARNING: CDVDMessageQueue(3DSubQueue)::Get - asked for new data packet, with nothing available
22:48:40 T:18446744072296210680   DEBUG: FactoryCodec - Video: amcodec - Opening
22:48:40 T:18446744072296210680   DEBUG: SECTION:LoadDLL(libamplayer.so)
22:48:40 T:18446744072297037448   DEBUG: CDVDPlayer::SetCaching - caching state 3
22:48:40 T:18446744072296210680   DEBUG: Loading: /system/lib/libamplayer.so

To me (and I'm not an expert) that looks as if it is running a fork of the DVDPlayer but then loading (or saying it is loading) a couple of externally compiled .so shared object files, which presumably have the actual 3D/HD Audio player stuff in them? (libamplayer.so and lib3DMode.so) If the source code for these is in the github account - then presumably no problem? However if this is the case then this isn't really an external player, but instead an internal player rewritten to use an external shared object (kind of a library?).

To those who understand GPL - if the source code for these .so files is NOT available, is this any different to a binary blob for a GPU driver? It feels to me like it might be (otherwise anyone could break GPL by just pre-compiling stuff they don't want others to see as a binary)?

Or am I totally barking up the wrong tree?

[noggin]

From a quick look at the sources, vidon calling libraries from inside Kodi, not actual external player.

Now, I'm surely not a GPL specialist, but saying that a lib called from a GPL app must be GPL just seems BS to me.
It's true for an app that CALLS a GPL lib (unless it's LGPL), iirc, but not the contrary, that just doesn't make sense.

That would just mean that no GPL app could run on windows unless Microsoft open-source all Windows system dll

Does it depends on whether the library is distributed with the application or comes installed as part of the OS? I agree it's an obvious contradiction.

OpenElec is also GPL licensed, and they incorporate binary blobs in lots of their distributions (video drivers, boot loaders for the Pi / Pi 2 etc.), so this isn't a clear cut issue is it? Or maybe it is. Even the Linux kernel includes binary blobs.

I guess the next question is whether the Kodi code that calls the shared libraries/objects is open source - allowing others to also call the same shared objects/libraries - and potentially allowing this to be added to the mainline code?

Looking at the Vidon.me github : libamplayer.so appears to be called in xbmc/cores/dvdplayer/DVDCodecs/Video/AMLCodec.cpp which appears to be the same in both mainline and the Vidon.me version - so that's all good?

However I'm trying to find the source code that calls lib3DMode.so in the Vidon.me github and can't at the moment? Anyone else see it in any of the versions there?

Annoying that searching forks on github is tricky, but I can't see it.

If it isn't then that is a straightforward GPL issue still surely? (As the source code on the github isn't the source code being used to compile the distributed version of Kodi/xbmc?)

[Koying]

AFAIK, the GPL basically says that a GPL app (and thus forks of it) must be rebuildable by users and that the resulting app/package works exactly the same as the provided binary (the vidon apk in this instance).

Is it the case? GPL is satisfied, AFAICT
Is it not (missing static libraries, missing binary blobs (e.g. dynamic libraries) included in the original apk, ...)? -> Possible GPL violation. Whether the vidon dynamic libs are GPL or not is irrelevant.

Bottom line: If nobody actually tried to build a vidon apk from sources, this is pure intellectual wanking

[wrxtasy]

Guys something strange is going on too, I've looked in VidOns Github and even the custom modified XBMC settings.xml file is not there for the VidOn settings menu that they use in their custom XBMC that you see in this post:

http://forum.kodi.tv/showthread.php?tid=...pid2205345

Here is their current settings.xml file:

https://github.com/vidonme/xbmc/blob/dc7...ttings.xml

Can I have someone else look at this too ?

[Koying]

Can't see your screenshots (stupid filters @ work) but I bet this what you're talking about: https://github.com/vidonme/xbmc/tree/hel...mc/vidonme

[wrxtasy]

I was looking in the wrong place, Koying. All the settings stuff is there, I was in the master Branch. Thanks.

Bottom line: If nobody actually tried to build a vidon apk from sources, this is pure intellectual wanking

If it builds on a ubuntu V/M without me having to download a whole bunch of supporting sdk, libs etc, I can give it a go.
Otherwise someone setup for Android compiling will have to do it.

[t4_ravenbird]

..
Now, I'm surely not a GPL specialist, but saying that a lib called from a GPL app must be GPL just seems BS to me.
..

..
this isn't a clear cut issue is it? Or maybe it is. Even the Linux kernel includes binary blobs.
...

FWIW this post http://stackoverflow.com/questions/27212...sd-kernels is dealing with these issues and has some good information

[wrxtasy]

Commits / changes by VidOn between the base of XBMC 14.x - Helix and the HEAD of VidOn XBMC 14.x - Helix

https://github.com/xbmc/xbmc/compare/Hel...ix.vidonme

And here is what you are looking for that pulls in and builds the VidOn player and libs:

https://github.com/xbmc/xbmc/commit/4ff7...01a191c3de

I've tried wget - ting the lib.tgz file from the servers and of course no luck.

Joe public would not be able to build an operational VidOn.apk from VidOn's Github.

---

And this absolute beauty, selling an Upgrade to VidOn Kodi Pro

Welcome to VidOn Kodi

"VidOn.me offers for Android the most complete and reliable Kodi, with greatly optimized functions and features. On top of the traditional media management function, our Kodi has many unique features like Blu-ray menu navigation, HD audio output, and more."

https://github.com/xbmc/xbmc/commit/5000...0ecb6a85b9

What about the Kodi name being Trademark ?

[Koying]

wget http://10.10.2.201:9003/develop/vidon.xb...am/lib.tgz ?

Yep. They need to fix that or make the binary .so available.
Apparently, they committed their own build scripts

[hdmkv]

Wow, what a wild ride ... very educational, even though I barely understand the code talk, I can appreciate the logic behind it.