2016-03-06, 14:41
Ive just changed from London time 24hr to New York time 12hr and now everything working perfectly!
Cheers for all your help
Cheers for all your help
2016-03-07, 13:13
Changing to Eastern time (12 or 24hr) worked fine for me, even changing the time afterwards worked fine. So it looks as though as long as you have Eastern Standard Time set as the Time Zone in your Android settings it should work correctly.
Still random that this appears to be Android-specific and regardless of time setting my Windows 7 box works fine.
Still random that this appears to be Android-specific and regardless of time setting my Windows 7 box works fine.
2016-03-07, 16:18
I've done a little bit of testing with this and have found that the Python script fails at the same point each time. It runs through 92 lines of the Live & Upcoming page without issue and then fails just before it reaches the entry for Celtics Vs. Suns. The line before this (Suns Vs. Kings) shows the start_time value of 20160326-0130 and the Celtics vs' Suns line has a value of 20160327-0130.
Clearly this is to do with Daylight Saving Time, which is due to start in the UK at 01:00 on 27th March 2016. Unfortunately, my Python knowledge isn't expansive enough to be able to fix the issue, but I assume using the pytz module might be able to help out with this?
Clearly this is to do with Daylight Saving Time, which is due to start in the UK at 01:00 on 27th March 2016. Unfortunately, my Python knowledge isn't expansive enough to be able to fix the issue, but I assume using the pytz module might be able to help out with this?
2016-03-07, 17:25
(2016-03-07, 16:18)talkingoldfish Wrote: I've done a little bit of testing with this and have found that the Python script fails at the same point each time. It runs through 92 lines of the Live & Upcoming page without issue and then fails just before it reaches the entry for Celtics Vs. Suns. The line before this (Suns Vs. Kings) shows the start_time value of 20160326-0130 and the Celtics vs' Suns line has a value of 20160327-0130.
Clearly this is to do with Daylight Saving Time, which is due to start in the UK at 01:00 on 27th March 2016. Unfortunately, my Python knowledge isn't expansive enough to be able to fix the issue, but I assume using the pytz module might be able to help out with this?
Makes sense. I'll look into switching the time functions to the more reliable pytz library. Thanks for doing the leg work
2016-03-07, 17:51
(2016-03-07, 17:25)eracknaphobia Wrote: Makes sense. I'll look into switching the time functions to the more reliable pytz library. Thanks for doing the leg work
Excellent, thanks. No worries about the leg work, this is by far my favourite Kodi add-on so I'm happy to help out with anything. If you have any testing you need doing at any point just throw it my way.
2016-03-07, 20:13
Version 2016.3.7 Released
- Fix for mktime error
I didn't get a chance to test this on an android device so if someone could verify that this does fix the mktime error, that'd be great.
- Fix for mktime error
I didn't get a chance to test this on an android device so if someone could verify that this does fix the mktime error, that'd be great.
2016-03-07, 21:41
Updated on my fire tv box and still getting the error in live and upcoming also noticed when you click on featured then full replays, showcase or spotlight there is nothing there.
2016-03-07, 21:48
2016-03-07, 23:13
This does not seem to work correctly on my S6. The first time you enter into Live & Upcoming it works fine but then you cannot enter into it again as it throws up a script error (attribute of type NoneType is not callable). Further to this, all of the other sections are blank (eg. Full Replays, Showcase, Spotlight, etc)
2016-03-07, 23:58
And if you switch the clock back to eastern does it work? I'll probably need to a log to figure this one out. I couldn't reproduce it on a 64bit Win10 machine and my resources to test this on are pretty limited at work.
2016-03-08, 10:57
The same thing happens now when the clock is set to EST. I have uploaded a log to http://xbmclogs.com/pvzgtdrpl
Is this log I went into Live & Upcoming first, came out, went into one of the other sections and then tried to go back into Live & Upcoming whereupon I received the NoneType error.
If this is too difficult to sort (especially as you've no way of testing it) I'm sure everyone would be happy to just set their clocks to EST and roll back to the previous version.
Is this log I went into Live & Upcoming first, came out, went into one of the other sections and then tried to go back into Live & Upcoming whereupon I received the NoneType error.
If this is too difficult to sort (especially as you've no way of testing it) I'm sure everyone would be happy to just set their clocks to EST and roll back to the previous version.
2016-03-08, 17:13
Update 2016.3.8 Released
- Fix for time error attempt #2
- Fix for time error attempt #2
2016-03-08, 18:11
(2016-03-08, 17:13)eracknaphobia Wrote: Update 2016.3.8 Released
- Fix for time error attempt #2
This one does show some improvement, the other sections (eg. Full Replays, Showcase, Spotlight, etc) now seem to be populated correctly, however the issue still remains with the Live & Upcoming section. The first time you enter into Live & Upcoming it works fine but then you cannot enter into it again as it throws up an mktime script error, as below:
Code:
ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.OverflowError'>
Error Contents: mktime argument out of range
Traceback (most recent call last):
File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.nbcsnliveextra/nbcsn.py", line 478, in <module>
LIVE_AND_UPCOMING()
File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.nbcsnliveextra/nbcsn.py", line 37, in LIVE_AND_UPCOMING
SCRAPE_VIDEOS(ROOT_URL+'mcms/prod/nbc-upcoming-ios.json')
File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.nbcsnliveextra/nbcsn.py", line 83, in SCRAPE_VIDEOS
BUILD_VIDEO_LINK(item)
File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.nbcsnliveextra/nbcsn.py", line 172, in BUILD_VIDEO_LINK
event_start = datetime.fromtimestamp(time.mktime(time.strptime(start_time, pattern)))
OverflowError: mktime argument out of range
-->End of Python script error report<--EDIT: Changing the timezone to EST fixes the issues as in the previous version
2016-03-08, 18:43
Ok, thanks for reporting. I'm using bluestacks in order to simulate an android environment in windows. Just noticed it wasn't using the system clock set in windows. Now that i've changed it to GMT in bluestacks itself I am now able to get the error to pop.
