Posts: 3,771
Joined: Mar 2015
Reputation:
191
Yes, name of icons is not important, using Favourite.png or Reboot.png is also good.
And why not to put them in extras folder ?
Posts: 1,479
Joined: Jan 2015
Reputation:
159
If you mean to set them as {"icon": "special://skin/extras/Favorite.png"} that would complicate overriding them.
Posts: 3,771
Joined: Mar 2015
Reputation:
191
You can not just add file path in your code ?
Posts: 3,771
Joined: Mar 2015
Reputation:
191
2016-05-12, 04:25
(This post was last modified: 2016-05-12, 04:27 by Guilouz.)
I also note you have not updated your code with latest Krypton changes.
VideosSettings, MusicSettings, PicturesSettings, AppearanceSettings, WeatherSettings were removed
listitems.append( self._create(["ActivateWindow(AppearanceSettings)", "480", "10004", {} ]) ) must be change to listitems.append( self._create(["ActivateWindow(InterfaceSettings)", "14206", "14207", {} ]) )
listitems.append( self._create(["ActivateWindow(VideosSettings)", "3", "10004", {} ]) ) must be remove
listitems.append( self._create(["ActivateWindow(MusicSettings)", "2", "10004", {} ]) ) must be remove
listitems.append( self._create(["ActivateWindow(PicturesSettings)", "1", "10004", {} ]) ) must be remove
listitems.append( self._create(["ActivateWindow(WeatherSettings)", "8", "10004", {} ]) ) must be remove
listitems.append( self._create(["ActivateWindow(PlayerSettings)", "14200", "14201", {} ]) ) must be add
listitems.append( self._create(["ActivateWindow(LibrarySettings)", "14202", "14203", {} ]) ) must be add
Posts: 3,771
Joined: Mar 2015
Reputation:
191
No, I mean if you add {"icon": "special://skin/extras/Favorite.png"} directly in your code. It's not good ?
This beta is on last git ?
Posts: 1,479
Joined: Jan 2015
Reputation:
159
I'm easy if they link to the skins extra's folders or not though, as I said, it marginally increases the difficulty to override (from both the perspective of having to override 'special://skin/extras/Favorites.png' compared to just 'Favorites.png', and in terms of actually checking that the code supports overriding an action based on its complete path) - and personally, if I support the extra icons in my own skin mod I would be overriding them to icons in the media folder. Any other skinners have a preference?
No bugs were reported in the beta (which is, thanks to Marcelveldt, primarily done via the Emby beta repo - though I think I'm right in saying that Tomer has also distributed it), so the beta and the release are both the current master on git.
Posts: 3,771
Joined: Mar 2015
Reputation:
191
Matter to me. The main thing is that we can add or change icon where there is no icon.
Posts: 8,283
Joined: Jul 2014
(2016-05-12, 15:59)BobCratchett Wrote: No bugs were reported in the beta (which is, thanks to Marcelveldt, primarily done via the Emby beta repo - though I think I'm right in saying that Tomer has also distributed it), so the beta and the release are both the current master on git.
Correct, and a release to the kodi repo is pending
Posts: 8,283
Joined: Jul 2014
(2016-05-12, 22:43)BobCratchett Wrote: Thanks for the translation, bsoriano - I'll PR it to the master branch once the Eurovision semifinal is over. (Though I'm not 100% sure what our policy is whilst waiting for the repo update now it's all done via git - certainly we don't want to be adding features in case there are fixes required by the repo-guardians and the PR has to be rebased, though I don't think translations will make a difference...)
It's safe. repo update is in seperate branch