[DarrenHill]

Understand and agree, but lets get details first so that you're not wasting time adding a feature that won't work in the next version of LibreElec potentially, or would need to be revised for it.

Having everything running on my Pi is the solution I want, so what I have now is fine but if it needs tweaking for LE8 then so be it.

[im85288]

Not sure if this is an issue with only my setup but wanted to report it just in case it is not.

Running this addon on the stable Jarvis version of LibreElec, when I have selected a channel to play and go back to the guide to select a new one to play if I do not first stop the currently playing channel the next channel does not play and I think (sorry it was a couple of days ago I did proper testing) either the addon crashes out or libreelec crashes. If I make sure to first stop the currently playing channel before selecting a new one there are no issues at all.

If this is a new issue and you need a log please let me know. Cheers

[primaeval]

Not sure if this is an issue with only my setup but wanted to report it just in case it is not.

Running this addon on the stable Jarvis version of LibreElec, when I have selected a channel to play and go back to the guide to select a new one to play if I do not first stop the currently playing channel the next channel does not play and I think (sorry it was a couple of days ago I did proper testing) either the addon crashes out or libreelec crashes. If I make sure to first stop the currently playing channel before selecting a new one there are no issues at all.

If this is a new issue and you need a log please let me know. Cheers

Thanks for the report.

I wouldn't be surprised. Different addons start streams in very different ways and can be temperamental. There can be a lot of background processing involved including proxies, logins and webscraping.

If the addon isn't in the banned list please add a log if there is a visible error message (maybe debug), else send me a pm and I'll have a look.

[donbrew]

I only did the very basic webgrab++ setup. I only added my channels using tv.com and tvguide.co.uk to the config.xml template and changed the interval to 3 and let webgrab++ fly on its own the offsets are all UTC -5 for me. If WebGrab uses the offset correcter on its own I don't know.

Some time ago I had trouble recording shows on NextPVR; turned out somehow my computer changed its clock in BIOS and it stayed wrong.

That's very interesting. Thanks.

So you didn't even need to do the cookie setup for tv.com?

What device and operating system did you use?



Did you use the siteinipack or individual files?
Could you let us know which versions.

I have already found some strange inconsistencies in the logo handling. There might be more about offsets.
http://forum.kodi.tv/showthread.php?tid=...pid2391698

I meant I did the most basic setup; including cookies for both tv.com and tvguide.co.uk.

How often do tv.com cookies expire?

WebGrab doesn't seem to have a problem writing to the default location., the problem is I can't access ANY files from Windows 10. I can only get to the /storage/ level, can't see inside any of the folders. When I move xmltv to the /storage still can't see it. folders only not files.

I used the .ini files from the "channels" tab at WebGrab++ web site on my Windows PC. The Pi is using the siteini pack except for the faulty tvguide.co.uk. For reasons I have not explored yet I lost all of the data for my local channels.

I have a Pi 1 B. Wired Windows network. Libreelec 7.0.2 Kodi 16.1 from June 22.

tvguide.co.uk.ini is revision 14 koori
tv.com.ini revision 4 Blackbeard199 (that probably explains lack of logos from there)

[primaeval]

I only did the very basic webgrab++ setup. I only added my channels using tv.com and tvguide.co.uk to the config.xml template and changed the interval to 3 and let webgrab++ fly on its own the offsets are all UTC -5 for me. If WebGrab uses the offset correcter on its own I don't know.

Some time ago I had trouble recording shows on NextPVR; turned out somehow my computer changed its clock in BIOS and it stayed wrong.

That's very interesting. Thanks.

So you didn't even need to do the cookie setup for tv.com?

What device and operating system did you use?

Did you use the siteinipack or individual files?
Could you let us know which versions.

I have already found some strange inconsistencies in the logo handling. There might be more about offsets.
http://forum.kodi.tv/showthread.php?tid=...pid2391698

I meant I did the most basic setup; including cookies for both tv.com and tvguide.co.uk.

How often do tv.com cookies expire?

I thought you must have done the cookie step. I tried it without and got an error.

My guess now is that @iainmacleod might well have the offset due to using a vpn, as he mentioned.
tv.com thinks it is where the vpn comes out, maybe Scotland.
So the cookie file probably needs to be generated through the vpn too.

The cookies for me seem to expire in 2017 and 2019.

[iainmacleod]

I'm going to disable the vpn and do the webgrab, maybe even do the webgrab on a windows box as well as the pi which has the vpn and compare.

The only problem I see is why does TV Guide work and not TV Guide Fullscreen...and I'm not saying one is right or wrong, but the code that you sent @primaeval probably would give a clue. I'll look it again later. Going to do some basic testing at some point.

Thanks for not forgetting about me.

[im85288]

Thanks for the report.

I wouldn't be surprised. Different addons start streams in very different ways and can be temperamental. There can be a lot of background processing involved including proxies, logins and webscraping.

If the addon isn't in the banned list please add a log if there is a visible error message (maybe debug), else send me a pm and I'll have a look.

Thanks for offering to take a look, I tried again today to simulate those symptoms but could not.

I did however notice something almost related in that when I select a first channel to watch from the guide it takes me to the full screen and allows pressing back to go to the guide again, when I select the next channel to watch from the guide (with one currently playing) it starts playback in the background but the guide remains on the screen. Pressing back after that will then exit the addon altogether. Please let me know if providing a log for this would be useful.

[primaeval]

Thanks for the report.

I wouldn't be surprised. Different addons start streams in very different ways and can be temperamental. There can be a lot of background processing involved including proxies, logins and webscraping.

If the addon isn't in the banned list please add a log if there is a visible error message (maybe debug), else send me a pm and I'll have a look.

Thanks for offering to take a look, I tried again today to simulate those symptoms but could not.

I did however notice something almost related in that when I select a first channel to watch from the guide it takes me to the full screen and allows pressing back to go to the guide again, when I select the next channel to watch from the guide (with one currently playing) it starts playback in the background but the guide remains on the screen. Pressing back after that will then exit the addon altogether. Please let me know if providing a log for this would be useful.

I think that is expected behaviour. I didn't write the original TV Guide but I am pretty familiar with the code now.
More than I ever really wanted to be.

Could you try the same thing in the original TV Guide and see if it does the same thing.
You need to copy the addons.ini file from:
\userdata\addon_data\script.tvguide.fullscreen\addons.ini
to
\addons\script.tvguide\resources\addons.ini
Make a backup first.

You should be able to use the same xmltv file but the offsets might not work.

[Alex_geek]

Thanks!
great work!!

[im85288]

I think that is expected behaviour. I didn't write the original TV Guide but I am pretty familiar with the code now.
More than I ever really wanted to be.

Could you try the same thing in the original TV Guide and see if it does the same thing.
You need to copy the addons.ini file from:
\userdata\addon_data\script.tvguide.fullscreen\addons.ini
to
\addons\script.tvguide\resources\addons.ini
Make a backup first.

You should be able to use the same xmltv file but the offsets might not work.

Ah thanks, if it's expected behaviour that's no worries as I'll just use the fullscreen button to toggle. Out of curiosity though I'll give the original a shot this weekend and report back. Cheers.

[primaeval]

I think that is expected behaviour. I didn't write the original TV Guide but I am pretty familiar with the code now.
More than I ever really wanted to be.

Could you try the same thing in the original TV Guide and see if it does the same thing.
You need to copy the addons.ini file from:
\userdata\addon_data\script.tvguide.fullscreen\addons.ini
to
\addons\script.tvguide\resources\addons.ini
Make a backup first.

You should be able to use the same xmltv file but the offsets might not work.

Ah thanks, if it's expected behaviour that's no worries as I'll just use the fullscreen button to toggle. Out of curiosity though I'll give the original a shot this weekend and report back. Cheers.

Thanks. I am not immune to the odd late night bug.
If I am in the wrong or there is a better way to do it let me know and I'll fix it.

[im85288]

Thanks. I am not immune to the odd late night bug.
If I am in the wrong or there is a better way to do it let me know and I'll fix it.

Yeah I know what you mean, when your in the zone code comes out and testing get's pushed to a later date

No idea though like you said if it is a bug but I think it could possibly be resolved by using this JSON command:

http://kodi.wiki/view/JSON-RPC_API/v6#GUI.SetFullscreen

When the xbmc.player is playing video and playback of a new channel starts. Not 100% though as I have not used that command before..but it does sound like it may do the job.

[primaeval]

I did however notice something almost related in that when I select a first channel to watch from the guide it takes me to the full screen and allows pressing back to go to the guide again, when I select the next channel to watch from the guide (with one currently playing) it starts playback in the background but the guide remains on the screen. Pressing back after that will then exit the addon altogether. Please let me know if providing a log for this would be useful.

I just tried that carefully and it is expected behaviour.

Internally there are three modes: tv, epg and osd.

When you press play the first time you go into osd mode.

Press info(i) here to see the osd program info.

Press context(c,right mouse) or back to see the epg over the video window (or a preview window in the pip skin).

Changing the channel now will show the video in the background or preview window.

Pressing back will take you out of the guide.

To get back to the normal video window with osd press context(c,right mouse) again.

If you want to see the normal video overlays press fullscreen(tab), then osd(o) or menu(m).


Some plugins jump you out of the osd mode straight into normal fullscreen mode.

So pressing context here will take you out of the tv guide completely.

Press stop or fullscreen to get back to the epg.


Confused? You should be by now.

[im85288]

To get back to the normal video window with osd press context(c,right mouse) again.

If you want to see the normal video overlays press fullscreen(tab), then osd(o) or menu(m).

This explanation came just at the right time as I had noticed the different OSD from when I pressed info on the first channel played compared with the second one. Some nice hidden logic in there.

[iainmacleod]

You need to find out how to add an upstream origin to your fork and keep things in sync with the master repo.
https://help.github.com/articles/configu...or-a-fork/

When you have a rock solid change that you want me to include make a pull request.
Then there might be a discussion on Github about some changes that need to be done first.

The skin and python code are tightly coupled so even minor changes need quite a lot of thought and testing.
Making textures transparent or opaque affects the behaviour too.
If a video window is exposed Kodi will enter a different processing mode.
This has caused a lot of problems with missing video windows. See earlier in this thread.

OK I believe I managed to request a pull.

In addition I appear to have worked out the problem due to all the information and help from the group. It was due to the VPN (although my system time is right), if we look at the numbers - the UK is off 5 hours (which I am requesting in chans2correct.xml) while the US channels are off 4 hours (compared to the UK). So I think although my system time is configured to US and the appropriate timezone, the fact that I am VPN'd in to the UK results in chans2correct determining the wrong time Anyway, it looks like I have something to work with.

Thank you All!