2017-03-27, 23:25
(2017-03-27, 19:28)garbear Wrote: The milhouse builds are missing my savestate work from PR11034 . If you asked him, I'm sure he'd include it. I've fixed all the merge conflicts. Aside from that, the builds are only missing the temporary hack that forces .zip, .iso, .cue and .bin to be identified as games instead of videos. This can be accomplished by removing these extensions in advancedsettings.xml.
PR11034 needs to be rebased after the rapidjson change - building latest kodi master with PR11034 fails due to JSON changes, eg.
Code:
/home/neil/projects/kodi.git/xbmc/dbwrappers/DenormalizedDatabase.cpp: In member function ‘void CDenormalizedDatabase::AddIndexInternal(const char*, const char*)’:
/home/neil/projects/kodi.git/xbmc/dbwrappers/DenormalizedDatabase.cpp:341:90: error: invalid conversion from ‘const unsigned char*’ to ‘const char*’ [-fpermissive]
CVariant var = CJSONVariantParser::Parse(output, m_pDS->fv(1).get_asString().size());
^
If you can fix PR11034 I can include it, however it would be nice to see it merged sooner than later as I'd rather not "carry" it for too long (something in future is bound to break it, which means it will need rebasing, or dropping).