(2017-05-04, 08:59)primaeval Wrote: (2017-05-04, 06:10)JQZ* Wrote: Now I see why some folks refer to you as the master wizard p. Smooth scrolling in today's update to 0.x(x).340. Brilliant! That took you next to no time to figure out. The KJB skin now scrolls perfectly with the mouse wheel. I don't see any changes in the skins files that may have addressed that. And it seems it's the only skin that scrolls that smoothly, or am I missing something? I'd love to incorporate whatever you did into Andy's skin.
And I now see that gorgeous new OSD menu in KJB I missed the other day. Can't see why anyone would want to go back to the older one. Unless I'm mistaken here, one thing you may want to add to the setup instructions would be to set 'Lab1 >Fall back to channel logo for program image - Enabled'. And I see with that set Andy's skin along with 'Scale program image - Disabled', it achieves that look I was going for too.
Just one minor complaint. On one system the guide update failed today. The other day I tried uninstalling KJB and updating it. But I kept getting the "Update failed" notification. So today I had to uninstall the guide and skins and then reinstall them again. I had made copies of the guide and all skin folders in \Kodi\addons beforehand for reference. But reinstalling them all wiped out all my backup copies as well as the primary folders. Luckily I had some backed up in another location as was able to copy back my work.
Thanks.
The trick with the scrolling is in the code not the skins. I reorganised the code so that removing and adding the new epg program buttons is done next to each other so there is almost no time for the screen to be drawn with an empty epg. There is a further thing I can do in Krypton to lock the screen while the redrawing is done but I'm not going to add that yet as it doesn't work in Jarvis.
https://github.com/primaeval/script.tvgu...57a4cd7f0b
The program logo fallback is kjb85's own preference. It looks awful for me because I use smaller logos and they look ugly when you can see all the stretch marks.
Don't try to do any modifications in the addons folder or they will get wiped out by an update.
Turn off auto-updates first.
You can either put just the skin folder in the addon_data folder:
http://forum.kodi.tv/showthread.php?tid=...pid2491843
or copy one of the installer addons and change its id and folder from say
script.tvguide.fullscreen.skin.kjb85
to
script.tvguide.fullscreen.skin.jqz
If you want the skin to run in Jarvis make sure you change all these in the xml
String.IsEqual
to
StringCompare
Thanks for the tips @
primaeval. I moved all my skin work over to the data folder and can enable them in 'Your' settings now.
Lesson learned, and I won't be doing it again, but I'm still pondering why uninstalling all sklns and guide, then reinstalling them all ended up deleting whole backed up \addon folders. I had all these before. They all vanished after:
script.tvguide.fullscreen - copy
script.tvguide.fullscreen.skin.andy - copy
script.tvguide.fullscreen.skin.kjb85 - copy
script.tvguide.fullscreen.skin.lapis - copy
script.tvguide.fullscreen.skin.tycoo - copy
I'm guessing the uninstaller just didn't parse the full folder names before removing them.
The program logo fallback looks okay here. I'm using a channel logo pack from another guide and they blow up fairly well unless I have 'Scale' set.
Modding Andy's skin is coming along. I did attempt to get the program images to fall back (with fall back to channel logo
disabled in settings) to a preset image like the
<!-- # Program Image Box / PIP # --> section of tycoo's white skin main xml when none is available. Andy used the same code, but it wasn't working. I noticed he had String.IsEqual set for calling the texture. Reflecting on what you wrote about Jarvis, I changed it back to StringCompare as tycoo had it. That managed to get some program cells to display the testcard.png texture that was set. But unlike tycoo's skin that always falls back, a lot of channels lacking images are drawn as a black square (or rectangle with 'scale' set) and not testcard.png. Maybe it's a setting I'm missed. I see tycoo has Small EPG Video Preview disabled, but I get no program images at all if I set that. Wonder if he's customized the python code for his skin.
As for smooth mouse scrolling, I'm still only seeing it in certain skins. I may be wrong, but I thought I remembered tycoo's had been scrolling fine even before your update. Along with KJB, Carnelian and Onyx all scroll fine too. But mouse scrolling in your Default and Catbar, still causes the program grid background to go black. And I've failed to get Andy's to scroll right. Funny thing.. your Dark skin scrolls well.
Still, it's only been a week since I taken on tvgfs, and I'm loving it