[knightbaker]

Just installed IARL on Ubuntu 16.04, Kodi 17.6  I'm getting a 'ERROR:  IARL:  Unzip Failed...' on all games it downloads as a zip.  Games downloaded as a regular file load fine.  I also get an error message when I try to manually unzip the downloaded game file in both the GUI and in the terminal.  I can manually unzip other files (such as the Zach Morris Repo file) just fine.  Realize this is more of ubuntu question than a IARL (and I'm a linux novice), but any suggestions would be welcome.  Thanks!

 The error I get when I manually try to unzip the game file is:  warning [xx.zip]:  40 extra bytes at beginning or within zipfile
  (attempting to process anyway)  file #1:  bad zipfile offset (local header sig):  40   (attempting to re-compensate) file #1:  bad zipfile offset (local header sig):  40

Or with 7-zip:  Processing archive: xx.zip   Extracting  xx.sfc     Unsupported Method Sub items Errors: 1

Same issue for all games downloaded as zips, none work (Uncompressed game files load fine.)  

Can you provide a debug log?  I can't recreate this issue 

Thanks Zach (and for the plugin, btw!)  Like this?:
16:25:24.014 T:139894248691456  NOTICE: [plugin.video.youtube] Startup: detected Krypton (Kodi-17.6), setting DASH_SUPPORT_BUILTIN = False, DASH_SUPPORT_ADDON = True
16:25:25.735 T:139895594166016   ERROR: GetDirectory - Error getting
16:25:26.350 T:139894028109568   ERROR: Previous line repeats 6 times.
16:25:26.350 T:139894028109568  NOTICE: IARL:  Lets Play!
16:25:26.411 T:139894028109568  NOTICE: [resources.lib.xbmcswift2b] Request for "/" matches rule for function "index"
16:25:34.611 T:139894563862272  NOTICE: IARL:  Lets Play!
16:25:34.699 T:139894563862272  NOTICE: [resources.lib.xbmcswift2b] Request for "/Emulator/SNES_Bestof_ZachMorris/1" matches rule for function "get_rom_page"
16:25:41.496 T:139894563862272  NOTICE: IARL:  Lets Play!
16:25:41.547 T:139894563862272  NOTICE: [resources.lib.xbmcswift2b] Request for "/Emulator/SNES_Bestof_ZachMorris/Game/33.++SimCity" matches rule for function "get_selected_rom"
16:25:41.548 T:139894563862272 WARNING: CSkinInfo: failed to load skin settings
16:25:43.658 T:139894563862272  NOTICE: IARL:  Download and Launch started for 33.  SimCity
16:25:43.676 T:139894563862272  NOTICE: IARL:  Download started for 33.  SimCity
16:25:44.605 T:139894563862272   ERROR: IARL:  Unzip Failed for /home/htpc/.kodi/userdata/addon_data/plugin.program.iarl/temp_iarl/SimCity (USA).zip
16:25:44.605 T:139894563862272   ERROR: IARL:  There was an error unzipping files for 33.  SimCity
16:25:44.608 T:139894563862272   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.TypeError'>
                                            Error Contents: expected a string or other character buffer object
                                            Traceback (most recent call last):
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/addon.py", line 1951, in onClick
                                                download_and_launch_rom(self,iarl_data)
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/addon.py", line 1678, in download_and_launch_rom
                                                current_external_command = replace_external_launch_variables(iarl_data) #Function replaces command line variables
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/resources/lib/util.py", line 847, in replace_external_launch_variables
                                                command_out = command_out.replace('%ROM_PATH%',iarl_data['current_save_data']['launch_filename']) #Replace ROM filepath
                                            TypeError: expected a string or other character buffer object
                                            -->End of Python script error report<--

[zachmorris]

 The error I get when I manually try to unzip the game file is:  warning [xx.zip]:  40 extra bytes at beginning or within zipfile
  (attempting to process anyway)  file #1:  bad zipfile offset (local header sig):  40   (attempting to re-compensate) file #1:  bad zipfile offset (local header sig):  40

Or with 7-zip:  Processing archive: xx.zip   Extracting  xx.sfc     Unsupported Method Sub items Errors: 1

Same issue for all games downloaded as zips, none work (Uncompressed game files load fine.)  

Can you provide a debug log?  I can't recreate this issue  

Thanks Zach (and for the plugin, btw!)  Like this?:
16:25:24.014 T:139894248691456  NOTICE: [plugin.video.youtube] Startup: detected Krypton (Kodi-17.6), setting DASH_SUPPORT_BUILTIN = False, DASH_SUPPORT_ADDON = True
16:25:25.735 T:139895594166016   ERROR: GetDirectory - Error getting
16:25:26.350 T:139894028109568   ERROR: Previous line repeats 6 times.
16:25:26.350 T:139894028109568  NOTICE: IARL:  Lets Play!
16:25:26.411 T:139894028109568  NOTICE: [resources.lib.xbmcswift2b] Request for "/" matches rule for function "index"
16:25:34.611 T:139894563862272  NOTICE: IARL:  Lets Play!
16:25:34.699 T:139894563862272  NOTICE: [resources.lib.xbmcswift2b] Request for "/Emulator/SNES_Bestof_ZachMorris/1" matches rule for function "get_rom_page"
16:25:41.496 T:139894563862272  NOTICE: IARL:  Lets Play!
16:25:41.547 T:139894563862272  NOTICE: [resources.lib.xbmcswift2b] Request for "/Emulator/SNES_Bestof_ZachMorris/Game/33.++SimCity" matches rule for function "get_selected_rom"
16:25:41.548 T:139894563862272 WARNING: CSkinInfo: failed to load skin settings
16:25:43.658 T:139894563862272  NOTICE: IARL:  Download and Launch started for 33.  SimCity
16:25:43.676 T:139894563862272  NOTICE: IARL:  Download started for 33.  SimCity
16:25:44.605 T:139894563862272   ERROR: IARL:  Unzip Failed for /home/htpc/.kodi/userdata/addon_data/plugin.program.iarl/temp_iarl/SimCity (USA).zip
16:25:44.605 T:139894563862272   ERROR: IARL:  There was an error unzipping files for 33.  SimCity
16:25:44.608 T:139894563862272   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.TypeError'>
                                            Error Contents: expected a string or other character buffer object
                                            Traceback (most recent call last):
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/addon.py", line 1951, in onClick
                                                download_and_launch_rom(self,iarl_data)
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/addon.py", line 1678, in download_and_launch_rom
                                                current_external_command = replace_external_launch_variables(iarl_data) #Function replaces command line variables
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/resources/lib/util.py", line 847, in replace_external_launch_variables
                                                command_out = command_out.replace('%ROM_PATH%',iarl_data['current_save_data']['launch_filename']) #Replace ROM filepath
                                            TypeError: expected a string or other character buffer object
                                            -->End of Python script error report<-- 

That particular game is working for me.  There's still some debug info not included.  If you go into Kodi settings>System Settings>Logging>Enable Debug Logging and then do the same exact thing that might provide a little more info.  Also, you can post the log to pastebin if possible, it's cleaner that way.

[knightbaker]

Can you provide a debug log?  I can't recreate this issue  

Thanks Zach (and for the plugin, btw!)  Like this?:
16:25:24.014 T:139894248691456  NOTICE: [plugin.video.youtube] Startup: detected Krypton (Kodi-17.6), setting DASH_SUPPORT_BUILTIN = False, DASH_SUPPORT_ADDON = True
16:25:25.735 T:139895594166016   ERROR: GetDirectory - Error getting
16:25:26.350 T:139894028109568   ERROR: Previous line repeats 6 times.
16:25:26.350 T:139894028109568  NOTICE: IARL:  Lets Play!
16:25:26.411 T:139894028109568  NOTICE: [resources.lib.xbmcswift2b] Request for "/" matches rule for function "index"
16:25:34.611 T:139894563862272  NOTICE: IARL:  Lets Play!
16:25:34.699 T:139894563862272  NOTICE: [resources.lib.xbmcswift2b] Request for "/Emulator/SNES_Bestof_ZachMorris/1" matches rule for function "get_rom_page"
16:25:41.496 T:139894563862272  NOTICE: IARL:  Lets Play!
16:25:41.547 T:139894563862272  NOTICE: [resources.lib.xbmcswift2b] Request for "/Emulator/SNES_Bestof_ZachMorris/Game/33.++SimCity" matches rule for function "get_selected_rom"
16:25:41.548 T:139894563862272 WARNING: CSkinInfo: failed to load skin settings
16:25:43.658 T:139894563862272  NOTICE: IARL:  Download and Launch started for 33.  SimCity
16:25:43.676 T:139894563862272  NOTICE: IARL:  Download started for 33.  SimCity
16:25:44.605 T:139894563862272   ERROR: IARL:  Unzip Failed for /home/htpc/.kodi/userdata/addon_data/plugin.program.iarl/temp_iarl/SimCity (USA).zip
16:25:44.605 T:139894563862272   ERROR: IARL:  There was an error unzipping files for 33.  SimCity
16:25:44.608 T:139894563862272   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.TypeError'>
                                            Error Contents: expected a string or other character buffer object
                                            Traceback (most recent call last):
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/addon.py", line 1951, in onClick
                                                download_and_launch_rom(self,iarl_data)
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/addon.py", line 1678, in download_and_launch_rom
                                                current_external_command = replace_external_launch_variables(iarl_data) #Function replaces command line variables
                                              File "/home/htpc/.kodi/addons/plugin.program.iarl/resources/lib/util.py", line 847, in replace_external_launch_variables
                                                command_out = command_out.replace('%ROM_PATH%',iarl_data['current_save_data']['launch_filename']) #Replace ROM filepath
                                            TypeError: expected a string or other character buffer object
                                            -->End of Python script error report<--        

That particular game is working for me.  There's still some debug info not included.  If you go into Kodi settings>System Settings>Logging>Enable Debug Logging and then do the same exact thing that might provide a little more info.  Also, you can post the log to pastebin if possible, it's cleaner that way.       

 Sorry about that, I'm a rookie with this. How about this:

:

 
https://pastebin.com/QP9RsKE5
I get the same error with most games, it's just a few simple ones that load. Thanks.

[knightbaker]

Thanks Zach (and for the plugin, btw!)  Like this?:
 

That particular game is working for me.  There's still some debug info not included.  If you go into Kodi settings>System Settings>Logging>Enable Debug Logging and then do the same exact thing that might provide a little more info.  Also, you can post the log to pastebin if possible, it's cleaner that way.        

 Sorry about that, I'm a rookie with this. How about this:

:

 
https://pastebin.com/QP9RsKE5
I get the same error with most games, it's just a few simple ones that load. Thanks. 

 Hi Zach, thanks.  For some reason this forum won't let me reply to your private message...  So downloading directly from that link and uncompressing with right-click 'extract' works just fine. 
However, attempting to unzip in the terminal gives an error, apparently doesn't like ( ) in the file names.  Renamed the zip and it worked fine.  https://pastebin.com/5i6ZVvdC
Regardless, the file IARL downloaded won't manually unzip in either case (with a right-click or renamed in the terminal). Does IARL add anything to the zip file, or alter in any way?

[knightbaker]

...  Just a follow up, I copied both zip files: the file IARL downloaded and the file manually downloaded from archive.org - exact same file name - and tried to extract on a different windows PC.  The manual extracted fine, the IARL one gave a 'The Compressed (zipped) Folder is Invalid' error.  The good one is 226,305 bytes,  the problem one 226,335 bytes, so somewhere along the line 30 bytes is messing up the works.  Any ideas?  Thanks.

[zachmorris]

...  Just a follow up, I copied both zip files: the file IARL downloaded and the file manually downloaded from archive.org - exact same file name - and tried to extract on a different windows PC.  The manual extracted fine, the IARL one gave a 'The Compressed (zipped) Folder is Invalid' error.  The good one is 226,305 bytes,  the problem one 226,335 bytes, so somewhere along the line 30 bytes is messing up the works.  Any ideas?  Thanks.

 Hmm.  Very strange.  I tried this on Ubuntu 16.04, Windows, OSX, LibreElec and can't reproduce it.  The command line thing you're experiencing is likely a quotation thing.  I think it would work if you tried:

cpp:
unzip "path/to/file/Mario (Rev A).zip"

The file thats returned for me from IARL is 226,305 bytes in all cases, and the file is unzipped and then launched correctly, so your system is doing something weird.  If you can get PM's straightened out we can try and figure it out (you may have to post in the forms 10 times before PM is allowed).

[knightbaker]

...  Just a follow up, I copied both zip files: the file IARL downloaded and the file manually downloaded from archive.org - exact same file name - and tried to extract on a different windows PC.  The manual extracted fine, the IARL one gave a 'The Compressed (zipped) Folder is Invalid' error.  The good one is 226,305 bytes,  the problem one 226,335 bytes, so somewhere along the line 30 bytes is messing up the works.  Any ideas?  Thanks.

 Hmm.  Very strange.  I tried this on Ubuntu 16.04, Windows, OSX, LibreElec and can't reproduce it.  The command line thing you're experiencing is likely a quotation thing.  I think it would work if you tried:

cpp:
unzip "path/to/file/Mario (Rev A).zip"

The file thats returned for me from IARL is 226,305 bytes in all cases, and the file is unzipped and then launched correctly, so your system is doing something weird.  If you can get PM's straightened out we can try and figure it out (you may have to post in the forms 10 times before PM is allowed). 

Not pretending I know what I'm doing but opened both zip files in notepad.  The IARL downloaded file has an extra line at the top of the code with 'ff2a', and an extra line at the bottom with '0'
Tried another game and 'ff04' was added to the top and '0' to the bottom.  Mean anything?

[zachmorris]

...  Just a follow up, I copied both zip files: the file IARL downloaded and the file manually downloaded from archive.org - exact same file name - and tried to extract on a different windows PC.  The manual extracted fine, the IARL one gave a 'The Compressed (zipped) Folder is Invalid' error.  The good one is 226,305 bytes,  the problem one 226,335 bytes, so somewhere along the line 30 bytes is messing up the works.  Any ideas?  Thanks.

 Hmm.  Very strange.  I tried this on Ubuntu 16.04, Windows, OSX, LibreElec and can't reproduce it.  The command line thing you're experiencing is likely a quotation thing.  I think it would work if you tried:

cpp:
unzip "path/to/file/Mario (Rev A).zip"

The file thats returned for me from IARL is 226,305 bytes in all cases, and the file is unzipped and then launched correctly, so your system is doing something weird.  If you can get PM's straightened out we can try and figure it out (you may have to post in the forms 10 times before PM is allowed).   

Not pretending I know what I'm doing but opened both zip files in notepad.  The IARL downloaded file has an extra line at the top of the code with 'ff2a', and an extra line at the bottom with '0'
Tried another game and 'ff04' was added to the top and '0' to the bottom.  Mean anything?  

Not to me...

Here's a couple of things to try:
1)  Enable login and enter some valid login settings.  This in itself shouldn't have anything to do with it, but my code is messy enough that logged in vs. not logged in use two different methods to save the file from the URL (pythons urlretrieve/urllib vs requests - I should clean this up at some point).  I've tried both ways on my setup and there was no difference (both work)
2)  In IARL settings>Advanced Settings>Enable Post DL Command Editing
Then go into IARL and highlight the game list, then update Post DL command, and change it to None (by default it's set to unzip the file after download).  Retroarch for many systems now supports launching zip files directly.  If the file itself is corrupt this probably wont work anyway, but it's worth a shot.

[knightbaker]

 Hmm.  Very strange.  I tried this on Ubuntu 16.04, Windows, OSX, LibreElec and can't reproduce it.  The command line thing you're experiencing is likely a quotation thing.  I think it would work if you tried:

cpp:
unzip "path/to/file/Mario (Rev A).zip"

The file thats returned for me from IARL is 226,305 bytes in all cases, and the file is unzipped and then launched correctly, so your system is doing something weird.  If you can get PM's straightened out we can try and figure it out (you may have to post in the forms 10 times before PM is allowed).   

Not pretending I know what I'm doing but opened both zip files in notepad.  The IARL downloaded file has an extra line at the top of the code with 'ff2a', and an extra line at the bottom with '0'
Tried another game and 'ff04' was added to the top and '0' to the bottom.  Mean anything?   

Not to me...

Here's a couple of things to try:
1)  Enable login and enter some valid login settings.  This in itself shouldn't have anything to do with it, but my code is messy enough that logged in vs. not logged in use two different methods to save the file from the URL (pythons urlretrieve/urllib vs requests - I should clean this up at some point).  I've tried both ways on my setup and there was no difference (both work)
2)  In IARL settings>Advanced Settings>Enable Post DL Command Editing
Then go into IARL and highlight the game list, then update Post DL command, and change it to None (by default it's set to unzip the file after download).  Retroarch for many systems now supports launching zip files directly.  If the file itself is corrupt this probably wont work anyway, but it's worth a shot. 

Yep, that fixed it.  Logged in with archive.org and now downloads/launches as smooth as clockwork.  So seems the not-logged in download method is doing something to add a few extra characters and mess up the zip file in Ubuntu (or at least my install).  I have a fairly fresh and clean install on an older PC to just run Kodi and a browser for other streamed content.  Thanks for the help Zach and the fun addon, takes me right back to my 80's youth.  Cheers!

[zachmorris]

Not pretending I know what I'm doing but opened both zip files in notepad.  The IARL downloaded file has an extra line at the top of the code with 'ff2a', and an extra line at the bottom with '0'
Tried another game and 'ff04' was added to the top and '0' to the bottom.  Mean anything?   

Not to me...

Here's a couple of things to try:
1)  Enable login and enter some valid login settings.  This in itself shouldn't have anything to do with it, but my code is messy enough that logged in vs. not logged in use two different methods to save the file from the URL (pythons urlretrieve/urllib vs requests - I should clean this up at some point).  I've tried both ways on my setup and there was no difference (both work)
2)  In IARL settings>Advanced Settings>Enable Post DL Command Editing
Then go into IARL and highlight the game list, then update Post DL command, and change it to None (by default it's set to unzip the file after download).  Retroarch for many systems now supports launching zip files directly.  If the file itself is corrupt this probably wont work anyway, but it's worth a shot.  

Yep, that fixed it.  Logged in with archive.org and now downloads/launches as smooth as clockwork.  So seems the not-logged in download method is doing something to add a few extra characters and mess up the zip file in Ubuntu (or at least my install).  I have a fairly fresh and clean install on an older PC to just run Kodi and a browser for other streamed content.  Thanks for the help Zach and the fun addon, takes me right back to my 80's youth.  Cheers! 

OK, thanks for the report and troubleshooting.  I assume there's something going on with urllib/urlretrieve but no idea what.  I'll add it to my list of things to clean up for the next update

[tsill91]

@zachmorris Hey do you take like special request for games added on your program my friend and I was curious if you did or not because we was wanting to play streets of rage 3 on the Sega Genesis and also games like Baulders Gate Dark Alliance 2 on the ps1 and other games like that there are a few.

[zachmorris]

@zachmorris Hey do you take like special request for games added on your program my friend and I was curious if you did or not because we was wanting to play streets of rage 3 on the Sega Genesis and also games like Baulders Gate Dark Alliance 2 on the ps1 and other games like that there are a few.

 In the latest version of the addon, you can navigate to IARL Extras, then download the Genesis or PS1 list unfiltered.  If the game isn't listed there, then it's not available from the archive.

[Berl]

@zachmorris Hey do you take like special request for games added on your program my friend and I was curious if you did or not because we was wanting to play streets of rage 3 on the Sega Genesis and also games like Baulders Gate Dark Alliance 2 on the ps1 and other games like that there are a few.

 In the latest version of the addon, you can navigate to IARL Extras, then download the Genesis or PS1 list unfiltered.  If the game isn't listed there, then it's not available from the archive. 

Yo, Zack!   hope you can help me out with this.

ActivateWindow(Videos,"plugin://plugin.program.iarl",return)

i created sub folder in plugin.program.iarl/dat_files/
put copies of all of best of lists in there

plugin.program.iarl/dat_files/bestof/bestof.lists.xml

is it possible to return?

thank you in advance.

[zachmorris]

@zachmorris Hey do you take like special request for games added on your program my friend and I was curious if you did or not because we was wanting to play streets of rage 3 on the Sega Genesis and also games like Baulders Gate Dark Alliance 2 on the ps1 and other games like that there are a few.

 In the latest version of the addon, you can navigate to IARL Extras, then download the Genesis or PS1 list unfiltered.  If the game isn't listed there, then it's not available from the archive.   

Yo, Zack!   hope you can help me out with this.

ActivateWindow(Videos,"plugin://plugin.program.iarl",return)

i created sub folder in plugin.program.iarl/dat_files/
put copies of all of best of lists in there

plugin.program.iarl/dat_files/bestof/bestof.lists.xml

is it possible to return?

thank you in advance.  

The addon currently doesn't support dat files in folders.  But, I think I understand what you're trying to do.  Take a look at this example I put together quickly.  This xml list is just a list that links to other lists.  If you didn't want the 'Best of NES' and 'Best of SNES' to show up in the main list when the addon starts, you can hide them, and then use the example collector/folder list I linked to get into them (just because a list is hidden doesn't mean you can't link into it).  Does this make sense?

[houdin24]

on lela version retroplayer libreelec it seems the context type menu not working for choosing options will that be fixed anytime soon

Sent from my SM-N950U