2018-06-01, 12:06
(2018-06-01, 11:46)Angelinas Wrote: ListItem.Rating(foo)Thanks. PR filed: https://github.com/xbmc/xbmc/pull/13963
Now is fixed, I confirm the fix working and resultat for rating work as should.
(2018-06-01, 11:46)Angelinas Wrote: ListItem.Rating(foo)Thanks. PR filed: https://github.com/xbmc/xbmc/pull/13963
Now is fixed, I confirm the fix working and resultat for rating work as should.
(2018-06-01, 11:18)ksooo Wrote:I don't use Windows build but Angelinas confirmed it's fixed. Thanks.(2018-05-31, 22:54)ksooo Wrote:@Guilouz could you give this test build a try and report back? => http://mirrors.xbmc.org/test-builds/wind...ng-x86.exe(2018-05-30, 12:09)Guilouz Wrote: Hi ksooo,I don't think this is related to this thread.
Is it related to this thread ?
There is an issue with $INFO[ListItem.Rating(imdb)], it return same rating as $INFO[ListItem.Rating(themoviedb)].
Tested on dialog video info window. I use The Move Database scrapper addon and 'Also add IMDd ratings' is enable in settings.
$INFO[ListItem.RatingAndVotes(imdb)] and $INFO[ListItem.RatingAndVotes(themoviedb)] are working correctly.
In Red wrong ratings with ListItem.Rating(foo) and In yellow good ratings with ListItem.RatingAndVotes(foo)
EDIT: On second thought, it could actually be. Give me some more time, please.
Skin.String(string1,string2)
String.IsEqual(Skin.String(string1),string2)
Skin.String(string1,string2)
Skin.String(string1,)
(2018-06-02, 01:00)Gade Wrote: Thanks for the great work on these commits.Is it only not working if string2 is empty? Does it work if string 2 is not empty?
Before this commit it was possible comparing one skin string to another using
Code:Skin.String(string1,string2)
Now you have to use
Code:String.IsEqual(Skin.String(string1),string2)
I can see a lot of skins rely on the first example.
https://kodi.wiki/view/List_of_boolean_conditions#Skin
Skin.String(string,)
String.IsEmpty(Skin.String(string))
(2018-06-02, 14:45)Gade Wrote: Yeah, it seems that some old bools from before I took over Rapier now is not working anymore after PR13754:Fix is underway: https://github.com/xbmc/xbmc/pull/13970
I haven't given the bools much thought as they worked fine before this commit, and have just continued using them over the years.Code:Skin.String(string,)
But they're not very logic and using
makes much more sense code wise.Code:String.IsEmpty(Skin.String(string))
After replacing the bools everything works perfectly again.
Thank the higher powers for search/replace!
Thanks!
(2018-06-02, 22:35)ksooo Wrote:(2018-06-02, 14:45)Gade Wrote: Yeah, it seems that some old bools from before I took over Rapier now is not working anymore after PR13754:Fix is underway: https://github.com/xbmc/xbmc/pull/13970
I haven't given the bools much thought as they worked fine before this commit, and have just continued using them over the years.Code:Skin.String(string,)
But they're not very logic and using
makes much more sense code wise.Code:String.IsEmpty(Skin.String(string))
After replacing the bools everything works perfectly again.
Thank the higher powers for search/replace!
Thanks!
(2018-06-02, 22:35)ksooo Wrote: Fix is underway: https://github.com/xbmc/xbmc/pull/13970I have reported that skin with this changes now broke, All AeonMQ skin and mode (Maybe and other skin).
(2018-06-04, 10:18)Angelinas Wrote:I can also confirm that Titan Leia Beta is now broke with theses changes as well using Milhouse build #0602 (LibreELEC-Generic.x86_64-9.0-Milhouse-20180602222909-230602-g330aad4)(2018-06-02, 22:35)ksooo Wrote: Fix is underway: https://github.com/xbmc/xbmc/pull/13970I have reported that skin with this changes now broke, All AeonMQ skin and mode (Maybe and other skin).
User use this version KodiSetup-20180603-dba439f5-master-x64.exe
I can't try to see what is broken, I need version for test Win x86.Can you put test version with your changes in
http://mirrors.kodi.tv/test-builds/windows/win32/
tnx...can you chek too https://github.com/xbmc/xbmc/pull/13970
(2018-06-04, 17:22)Aenima99x Wrote:(2018-06-04, 10:18)Angelinas Wrote:I can also confirm that Titan Leia Beta is now broke with theses changes as well using Milhouse build #0602 (LibreELEC-Generic.x86_64-9.0-Milhouse-20180602222909-230602-g330aad4)(2018-06-02, 22:35)ksooo Wrote: Fix is underway: https://github.com/xbmc/xbmc/pull/13970I have reported that skin with this changes now broke, All AeonMQ skin and mode (Maybe and other skin).
User use this version KodiSetup-20180603-dba439f5-master-x64.exe
I can't try to see what is broken, I need version for test Win x86.Can you put test version with your changes in
http://mirrors.kodi.tv/test-builds/windows/win32/
tnx...can you chek too https://github.com/xbmc/xbmc/pull/13970