2019-08-03, 14:19
(2019-08-03, 06:20)Snapcase Wrote:(2019-08-03, 05:47)Doobie Wrote:(2019-08-03, 04:32)Snapcase Wrote: Good catch about the continue/break/return thing, I had fixed it wrong!
Can you try this one: https://github.com/zim514/script.service...v0.7.5dev1
ffmpeg is used by Kodi but I'm not using it directly so I'm not sure what those lines are about. It could be related to the screen capture I'm doing but it could also just be the video player. If the capture doesn't work it's supposed to just skip and try again (the bug you caught). The capture is async and seems to sometimes fail while its starting or stopping the video.
The default color thing is only to replace very dark frames. If you set the black filter setting to 1, it should never do it. I put it in because I noticed with older SD content in very dark scenes it would go full bright red or green because of artefacts, but with newer HD content its never a problem and leaving it to the lowest/off seems to be fine.
As for the colours, what kind of bulbs or lamps do you have and what are you watching? I have the Hue Play bars and with colorful stuff they're surprisingly accurate, especially with animation or movies with distinctive colours like John Wick. For live action or talk shows or sitcoms it usually ends up being a background colour or skin tones that usually just turn out to be neutral white tone colours.python:if colors[0].rgb.r < self.blackFilter and colors[0].rgb.g < self.blackFilter and colors[0].rgb.b <self.blackFilter:
#logger.debug("rgb filter: r,g,b: {},{},{}".format(colors[0].rgb.r,colors[0].rgb.g,colors[0].rgb.b))
if self.defaultRecipe: #defaultRecipe=0: Do nothing
xy=HUE_RECIPES[self.defaultRecipe]["xy"]#Apply XY value from default recipe setting
for L in self.ambiLights:
x = Thread(target=self._updateHueXY,name="updateHue", args=(xy,L,self.transitionTime))
x.daemon = True
x.start()
I am talking about the above code. The continue will work and then it gets down to the if statement. If there is no recipe I think the colors will not change.
I am using play bars too.
I will test again.
Hi Doobie,
That's actually the intention, but there's a condition based on the colours and the black filter setting just above it. Sometimes when the frame is really dark the RGB colour is 1,1,2 or 1,2,1 or something like that which is basically black. Since Hue doesn't produce blacks it turns into 100% white, which just looks bad with really dark stuff like that final season game of thrones episode. If you choose "do nothing", it will just keep the previous colour until the next frame. It should only do that based on the setting called "black filter", which you can just set as low as possible.
But this is really just a tweak I thought made it look better. I've been tweaking it a lot which is why I have so many settings in there but once I figure out what looks best I'll probably remove some of those.
Quote:019-08-03 08:15:27.472 T:3803575088 ERROR: [script.service.hue][AmbiGroup][_ambiLoop](117): capImage is none or <50: 0,
2019-08-03 08:15:27.534 T:4087339840 ERROR: Previous line repeats 154 times.
2019-08-03 08:15:27.534 T:4087339840 DEBUG: AMLUtils::aml_handle_display_stereo_mode old mode 3doff new mode 3doff
2019-08-03 08:15:27.534 T:4087339840 DEBUG: AMLUtils::aml_handle_display_stereo_mode - no change needed
2019-08-03 08:15:27.534 T:3803575088 ERROR: [script.service.hue][AmbiGroup][_ambiLoop](117): capImage is none or <50: 0,
2019-08-03 08:15:27.553 T:4087339840 ERROR: Previous line repeats 43 times.
2019-08-03 08:15:27.553 T:4087339840 INFO: GLES: Maximum texture width: 8192
2019-08-03 08:15:27.553 T:3803575088 ERROR: [script.service.hue][AmbiGroup][_ambiLoop](117): capImage is none or <50: 0,
2019-08-03 08:15:27.560 T:4087339840 ERROR: Previous line repeats 14 times.
2019-08-03 08:15:27.560 T:4087339840 DEBUG: CGUIWindowManager:reviousWindow: Activate new
2019-08-03 08:15:27.560 T:3803575088 ERROR: [script.service.hue][AmbiGroup][_ambiLoop](117): capImage is none or <50: 0,
