2019-08-30, 12:56
2019-09-16, 22:38
So since there has been some discussion here I thought I'd provide what I remember from almost three years ago (which might be a bit fuzzy):
* The latest state of the work is located in the media_import branch on my github fork of kodi.
* The list of known bugs / TODOs in https://forum.kodi.tv/showthread.php?tid...pid1986018 is still pretty much up-to-date. Most of them are non-essential. IMO the architecture works.
* There is only support for videos because I first wanted to get that right before tackling music (and I don't use music that much in Kodi).
* IMO the only way this will ever really have an impact is if media imports can be written as python plugins. Writing them in C++ as part of Kodi may offer more immediate options for the developer but the barrier is also much higher. That's what I've been working on last with the Emby demo add-on. The main problem right now is that the add-on settings system is too static. You can't populate a setting option with a dynamic list of choices. This was very easy in my initial C++ implementation but it's currently not possible in the add-on implementation.
* The main reason I never created a PR for the whole feature was that I only barely had time to work on the feature itself and would have been overwhelmed if I had to fix all bugs the feature introduced. And I also didn't want to put that burden on the other developers which don't even know the implementation of the feature yet.
Unfortunately due to family matters (own house, small daughter) I don't have any time for coding in my (non-existing) free time anymore. I would probably be able to support someone in understanding the architecture etc. but right now there is no real documentation
* The latest state of the work is located in the media_import branch on my github fork of kodi.
* The list of known bugs / TODOs in https://forum.kodi.tv/showthread.php?tid...pid1986018 is still pretty much up-to-date. Most of them are non-essential. IMO the architecture works.
* There is only support for videos because I first wanted to get that right before tackling music (and I don't use music that much in Kodi).
* IMO the only way this will ever really have an impact is if media imports can be written as python plugins. Writing them in C++ as part of Kodi may offer more immediate options for the developer but the barrier is also much higher. That's what I've been working on last with the Emby demo add-on. The main problem right now is that the add-on settings system is too static. You can't populate a setting option with a dynamic list of choices. This was very easy in my initial C++ implementation but it's currently not possible in the add-on implementation.
* The main reason I never created a PR for the whole feature was that I only barely had time to work on the feature itself and would have been overwhelmed if I had to fix all bugs the feature introduced. And I also didn't want to put that burden on the other developers which don't even know the implementation of the feature yet.
Unfortunately due to family matters (own house, small daughter) I don't have any time for coding in my (non-existing) free time anymore. I would probably be able to support someone in understanding the architecture etc. but right now there is no real documentation
2019-09-17, 01:15
2019-10-17, 08:52
I managed to find some time to
I also noticed a problem that arises when opening the settings of an add-on based media provider / import while the add-on is importing items in the background.
Here's are the available test builds if anyone is daring enough to give them a try:
- rebase the media_import branch to almost current master (Python 2 --> 3 migration excluded)* extend the mediaimporter.emby python add-on to support
- proper user authentication
- dynamic setting callbacks
- proper user authentication
- fix some bugs in the media import add-on API
I also noticed a problem that arises when opening the settings of an add-on based media provider / import while the add-on is importing items in the background.
Here's are the available test builds if anyone is daring enough to give them a try:
2019-10-18, 03:02
Hi,
https://github.com/Montellese/xbmc/tree/...orter.emby
Is this the current version of the emby plugin? Isn't there suppose to be a settings.xml file in the plugin directory. The configure button is ghosted for the plugin.
Cheers,
LongMan
https://github.com/Montellese/xbmc/tree/...orter.emby
Is this the current version of the emby plugin? Isn't there suppose to be a settings.xml file in the plugin directory. The configure button is ghosted for the plugin.
Cheers,
LongMan
2019-10-18, 03:29
I was able to enter my credentials, and the server showed that the user has been authenticated.
I was able to browse and add content type, but not individual libraries.
At startup a message appears, "Retrieving media items from server...." however, no item are retrieved.
If synchronize is chosen from the context menu of the media import, "Web-PDB debugger is active 100%.." is shown.
IIRC, the previuos windows builds had a pdb files with them.
Cheers
I was able to browse and add content type, but not individual libraries.
At startup a message appears, "Retrieving media items from server...." however, no item are retrieved.
If synchronize is chosen from the context menu of the media import, "Web-PDB debugger is active 100%.." is shown.
IIRC, the previuos windows builds had a pdb files with them.
Cheers
2019-10-18, 07:51
(2019-10-18, 03:02)LongMan Wrote: Hi,There are currently no add-on wide settings. All settings are media provider and media import specific. So the add-on first has to detect a running Emby server which is then added as a media provider. You can then configure that media provider with your credentials. For that media provider you can then choose which media types to import which results in media imports. Each media import again has some custom settings like choosing which library view to use (or just use all of them) during the import.
https://github.com/Montellese/xbmc/tree/...orter.emby
Is this the current version of the emby plugin? Isn't there suppose to be a settings.xml file in the plugin directory. The configure button is ghosted for the plugin.
Cheers,
LongMan
2019-10-18, 08:00
(2019-10-18, 03:29)LongMan Wrote: I was able to enter my credentials, and the server showed that the user has been authenticated.Ah looks like you got one step further.
I was able to browse and add content type, but not individual libraries.
At startup a message appears, "Retrieving media items from server...." however, no item are retrieved.
If synchronize is chosen from the context menu of the media import, "Web-PDB debugger is active 100%.." is shown.
IIRC, the previuos windows builds had a pdb files with them.
Cheers
- Your Emby server was detected as a media provider.
- You were able to configure it with your credentials.
- You were able to configure a media import.
- On the settings of the media import you should be able to choose all or specific library views to import. Is that what you mean with "individual libraries"?
- On the settings of the media import you should be able to choose all or specific library views to import. Is that what you mean with "individual libraries"?
Please let me know if that fixes the synchronisation for you. Otherwise please provide the Kodi log file.
Thanks for the feedback.
2019-10-18, 11:22
Yes views are referred as libraries in the user interface.
On the import dialog, it has All, Choose for each content type. However, it does not allow browsing when "Choose" is selected
https://drive.google.com/file/d/1nhamulN...sp=sharing
It didn't solve the syncing. The pdb error went away.
Thanks for continuing to work on this.
Cheers
On the import dialog, it has All, Choose for each content type. However, it does not allow browsing when "Choose" is selected
https://drive.google.com/file/d/1nhamulN...sp=sharing
It didn't solve the syncing. The pdb error went away.
Thanks for continuing to work on this.
Cheers
2019-10-18, 14:42
Thanks for the log. It looks like it can't retrieve the list of library views from your Emby server. It tries the following URL: http://<IP>:<Port>/Views. But it gets a HTTP 404 (Not Found). Maybe something works differently on my Emby server installation than on yours? TBH I have no idea how to use Emby. I simply installed it, configured a user and added a Movies and TV shows library. The rest is more or less reverse engineering in combination with the information from the Emby wiki on Github.
But reading the docs it looks like it should be http://<IP>:<Port>/Users/<User ID>/Views. I'll have to check when I'm home how / why it works there.
But reading the docs it looks like it should be http://<IP>:<Port>/Users/<User ID>/Views. I'll have to check when I'm home how / why it works there.
2019-10-18, 16:13
I just checked the code again and the fact that your URL is http://<IP>:<Port>/Views and not http://<IP>:<Port>/Users/<User ID>/Views indicates that your user authentication did not work / succeed. Did you enter your username and password manually or did you choose a username from the list and just enter the password.
I'm assuming that something is not working in general as to how to access your Emby server over the API. Therefore I've added debug log messages to every HTTP API call in the add-on. Please try again with https://www.dropbox.com/s/qr58iadjfeer1v...y.zip?dl=1.
I'm assuming that something is not working in general as to how to access your Emby server over the API. Therefore I've added debug log messages to every HTTP API call in the add-on. Please try again with https://www.dropbox.com/s/qr58iadjfeer1v...y.zip?dl=1.
2019-10-18, 16:42
Montellese, I assume that you are also using Emby server, 4.2.1.0.
BTW that user does not have a password.
BTW that user does not have a password.
2019-10-18, 19:09
@Montellese
If you are interested and need any assistance in how Emby or the existing Emby-for-Kodi add-on works I can invite you to our internal Discord group with @angelblue05. She dealt with the API the last years and know all good and bad sides of it. I would love to see this feature be completed on some day. And I also think that Luke (of Emby) is interested in get this thing working. Just send me a PM in that case.
Edit:
Tested it with the latest Emby beta server (4.3.0.15) and it "worked". Tried a movie lib import, but it imported everything as movie. Music, TV shows, episodes, etc. No metadata at all except name + artwork.
FYI https://paste.kodi.tv
If you are interested and need any assistance in how Emby or the existing Emby-for-Kodi add-on works I can invite you to our internal Discord group with @angelblue05. She dealt with the API the last years and know all good and bad sides of it. I would love to see this feature be completed on some day. And I also think that Luke (of Emby) is interested in get this thing working. Just send me a PM in that case.
Edit:
Tested it with the latest Emby beta server (4.3.0.15) and it "worked". Tried a movie lib import, but it imported everything as movie. Music, TV shows, episodes, etc. No metadata at all except name + artwork.
FYI https://paste.kodi.tv
2019-10-18, 22:24
(2019-10-18, 16:42)LongMan Wrote: Montellese, I assume that you are also using Emby server, 4.2.1.0.
BTW that user does not have a password.
Yes I'm on the latest version but I have Emby server running on the same machine as Kodi so my HTTP API address starts with: http://localhost:8096/. But in the version I posted above I added "/emby/" to the base URL. Maybe that solve the problem for you. At least Emby's Swagger uses URLs with paths starting with "/emby/".
