[bsoriano]

Ok, that's everything I can do from my side. My approach needs a matching ID (tvdb, tmdb, imdb) or a matching local<->trakt show title + release year.

@sualfred, I continued testing with my main HTPC, running Kodi 18.5.  All episodes were shown for each day, so the functionality is working as expected

Regards,

Bart

[sualfred]

@bsoriano 

Finished everything. Could you do me a favour and test the github master branch before I create a PR?

[bsoriano]

@bsoriano 

Finished everything. Could you do me a favour and test the github master branch before I create a PR?

@sualfred, just tested and everything seems to be OK.  Would you consider some small requests which would allow me to better use the next aired function as a tv guide and widget:

1. Provide the day of the week the episode is airing as a listitem property
2. Provide the time (9pm, etc.) that the episode is airing as a listitem property
3. Provide the network (studio, can be just the first one if there are more than one) as a listitem property
4. Provide 14 days worth of episodes instead of just 7

Thank you for considering my requests.

EDIT: @sualfred , Finally, I think it would be better to show the date as well as the weekday when browsing the next aired function in the addon itself.  The reason I say that is because, for example, if you browse it today, you get "Next 7 days", "Monday", "Tuesday" and so on until Sunday.  However, if you select Monday, it provides the episodes for next monday, March 9th, instead of this past monday, March 2nd.  Tuesday does provide the episodes for yesterday, and Wednesday provides today's, and so on.  I do not know if this is by design (you are only going back one day from today), or if it is an error.

Regards,

Bart

[sualfred]

1. + 2. Already there. ListItem.Property(AirDay) + ListItem.Property(AirTime)
3. Done -> ListItem.Studio. Also added ListItem.Country + ListItem.Status + ListItem.Duration
4. No, because of performance reasons.

Plus "Next 7 days" are sorted now.

[bsoriano]

1. + 2. Already there. ListItem.Property(AirDay) + ListItem.Property(AirTime)
3. Done -> ListItem.Studio. Also added ListItem.Country + ListItem.Status + ListItem.Duration
4. No, because of performance reasons.

Plus "Next 7 days" are sorted now.

@sualfred, excellent! Thank you very much.

I just tested again (and deleted simplecache.db to ensure best results), and the Next 7 days issue does not seem to be sorted.  Monday still shows me the episodes for next monday, March 9th.

EDIT 2: @sualfred , I am sorry I had not seen the updated readme.  So, are the days in the plugin paths fixed? For a TV Guide custom window this would work for me, but for a widget, I would love to have a way of knowing the next airing episodes for today.  Would you be willing to add something like that? Or put another way, would you consider having the seven days with today as a start instead of having fixed days of the week?

Please let me know.  Thanks.

EDIT: @sualfred , Would you also consider adding the season poster as part of the artwork returned? That way, in the widget, I can show the poster for the correct season of the episode, if available, and not the tv show poster.

Regards,

Bart

Regards,

Bart

[sualfred]

Because today is Wednesday. The next monday is the 9th? Sorry, don't get you. Today is Wednesday so it will show it in this order: Wednesday, Thursday, Friday, Saturday, Sunday, Monday, Tuesday.

I can add own node for "Today". The paths are fixed. "week" for the next 7 days and 0-6 for Mo-So.

The artworks are the local ones. I only get the thumb of TVDb. Another call of additional artworks per item will increase the loading time a lot.

[bsoriano]

Because today is Wednesday. The next monday is the 9th? Sorry, don't get you. Today is Wednesday so it will show it in this order: Wednesday, Thursday, Friday, Saturday, Sunday, Monday, Tuesday.

I can add own node for "Today". The paths are fixed. "week" for the next 7 days and 0-6 for Mo-So.

The artworks are the local ones. I only get the thumb of TVDb. Another call of additional artworks per item will increase the loading time a lot.

@sualfred, I understand. However, when I browse the addon, the order that appears is "Next Week", "Monday", and so on. It does not start on Wednesday. I did not change the sort order.

Thanks for adding a Today node. I understand about the artwork. So if I have it locally, listitem.art(season.poster) will show the season poster?

Regards,

Bart

[sualfred]

The main node is not ordered, but possible. Will do it tomorrow.

"Today" has been added.

I'm not quite sure anymore if "season.poster" is assigned to the TV show table or to the season one. Just check if its set. Anyway, calling for local season details is very expensive. And if you don't have this season in the DB it's wasted time too. So this gets another nope from me, sorry.

[bsoriano]

The main node is not ordered, but possible. Will do it tomorrow.

"Today" has been added.

I'm not quite sure anymore if "season.poster" is assigned to the TV show table or to the season one. Just check if its set. Anyway, calling for local season details is very expensive. And if you don't have this season in the DB it's wasted time too. So this gets another nope from me, sorry.

@sualfred , understood.  I tested the Today node and it works great.  The season poster is not set, so I will show the TV Show poster.

My only remaining wish is if you could order the nodes so that nextaired/0 is today, nextaired/1 is tomorrow, and so on.  That way they can be used in a list without the skinner worrying about what day corresponds to which, and sequentially.  If that is not something you will be implementing, then I guess I have to live with the possibility of one or more days being out of date order in my custom tv guide window.  Or do you know how I could show them in date order in a list? Thanks for your help.

Also, if you could make optional having the date and time and [CR] being part of ListItem.Plot that would be great.  Thanks.

Regards,

Bart

[sualfred]

It's ordered differently now.

But 0 is always Monday. It's the day index of the week. The data is also only fetched once and assigned to this index.

Work with a hidden container that points to "plugin://script.embuary.info/nextaired" and then just use "Container(id).ListItemAbsolute(1).Folderpath", "Container(id).ListItemAbsolute(2).Folderpath", "Container(id).ListItemAbsolute(3).Folderpath"

[bsoriano]

It's ordered differently now.

But 0 is always Monday. It's the day index of the week. The data is also only fetched once and assigned to this index.

Work with a hidden container that points to "plugin://script.embuary.info/nextaired" and then just use "Container(id).ListItemAbsolute(1).Folderpath", "Container(id).ListItemAbsolute(2).Folderpath", "Container(id).ListItemAbsolute(3).Folderpath"

@sualfred , thanks! Now when browsing the addon it is ordered by date The only issue is that the day of the week is shown twice, like "Thursday, Thursday, 05 March 2020".

Thanks for the tip with the hidden container.  I will try that right away.

EDIT: @sualfred, the hidden container worked almost perfectly.  As I understood it, using that and the folderpaths would mimic the order that you show when browsing the addon.  It does, except that for the last item "Container(id).ListItemAbsolute(7).FolderPath", it shows Tuesday, 3 March, instead of Tuesday, 10 March like it is shown when browsing the addon.  I just saw that even though the addon says 10 March, it is actually showing the episodes for Tuesday 3 March.  Is this something you can change?


Regards,

Bart

[sualfred]

I don't see any weekday duplicates.

Hmm.. try it again. Maybe another utc/local time issue. I switched to the local date for the trakt call.

Edit:
Ok, the weekday duplicates are caused by the regional settings of Kodi. Will fix it.

[User 405025]

Hi @sualfred 

EDIT:
may not be neccesary anymore , found my fault.
I overread and therefore ignored the shipped list(id=1)  tags in script-embuary-image.xml
         

xml:
   <scrolltime>0</scrolltime>

            <itemlayout/>

Sorry for confuse someone...
Origional Post:

Hi got a big request regarding the handling for Image SlideShow

I like to have it up to the skinner, to how the slide supports.
- image size, scrollbar ,background handling, use different slide animations

If i am right the script should be able to can get rid of the slideshow workaraound and the script-embuary-image.xml.
So its maybe going to be 'smaller' that way.

I'am pretty unfamiliar with python.
So i just replace for testing purpose ,because i couldnt use an override action defined via skin xml
and wasnt able to get rid of that of a predefined <onclick> action in another way

python:
elif next_call == 'image':

            FullScreenImage(controlId)

with

python:
elif next_call == 'image':

      #untested and just if strictly needed to force onlick actions via script

      # but best will be an an onclick action choosen by the skin not by script xbmc.executebuiltin('SetProperty(ThumbId,$INFO[System.CurrentControlId],home)')

      xbmc.executebuiltin('Control.SetFocus(9992)')

          

,but i think the pre defined onfocus action by the script should be completely removed, as it will be easier to focus and define button (include)  for fanart and/ or poster inside the main xmls
(script-embuary-person.xml , script-embuary-video.xml)

I can sure make an pr for the skin file of the script.
but for python files ....well i shouldnt really touch them .... .

 - $INFO[Window(home).Property(ThumbId)],if an onclick action is needed script side ? ,  to devide between fanart(10055) and poster (10059) thumbs ids
 - but i would prefer using an includefor 2 buttons  using id params via  skin instead using propertys

xml:
<!-- slideshow imitate image fanart ctrl 10055,  -->

        <control type="group">

            <visible>Control.HasFocus(9992)</visible>

            <animation effect="fade" start="0" end="100" time="350" tween="cubic" easing="inout">Visible</animation>

            <animation effect="fade" start="0" end="100" time="350" tween="cubic" easing="inout">WindowOpen</animation>

            <animation effect="fade" end="0" start="100" time="150">Hidden</animation>

            <animation effect="fade" end="0" start="100" time="150">WindowClose</animation>

            <control type="button" id="9992">

                <visible allowhiddenfocus="true">false</visible>

                <width>1</width>

                <height>1</height>

                <texturefocus />

                <texturenofocus />

                <onleft>Control.Move($INFO[Window(home).Property(ThumbId)],-1)</onleft>

                <onright>Control.Move($INFO[Window(home).Property(ThumbId)],1)</onright>

                <onup>Control.Move($INFO[Window(home).Property(ThumbId)],1)</onup>

                <ondown>Control.Move($INFO[Window(home).Property(ThumbId)],-1)</ondown>

                <onback>SetFocus($INFO[Window(home).Property(ThumbId)])</onback> <!-- currently also closes window -->

                <oninfo>$INFO[Window(home).Property(ThumbId)]</oninfo>

                <onclick>SetFocus($INFO[Window(home).Property(ThumbId)])</onclick>

            </control>

            <control type="image">

                <texture colordiffuse="22000000">colors/white.png</texture>

            </control>

            <control type="group">

                <animation effect="slide" start="0" end="-1920" condition="!Container($INFO[Window(home).Property(ThumbId)]).OnNext" reversible="false" time="350" tween="quadratic">Conditional</animation>

                <animation effect="slide" start="0" end="1920" condition="!Container($INFO[Window(home).Property(ThumbId)]).OnPrevious" reversible="false" time="350" tween="quadratic">Conditional</animation>

                <control type="image">

                    <centerleft>50%</centerleft>

                    <centertop>50%</centertop>

                    <width>1920</width>

                    <height>1080</height>

                    <left>-1920</left>

                    <aspectratio>keep</aspectratio>

                    <texture background="true">$INFO[Container($INFO[Window(home).Property(ThumbId)]).ListItem(-1).Art(thumb)]</texture>

                </control>

                <control type="image">

                    <centerleft>50%</centerleft>

                    <centertop>50%</centertop>

                    <width>1920</width>

                    <height>1080</height>

                    <aspectratio>keep</aspectratio>

                    <texture background="true">$INFO[Container($INFO[Window(home).Property(ThumbId)]).ListItem.Art(thumb)]</texture>

                </control>

                <control type="image">

                    <centerleft>50%</centerleft>

                    <centertop>50%</centertop>

                    <width>1920</width>

                    <height>1080</height>

                    <left>1920</left>

                    <aspectratio>keep</aspectratio>

                    <texture background="true">$INFO[Container($INFO[Window(home).Property(ThumbId)]).ListItem(1).Art(thumb)]</texture>

                </control>

            </control>

        </control>

What i mean --

Video Example

[bsoriano]

I don't see any weekday duplicates.

Hmm.. try it again. Maybe another utc/local time issue. I switched to the local date for the trakt call.

Edit:
Ok, the weekday duplicates are caused by the regional settings of Kodi. Will fix it.

@sualfred, confirmed that the weekday duplicates are fixed.  Thanks!

The issue that I mentioned before with the last day shown in the addon remains.  Even though it says Wednesday, March 11 2020, it actually has the episodes for this past wednesday, March 4th.  Please let me know if you need me to send any additional info.  Thanks.

Regards,

Bart

[sualfred]

@mardukL  
I can't follow you.