Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
  • 1
  • 79
  • 80
  • 81(current)
  • 82
  • 83
  • 92
Release Kodi Matrix 19.0 HDR Windows API (merged)
Kodi does not talk with driver, only with Win32 API: 

Kodi => Win32 API => video driver => HW 

The default behaviour is the same for Intel and NVIDIA: 

for HDR < 30Hz ---> RGB 4:4:4 12 bit (10 bits padded)

for HDR 60Hz --->  RGB 4:4:4 8 bit  (with dithering)

RGB 10-12 bit at 60Hz cannot be used due HDMI 2.0a-b bandwidth limitations.

YCbCr never is used as default unless is forced in driver control panel (as is considered 8 bit RGB dithering still superior that 10 bit YCbCr 4:2:0).
Reply
(2020-11-14, 11:42)jogal Wrote: Kodi does not talk with driver, only with Win32 API: 

Kodi => Win32 API => video driver => HW 

The default behaviour is the same for Intel and NVIDIA: 

for HDR < 30Hz ---> RGB 4:4:4 12 bit (10 bits padded)

for HDR 60Hz --->  RGB 4:4:4 8 bit  (with dithering)

RGB 10-12 bit at 60Hz cannot be used due HDMI 2.0a-b bandwidth limitations.

YCbCr never is used as default unless is forced in driver control panel (as is considered 8 bit RGB dithering still superior that 10 bit YCbCr 4:2:0).

first of all thank you for your continued work on this project Smile

i'm using ryzen apu 4650g, gpu driver 20.11.1, win10 20h2 connected via hdmi to lg cx oled (the tv has a convenient option to show current res, refresh rate and pixel format).
works almost perfect, sometimes colors are oversaturated for hdr10 source (source has maxcll and maxfall).
usually exiting kodi and toggling desktop hdr on and off and then trying again corrects the issue (probably driver fault).

to me it looks like kodi does not attempt to specify pixel format and that's ok too.
on my side it looks like windows/driver remembers the last format for a given res/refresh rate combination.
the default behavior after clean driver installation is to follow desktop pixel format for all resolutions (if it can),
but if i change desktop res to 4k23 12bpc rgb and then change desktop back to 4k60 8bpc rgb
the next time kodi will try to use 4k23 it will also switch to the last pixel format used for that res/refresh rate combination, in this case 12bpc rgb for 4k23.
therefore i think kodi does not even attempt to control this behavior (and this probably is a good thing).
i'm just wondering if this is different for nvidia/intel or if this is a general win10 behavior.

btw i think you said some time ago your nuc supports 4k60 10bit rgb afair? that would exceed hdmi 2.0 spec. how does that work then?
Reply
(2020-11-15, 21:13)ciukacz Wrote: btw i think you said some time ago your nuc supports 4k60 10bit rgb afair? that would exceed hdmi 2.0 spec. how does that work then?

NUC is HDMI 2.0a and works as I described previously:

for HDR <= 30Hz ----> RGB 4:4:4 12 bit

for HDR 60Hz ---->  RGB 4:4:4 8 bit
 
Quote:but if i change desktop res to 4k23 12bpc rgb and then change desktop back to 4k60 8bpc rgb
the next time kodi will try to use 4k23 it will also switch to the last pixel format used for that res/refresh rate combination, in this case 12bpc rgb for 4k23.
therefore i think kodi does not even attempt to control this behavior (and this probably is a good thing).
i'm just wondering if this is different for nvidia/intel or if this is a general win10 behavior.

As say first post Windows desktop should stay all the time at 4K 60Hz 8bit RGB   and when Kodi plays HDR content video driver auto switch to 12 bits if is 24Hz or 23.976 Hz or 8 bits if is HDR 60 Hz (e.g. Gemini Man)

It only switches to 12 bits when the transfer is HDR PQ, that is, the color format can be BT.2020 for example on Windows desktop but the PQ transfer is not active (gamma 2.2) then stays at 8 bit even if you sets refresh rate at 30Hz
Reply
(2020-11-16, 21:07)jogal Wrote: As say first post Windows desktop should stay all the time at 4K 60Hz 8bit RGB   and when Kodi plays HDR content video driver auto switch to 12 bits if is 24Hz or 23.976 Hz or 8 bits if is HDR 60 Hz (e.g. Gemini Man)

It only switches to 12 bits when the transfer is HDR PQ, that is, the color format can be BT.2020 for example on Windows desktop but the PQ transfer is not active (gamma 2.2) then stays at 8 bit even if you sets refresh rate at 30Hz

i run my desktop at 4k60 8bpc rgb, but without that workaround i described earlier kodi was staying during 23hz hdr playback in 8bpc rgb on my amd apu.
after the workaround it properly switches to 12bpc rgb for the same file.
it looks like kodi assumes that the default behavior that is occurring on intel/nvidia will also happen on amd cards/apus but this is not the case by default (after a clean driver install). i verified this because my tv can show the pixel format being used currently.

this is either a bug in amd driver or kodi does not set the exact pixel format.
could you tell me where this resolution/refresh rate/bitdepth switch is located in source code so that i can compile it and test on my hardware?
Reply
I'm sorry but I can't help you the way you want. If you think kodi has a bug, open an issue on github providing all possible information: debug logs, etc.

Kodi should work well for everyone with different settings and systems. If there is a problem that only you have (apparently) the way to fix it is not by making specific changes for you in the code. The most important thing is not to fix this issue only for you but to know first the reason because only you have this issue.
Reply
(2020-11-15, 21:13)ciukacz Wrote: win10 20h2 connected via hdmi to lg cx oled

I understand that you have an LG TV connected directly to the PC. So I suppose you are aware of this:
 
Quote:For HDR to work from external devices, the Ultra HD Deep Color option usually has to be enabled from the 'Additional Settings' menu for the input you are using. Older devices may have compatibility issues if this option is left enabled, so it is recommended to only enable this setting for devices that require it.
Image
Reply
(2020-11-17, 21:40)jogal Wrote: I understand that you have an LG TV connected directly to the PC. So I suppose you are aware of this:

yes, of course i use that. i also use recommended settings from the 1st page except for the delay setting after refresh rate change.
on my amd apu using 2s very often causes oversaturated colors, 0s setting works correct almost always for me.

what i am trying to say is that after a clean driver installation hdr is played in 8bpc hdr mode.
this is *not* tone mapping, i get very bright highlights. i know how hdr should look like and this is correct.

Image

and it works in proper 12bpc mode only when i change the bitdepth setting for 4k23 using windows/radeon settings.
after i change bitdepth setting for 4k23 it will be remembered as default bitdepth for 4k23 mode.
after that i switch desktop back to 4k60 8bpc rgb and launch kodi:

Image
Image

this is why i think kodi does not set bitdepth explicitly, it just assumes the driver will do it.
and probably this works a little differently on intel/nvidia.

i am satisfied with my workaround (i have to do it just once after clean driver install)
but i have been wondering if there is point in trying to control this behavior.
if kodi should try to set for example 4k23 and also set 12bpc rgb explicitly.
Reply
This is already done in:

https://github.com/xbmc/xbmc/blob/master...s.cpp#L607

DXGI_FORMAT_R10G10B10A2_UNORM  ---> 10 bit swapchain surfaces

and: 

https://github.com/xbmc/xbmc/blob/master...e.cpp#L550

DXGI_COLOR_SPACE_RGB_FULL_G2084_NONE_P2020 ---> RGB 10/12 bit BT.2020 transfer G2084 (PQ)


If not works for you is probably a Ryzen driver bug or HDMI handshake issue.
Reply
(2020-11-17, 23:32)jogal Wrote: This is already done in: (...)
If not works for you is probably a Ryzen driver bug or HDMI handshake issue.

thank you for the links, now it is clear to me that most likely the driver is messing with the output bitdepth.
but at least i've found a workaround so hopefully someone using amd benefits from this.
Reply
@jogal does the 2 seconds reccomendation still stand on the adjust display refesh rate delay? Mine is currently set to 1.5 i watch HDR content 24/60hz also 1080p. I know your reccomendation is to set at 2 seconds.! Silly question i should just up that half second to 2. lol
Reply
I can't get this to work. Can anyone assist?

I've an LG B8 OLED. HDMI Deep Colour is enabled on the HDMI input.

The graphics card is a Nvidia GT 1030. All settings as per first post.

When I play an HDR film, TV flickers and the HDR banner pops up. However when the film is playing, the TV is in SDR mode. When I stop playing, again, the TV flickers and the HDR banner pops up in the corner, it then goes back to SDR mode by time I'm back on the menu.

Not sure why it won't stay in HDR for the film playing?
Reply
(2020-11-18, 23:50)Breed43214 Wrote: I can't get this to work. Can anyone assist?

I've an LG B8 OLED. HDMI Deep Colour is enabled on the HDMI input.

The graphics card is a Nvidia GT 1030. All settings as per first post.

When I play an HDR film, TV flickers and the HDR banner pops up. However when the film is playing, the TV is in SDR mode. When I stop playing, again, the TV flickers and the HDR banner pops up in the corner, it then goes back to SDR mode by time I'm back on the menu.

Not sure why it won't stay in HDR for the film playing?

I forgot to add (can't edit post, sorry) that the same things happens for SDR films. I get the HDR banner and flicker when I play a film and stop it, but TV stays in SDR mode. Somethings not quite right.
Reply
because this feature is now merged in kodi 19 i have discovered an issue in which playback of any video type crashes on the new ryzen 5000 cpus mine in particular is the 5950x and on playing any video it will start and play for a bit or else will crash on selecting to play i thought this might have just been an issue on my side but when i installed kodi 18.9 this issue does not happen so im wondering is it an issue with the new hdr implementation in kodi 19 i had an intel setup before i upgraded and it played kodi 19 without any issues but the ryzen 5950x cant play anything in kodi 19 Sad
Reply
(2020-11-19, 02:48)daryld1988 Wrote: because this feature is now merged in kodi 19 i have discovered an issue in which playback of any video type crashes on the new ryzen 5000 cpus mine in particular is the 5950x and on playing any video it will start and play for a bit or else will crash on selecting to play i thought this might have just been an issue on my side but when i installed kodi 18.9 this issue does not happen so im wondering is it an issue with the new hdr implementation in kodi 19 i had an intel setup before i upgraded and it played kodi 19 without any issues but the ryzen 5950x cant play anything in kodi 19 Sad
Debug log might help but keep in mind getting a sample of users with ryzen 5000s right now is probably going to be difficult.  So not easy to verify the problem.

scott s.
.
Reply
(2020-11-19, 02:48)daryld1988 Wrote: because this feature is now merged in kodi 19 i have discovered an issue in which playback of any video type crashes on the new ryzen 5000 cpus....

And only can crashes because "this" feature and not other oneHuhHuhHuh?

By the way, other users have reported similar problems on Kodi v18.9 and not has "this" feature:

https://forum.kodi.tv/showthread.php?tid=358386

Anyway I agree that debug log can be useful.
Reply
  • 1
  • 79
  • 80
  • 81(current)
  • 82
  • 83
  • 92

Logout Mark Read Team Forum Stats Members Help
Kodi Matrix 19.0 HDR Windows API (merged)2