[beatmasterrs]

1 - request :

When I click on item widget I open video info dialog by default.
If I use keymap x to close trailer before click all is good.
My request is it possible to close the trailer when video info dialog is open ? 


2 - bug :

1 - on home if I focus item 4 on widget then the trailer start.

2 - if I return to the main menu the trailer stop

3 - then the trailer of item 1 auto start

4 - if close the trailer it start again and again and again

EDIT :
Otherway all is very good. If audio is playing the trailer is not starting.
Thanks for your hard work

Please try the latest version, i had forgotten to clear the property when the main menu gets focus. Hopefully this works now:

zip: https://github.com/beatmasterRS/skin.arc...iler-1.zip

commit: https://github.com/beatmasterRS/skin.arc...433acd0d67

Yes I confirm you with this update the bug is gone

As always, thank you for your feedback  

I'm currently still looking for a solution for a bit more consistency when switching to fullscreen mode. I would like to be able to switch to fullscreen mode, then switch back without

- the trailer will stop
- the trailer will play again

I haven't found a solution yet, as the behavior in home is different from MyVideoNav. 

I would just like it to be perfect

I could however, 

- disable playing in fullscreen mode in general, means stop playing when switching to fullscreen mode
- leave everything as it is and accept that there are different behaviors, as fullscreen mode should not be part of the function

What do you think?

[Nanomani]

Please try the latest version, i had forgotten to clear the property when the main menu gets focus. Hopefully this works now:

zip: https://github.com/beatmasterRS/skin.arc...iler-1.zip

commit: https://github.com/beatmasterRS/skin.arc...433acd0d67

Yes I confirm you with this update the bug is gone

As always, thank you for your feedback  

I'm currently still looking for a solution for a bit more consistency when switching to fullscreen mode. I would like to be able to switch to fullscreen mode, then switch back without

- the trailer will stop
- the trailer will play again

I haven't found a solution yet, as the behavior in home is different from MyVideoNav. 

I would just like it to be perfect

I could however, 

- disable playing in fullscreen mode in general, means stop playing when switching to fullscreen mode
- leave everything as it is and accept that there are different behaviors, as fullscreen mode should not be part of the function

What do you think?

Something better must be possible.

With this version  LINK switching to fullscreen mode works very well : 
- swithing don't stop the trailer in myvideonav
- works in same way in home and in MyVideoNav

I understand that this version of the beginning does not include others improvement.
But perhaps see if it possible to make a mix from this version with other improvement.

EDIT 1 :

A simple answer is not so easy.

Le more simple for absolute consistency :
- disable fullscreen
- swithing have not action at all

[beatmasterrs]

Yes I confirm you with this update the bug is gone

As always, thank you for your feedback  

I'm currently still looking for a solution for a bit more consistency when switching to fullscreen mode. I would like to be able to switch to fullscreen mode, then switch back without

- the trailer will stop
- the trailer will play again

I haven't found a solution yet, as the behavior in home is different from MyVideoNav. 

I would just like it to be perfect

I could however, 

- disable playing in fullscreen mode in general, means stop playing when switching to fullscreen mode
- leave everything as it is and accept that there are different behaviors, as fullscreen mode should not be part of the function

What do you think?

Something better must be possible.

With this version  LINK switching to fullscreen mode works very well : 
- swithing don't stop the trailer in myvideonav
- works in same way in home and in MyVideoNav

I understand that this version of the beginning does not include others improvement.
But perhaps see if it possible to make a mix from this version with other improvement.

It would be nice if it were that simple

The first version used a different method where it took too much code to make everything work. The code has cost a lot of performance. The new code is much better and simpler to handle.

I might also be able to stop it from switching to full screen mode when playing a trailer.

[Nanomani]

It would be nice if it were that simple
The first version used a different method where it took too much code to make everything work. The code has cost a lot of performance. The new code is much better and simpler to handle.

I understand. I expected this answer

I might also be able to stop it from switching to full screen mode when playing a trailer.

Hum...
I will keep full screen mode in Home.
I will disable the stop function with the switching in myvideonav if possible. (Switching must stay to his function)
I will add automatique stop when open video info dialog 

EDIT : In a perfect world i will ask santa claus to add in settings "manual", 3s, 5s, 7s, 9s and a context menu "show Trailer" 

[beatmasterrs]

@Nanomani and all others, i have improved the "switch to fullscreen" behaviour:

In the video you can see, that i can

- switch to fullscreen, while trailer is playing and switch back to home
- trailer doesnt stop, untill hit "stop" or move to the next item
- no trailer loop



https://github.com/beatmasterRS/skin.arc...-trailer-3

https://github.com/beatmasterRS/skin.arc...iler-3.zip

[Nanomani]

@Nanomani and all others, i have improved the "switch to fullscreen" behaviour:

In the video you can see, that i can

- switch to fullscreen, while trailer is playing and switch back to home
- trailer doesnt stop, untill hit "stop" or move to the next item
- no trailer loop

https://github.com/beatmasterRS/skin.arc...-trailer-3

https://github.com/beatmasterRS/skin.arc...iler-3.zip

I confirm you all works like expected.
Nothing to add. This version is perfect.
Thanks you for your hard work.

Waiting others feedback can help.
For me you can merge this

[Grumpyman]

perfect here as well

great job

[beatmasterrs]

@Nanomani and all others, i have improved the "switch to fullscreen" behaviour:

In the video you can see, that i can

- switch to fullscreen, while trailer is playing and switch back to home
- trailer doesnt stop, untill hit "stop" or move to the next item
- no trailer loop

https://github.com/beatmasterRS/skin.arc...-trailer-3

https://github.com/beatmasterRS/skin.arc...iler-3.zip

I confirm you all works like expected.
Nothing to add. This version is perfect.
Thanks you for your hard work.

Waiting others feedback can help.
For me you can merge this

 

perfect here as well

great job

Thanks for your feedback I'm so happy, that it works now

[Nanomani]

@Nanomani and all others, i have improved the "switch to fullscreen" behaviour:

In the video you can see, that i can

- switch to fullscreen, while trailer is playing and switch back to home
- trailer doesnt stop, untill hit "stop" or move to the next item
- no trailer loop

https://github.com/beatmasterRS/skin.arc...-trailer-3

https://github.com/beatmasterRS/skin.arc...iler-3.zip

I confirm you all works like expected.
Nothing to add. This version is perfect.
Thanks you for your hard work.

Waiting others feedback can help.
For me you can merge this

 

perfect here as well

great job

Thanks for your feedback I'm so happy, that it works now

Dumb question.
(please consider that I have no idea of ​​the impact of my question with the code) 

If we use option "Use IMDB trailers" this don't works with fix layout or home only with video info dialog ? Right ?
please no misunderstanding here. I m very very happy with your last version
Thanks again for your effort and your great skin

[beatmasterrs]

I confirm you all works like expected.
Nothing to add. This version is perfect.
Thanks you for your hard work.

Waiting others feedback can help.
For me you can merge this

 

perfect here as well

great job

Thanks for your feedback I'm so happy, that it works now

Dumb question.
(please consider that I have no idea of ​​the impact of my question with the code) 

If we use option "Use IMDB trailers" this don't works with fix layout or home only with video info dialog ? Right ?
please no misunderstanding here. I m very very happy with your last version
Thanks again for your effort and your great skin

Yes, you are right. I think it would be to diffcult to implement, scince there is no property generated by the imdb trailers addon, that a trailer i available or not. But maybe i will add a fallback to use tmdbhelpers trailer function, if listitem.trailer is empty. But i am not sure, if this will be possible. We will see

[Buzzie]

Sounds and looks great !!! hope to test it soon.

What is needed to get it to work?
what settings and views does it work on?
Will this be added to the master soon or do i have to download and install the zip?
How dows auto update work then of the skin ?

[beatmasterrs]

Sounds and looks great !!! hope to test it soon.

What is needed to get it to work?
what settings and views does it work on?
Will this be added to the master soon or do i have to download and install the zip?
How dows auto update work then of the skin ?

Currently you can test it only, if you download the Zip file from here: https://github.com/beatmasterRS/skin.arc...iler-3.zip and install/update the skin manually. If all tests are complete and there are no issues, the PR https://github.com/beatmasterRS/skin.arc...d/pull/483 will be merged into master. Usually every 2-3 weeks a new version will be released. You can get the new update from the kodi-repo or my personal repo. If you install/update the skin manually from Zip file, there is no option to have the skin updated automatically. The skin must first be installed via a repo in order to get automatic updates.

[obbz]

I installed the repo, but it cant connect?

[beatmasterrs]

I installed the repo, but it cant connect?

From which source did you install the repo? You can install the skin from the kodi repo

[Tired Dad]

That seems to be working so far on a production system with four profiles using version 1.1.58. 

Thanks for your feedback, glad to hear that it works so far

I'll keep an eye on it as there is some colour picking weirdness going on (changing it in one profile changes it in another) but that's for another day.

Thats not skin releated, so there is nothing you can do from the skin side.

Actually... your skin version 1.1.56-Startup-Patch-2 has no bugs for:

1. The login issue where logging out oaf a multiple profiles system logs back into the master profile automatically
2. The colour issue. Each profile retains custom highlight and gradient colours when different users log in

Under 1.1.58:

1. The login issue is there until you turn off the "startup window" under the Extras menu in the skin settings
2.  Changing custom skin colours in any profile overwrites the colour settings in the settings.xml file for all users in each profile's "...\AppData\Roaming\Kodi\userdata\addon_data\skin.arctic.zephyr.mod" folder upon logging out.

Here are the log files for you:

This is version 1.1.58 with the profile and colour error

And...

This is version 1.1.56-SP2 without the errors



I'm not sure what the difference is in those two versions, but the patched version of 1.1.56 "just works".  In no way am I disparaging the work you're doing, I think it's great and I'll stick with 1.1.56-SP-2 for now, but I hope you can track down the differences and put them into 1.1.59 or the latest version.