[jdig4240]

Code:

Hey Gujal, maybe you can help? So I had an IMDB Trailers player working with The Movie Database Helper. Its a really useful player. It stopped working in the last couple days. The IMDB Trailers addon still works and so does the search. Maybe somebody can help get this player working again. Thanks, heres the imdbtrailers.json player code: { "name": "Watch Trailer Now", "plugin": "plugin.video.imdb.trailers", "priority": 1, "play_movie": [ "plugin://plugin.video.imdb.trailers/?action=search", { "keyboard": "{title}" }, { "title": "{title}" } ], "is_resolvable": "false" }

The search endpoint is now for displaying the keyboard and getting an input. It then calls another action search_word with parameter keyword
For your use case now please try with
plugin://plugin.video.imdb.trailers/?action=search_word&keyword=title

Yes, this works, Thank you! 

{ "name": "Watch Trailer Now", "plugin": "plugin.video.imdb.trailers", "priority": 1, "play_movie": [ "plugin://plugin.video.imdb.trailers/?action=search_word&keyword={title}", { "keyboard": "{title}" }, { "title": "{title}" } ], "is_resolvable": "True" }

[Hyphaed]

Hi IMDb Trailers is not launching trough skin properly

https://www.dropbox.com/s/uu1eepreh0guym...r.m4v?dl=0

https://paste.kodi.tv/qiwaxewile.kodi

[Hyphaed]

usinc Arctic Zephyr Reloaded

https://forum.kodi.tv/showthread.php?tid...2&page=272

[graysky]

@gujal - I am finding that this plugin is incompatible with python 3.10.1.  It segfaults Kodi (latest git from matrix branch or 19.3).  Please see this debug log.  Any thoughts?

[gujal]

@graysky All the errors I see are related to sqlite db compatibility
 

Code:

File "/usr/lib/python3.10/sqlite3/dbapi2.py", line 83, in register_adapters_and_converters

IMDB Trailers addon uses script.common.plugin.cache to cache data and that script module uses sqlite to maintain the cache db.

Probably changes in Python 3.10 sqlite that needs to be addressed by the script module. I am not sure if 3.10 is used by devs for testing Kodi. It is mostly tested in ubuntu 20.04 LTS which is Python 3.8
I myself test it on Windows, Ubuntu 20.04LTS, LibreElec10.0.1 and Android and in all cases it is Python 3.8

The script module is maintained by @anxdpanic, you can maybe raise an issue in his git

Code:

https://github.com/anxdpanic/script.common.plugin.cache

[graysky]

@gujal - Thanks for the quick reply.  Please see plugin.video.youtube#255.  @asavah identified a commit in python itself which is causing the breakage.  If I revert it and compile python 3.10.1, both youtube and IMDB Trailers work again.

[gargamon]

Yes, we are still using and still appreciate the functionality provided by this addon. Thanks for keeping it running.

It looks like there must have been a change to IMDB. The addon crashes when trying to see a trailer. Here's the python traceback from the log.

2022-05-10 10:04:20.772 T:481     ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'AttributeError'>
                                                   Error Contents: 'str' object has no attribute 'get'
                                                   Traceback (most recent call last):
                                                     File "/home/my/.kodi/addons/plugin.video.imdb.trailers/default.py", line 23, in <module>
                                                       imdb_trailers.Main()
                                                     File "/home/my/.kodi/addons/plugin.video.imdb.trailers/resources/lib/imdb_trailers.py", line 88, in __init__
                                                       self.play()
                                                     File "/home/my/.kodi/addons/plugin.video.imdb.trailers/resources/lib/imdb_trailers.py", line 439, in play
                                                       listitem.setPath(cache.cacheFunction(self.fetch_video_url, self.parameters('videoid')))
                                                     File "/home/my/.kodi/addons/script.common.plugin.cache/resources/lib/storage_server/StorageServer.py", line 628, in cacheFunction
                                                       ret_val = funct(*args)
                                                     File "/home/my/.kodi/addons/plugin.video.imdb.trailers/resources/lib/imdb_trailers.py", line 396, in fetch_video_url
                                                       details = {i['definition']: i['url'] for i in details[0].get('videoLegacyEncodings', [])}
                                                   AttributeError: 'str' object has no attribute 'get'
                                                   -->End of Python script error report<--
   
Thanks in advance.

[gujal]

Yes, we are still using and still appreciate the functionality provided by this addon. Thanks for keeping it running.

It looks like there must have been a change to IMDB. The addon crashes when trying to see a trailer. Here's the python traceback from the log.
   
Thanks in advance.

Please adhere to Forum rules by not posting log snippets in the forum. Please always upload full debug log using kodi log uploader and provide the resulting shortlink here
Need debug log to see which url caused the issue as the snippet only shows the effect and not the cause

[gargamon]

Yes, we are still using and still appreciate the functionality provided by this addon. Thanks for keeping it running.

It looks like there must have been a change to IMDB. The addon crashes when trying to see a trailer. Here's the python traceback from the log.
   
Thanks in advance.

Please adhere to Forum rules by not posting log snippets in the forum. Please always upload full debug log using kodi log uploader and provide the resulting shortlink here
Need debug log to see which url caused the issue as the snippet only shows the effect and not the cause

Every URL is failing, on both android and Linux. But, here's the debug log you requested:

https://paste.kodi.tv/faxacobiza.kodi

Thanks for the quick response!

[gujal]

Every URL is failing, on both android and Linux. But, here's the debug log you requested:
https://paste.kodi.tv/faxacobiza.kodi

Thanks for the quick response!

Thanks for the debug log. Looks like the mobile website operated by imdb that this addon uses to pull stream information has been decommissioned.
Have to redo the addon playback section to work with the main site, the addon IS BROKEN for now.
If you want to test the fix, you can replace imdb_trailers.py in the addon-resources-lib folder with the one in git

Code:

https://github.com/Gujal00/Kodi-Official/blob/master/plugin.video.imdb.trailers/resources/lib/imdb_trailers.py

[graysky]

@gujal - Thank you for the fix.  It seems to be working if I am using python-3.10.2-1 (Arch Linux) but if I update to the current version of python-3.10.4-1 I get an immediate crash of the plugin upon using it to retrieve any content.

For example: IMDb Trailers>Recently Added (crash)

Kodi crash log
In my dmesg output, I get this line when it crashes:

Code:

[May13 04:02] LanguageInvoker[2337]: segfault at 8 ip 00007f150587e510 sp 00007f147e80de00 error 4 in libpython3.10.so.1.0[7f1505789000+22b000]
[  +0.000012] Code: 20 74 ef 48 83 7a 10 00 75 ab eb e6 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 f3 0f 1e fa 53 48 8b 4f f0 48 89 fb 48 8b 57 f8 <48> 8b 41 08 48 83 e2 fc 83 e0 03 48 89 0a 48 09 d0 48 89 41 08 48

EDIT: This is a python bug. Building 3.10.4 with the fix called out in this link fixes it: https://bugs.archlinux.org/task/73002#comment208311

[gujal]

@gujal - Thank you for the fix.  It seems to be working if I am using python-3.10.2-1 (Arch Linux) but if I update to the current version of python-3.10.4-1 I get an immediate crash of the plugin upon using it to retrieve any content.

For example: IMDb Trailers>Recently Added (crash)

Kodi crash log
In my dmesg output, I get this line when it crashes:
 

Code:

[May13 04:02] LanguageInvoker[2337]: segfault at 8 ip 00007f150587e510 sp 00007f147e80de00 error 4 in libpython3.10.so.1.0[7f1505789000+22b000]
[  +0.000012] Code: 20 74 ef 48 83 7a 10 00 75 ab eb e6 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 f3 0f 1e fa 53 48 8b 4f f0 48 89 fb 48 8b 57 f8 <48> 8b 41 08 48 83 e2 fc 83 e0 03 48 89 0a 48 09 d0 48 89 41 08 48

EDIT: This is a python bug. Building 3.10.4 with the fix called out in this link fixes it: https://bugs.archlinux.org/task/73002#comment208311

Yes the newly introduced sub-intrepreter functionality in Python 3.9/10 is extremely buggy and causes crashes with sqllite that commoncache script module uses
I only test on Ubuntu 20.04 LTS based distros as well as CoreELec/LibreElec and they all use Python 3.8 and have no issues

[Salomon]

Hi there.
Any word on a fix for Windows, Matrix users?
For the average user, like me, the addon just failed some days ago and following the python fix is kinda complicated if one is not cs savvy.
Thanks in advance.

[gujal]

Hi there.
Any word on a fix for Windows, Matrix users?
For the average user, like me, the addon just failed some days ago and following the python fix is kinda complicated if one is not cs savvy.
Thanks in advance.

The fix above is for all platforms and Kodi versions Leia, or Matrix. will raise a PR with Kodi repo when I get some time.

[Salomon]

Once again... these posts are visible to any users, not just the ones that can do something with the explanation or fix given. The rest of us do not understand how to apply the fix or where.
Thanks anyway, we'll wait for when you have the time.
It should be a good practice...
Kind regards
ST