[ChocOranger]

For anyone experiencing something similar; someone nice on reddit helped with a script to apply 'sunglasses' over the OSD by editing 2 xml files of the skin. This is a nice workaround until hopefully someday a real feature can be made to dim OSD elements during HDR playback.

https://www.reddit.com/r/kodi/comments/1...k/krtr2e5/

It's worth noting that the changes I gave you are only for Arctic Horizon 2.

[MrMagic]

Not for now. First needs to be full tested on more Android devices besides of Shield...

My Philips TV with Google TV 12 seems to have a mind of its own and somehow ignores the new settings. But it's ok, because the subtitles were already not bright anyway.

However, I think a regression has been introduced, where resuming a video from a resume point saved by Kodi results in no video output.

[ChocOranger]

Test builds (v21) that implements GUI SDR peak luminance setting for Android:

ARM64:
kodi-20240225-01a19a30-android-gui-sdr-peak-arm64-v8a.apk

ARM:
kodi-20240225-01a19a30-android-gui-sdr-peak-armeabi-v7a.apk

What version of v21 is the test build for?

[illuvattarr]

For anyone experiencing something similar; someone nice on reddit helped with a script to apply 'sunglasses' over the OSD by editing 2 xml files of the skin. This is a nice workaround until hopefully someday a real feature can be made to dim OSD elements during HDR playback.

https://www.reddit.com/r/kodi/comments/1...k/krtr2e5/

It's worth noting that the changes I gave you are only for Arctic Horizon 2.

Yup, I striked my post out, thanks anyway!

I got the v21 testbuild working fine on my Shield 2019 Pro now.
Works wonderfully and I've got it set to 60% peak luminance, which seemed fine. 40% was a bit too much dimming for me.

[jogal]

New builds to sync with PR code and curve adjusted to better match with Windows.

At default 40% now is less dimmed and the adjustment is smoother since it has less amplitude, focusing on the useful values of the scale.

ARM64:
kodi-20240226-7287d174-android-gui-sdr-peak-arm64-v8a.apk

ARM:
kodi-20240226-7287d174-android-gui-sdr-peak-armeabi-v7a.apk


The feedback is good but still is need someone to test on other popular devices as Fire stick TV 4K Max / no max, Cube, etc.

[MrMagic]

The feedback is good but still is need someone to test on other popular devices as Fire stick TV 4K Max / no max, Cube, etc.

Thanks for the new builds. Still working great on my Shield. I hope the PR is kept alive, since I saw some heated discussions about it on GitHub

[ChocOranger]

Thanks for the new builds. Still working great on my Shield. I hope the PR is kept alive, since I saw some heated discussions about it on GitHub

Sadly it looks like thexai/Jogal has been bullied out of the quick fix https://github.com/xbmc/xbmc/pull/24756 although he has resurrected the pr.

This really needs attention as the proposed fix is the next gen of Kodi 22.

[boboc]

Excellent feature, works like a charm on Fire TV Stick 4K Max 2nd gen, connected to LG C1.
Thank you very much!

[Dklktn_Dklktn]

Thanks for reopening the pr
I hope it will be merged for Omega (RC1 or Final). So we'll have a working solution asap for a real issue and it gives time to develop, implement and test the post processing solution sarbes has in mind

[Sholander]

Apart from complete overlay being too bright (which does not bother me at all) there is a very simple solution for lowering subtitle Font Brightness. 
In Settings/Player/Subtitles the default font transparency is set to 100%. Lowering that to 80% (or any choice of your liking) and using a yellow color makes my subtitles perfect to watch on any HDR/DV material on my LG Oled TV.

[sarbes]

Sadly it looks like thexai/Jogal has been bullied out of the quick fix https://github.com/xbmc/xbmc/pull/24756 although he has resurrected the pr.

Please point to where he was supposedly bullied.

Was it when I pointed out what the optimal approach was? Or maybe when I offered to implement most of it? Or even when I've actually did the PR for said approach?

As said multiple times in the PR, I don't have anything against the idea of having such functionality. What I don't like is having to shoulder the burden of placing it in the "optimal" path of our rendering pipeline, since I don't have a workflow for it.

[ChocOranger]

Please point to where he was supposedly bullied.

I don't think you purposely bullied and it's probably a stronger word than I intended so apologies. I think "he felt pressured" would be better in retrospect.
After he closed the PR initially, I think you realised and a language barrier may have played a part as you said.

I'm sure you understand that in software development that the ideal long-term solution is not always the best initial approach. Sometimes a better approach is a 'quick fix' to workaround a specific issue, then provide a lasting solution later. It's more work but provides benefits earlier. I feel that this is definitely a case where early benefits are worthwhile especially as companies seem to be doubling down on the TV brightness wars.
And your assumption that I don't grasp the basis of your objections is incorrect  

If thexai hadn't created a temporary 'fix' I doubt there would have been any movement to get the issue on the table and addressed.

And thanks for picking this up and approving the PR. Let's now hope it can make it into Omega.

[ChocOranger]

Apart from complete overlay being too bright (which does not bother me at all) there is a very simple solution for lowering subtitle Font Brightness. 
In Settings/Player/Subtitles the default font transparency is set to 100%. Lowering that to 80% (or any choice of your liking) and using a yellow color makes my subtitles perfect to watch on any HDR/DV material on my LG Oled TV.

The overlay being too bright not bothering you depends on just how bright your TV can be. Not all TVs have the same maximum brightness. 

Yes, you can change the subtitle colour for HDR/DV although I need different grays to get a consistent brightness and yellow looks horrible (Broadcasters tried it years ago). SDR needs subs so much brighter. Subs that are OK for SDR blind me in DV.
I don't consider it a suitable fix to change subtitle colours per movie and neither does the virtually deaf person in my household that relies on subs.

[Sholander]

Since I use subs only for HDR/DV material I don't have to change my settings; The color I use is IIRC "Sunglow" at 70% transparency so they are not really yellow, but pale ocher.
Btw, my TV has 1000 nits, and I enjoy every nit of it

[ChocOranger]

Since I use subs only for HDR/DV material I don't have to change my settings

Then it really isn't a solution as it doesn't cater for SDR.