[davorf]

Hello @Fuchs2468

Those changes looks great. I was wondering if you could add changes I've added regarding widget visibility (hiding empty widgets) and new widget type (In progress media and next episode)? I'm hesitant to update the skin, because after every update I have to manually change files to get this new widget I'm using on almost every page, and to hide empty widgets (screen looks much better when you can see only populated widgets). At least new widget shouldn't be a problem, since, if people don't want it, or it doesn't work as expected, they can decide not to use it (I've been using it for 7 months and it works really good).  I've written code changes some time earlier: 

- For hiding empty widgets - post #2871, 01.02.2024
- For adding new widget - post #2855, 01.02.2024

I'm not sure if line numbers have changed, since you've probably added/removed some code from these files, but if you need help, I can try to locate exact location for those, and write a new instructions. 

Thank you in advance.

Best regards,
Davor

[Fuchs2468]

- For hiding empty widgets - post #2871, 01.02.2024
- For adding new widget - post #2855, 01.02.2024

Oh sorry, I actually forgot about the "Hide empty widgets" function.
I'll add it in my next update.
I can't promise you anything about the 2nd change to "Skin Helper Service Widgets".

Good to know that you liked my last changes to the skin.

[davorf]

Hello! 

It's not something crucial, but it would make it easier (for me) to update skin. If I'm not mistaken, Skin Helper Service Widgets is independent add-on? If that's the case, I could just turn off automatic updates on this add-on and leave skin on auto-update after you implement hiding empty widgets. That way I could update skin to the latest version and still have my custom widget.

Thank you for your work.

Best regards,
Davor

[davorf]

Hello! 

Just a quick update. I just found out (watching a TV show) that Next episode widget in Skin Helper Service Widgets does not work correctly if TV show has specials between seasons (original, unchanged widget from Skin Helper Service Widgets). I'm using this Next episode code partially in my In progress media and next episode custom widget, so I've noticed that specials don't show up. I've tried original Next episode widget too, just to be sure there wasn't some error in my widget, but it behaves the same.

The problem is that filtering does take into account setting "episodes_enable_specials", but then it creates a filter that either has "season greaterthan 0" AND "season greaterthan last season" if "episodes_enable_specials" is disabled or just "season greaterthan last season" if "episodes_enable_specials" is enabled. So, either way, it excludes specials which are Season 0. I've managed to make a change to both - original Next episode widget and my custom widget, so, now they behave correctly - if "episodes_enable_specials" is disabled it looks for "season greaterthan 0" AND "season greaterthan last season" (even though it's kind of redundant), and if "episodes_enable_specials" is enabled it looks for "season is 0" OR "season is greaterthan last season".

If you want, I can provide files or code for this change.

Best regards,
Davor

[Fuchs2468]

If you want, I can provide files or code for this change.

I haven't noticed that yet, as I don't have any TV shows with specials.
But thanks for the info.
It would be nice if you could provide your code, then I could test it.

Have you tested "Embuary Helper" with specials yet.
It also has "Next Episode" like "Skin Helper Service Widgets".

[davorf]

Hello!

For the original Next episode widget, I've made changes in Kodi\addons\script.skin.helper.widgets\resources\lib\episodes.py

I've changed get_next_episode_for_show method (from line 163). Here's the code for the complete method, so you can just copy/paste it over the current get_next_episode_for_show method (from def get_next_episode_for_show to def unaired): 

Code:

    def get_next_episode_for_show(self, show_id):
        '''
        get last played watched episode for show,
        return next unwatched episode after that,
        unless nothing after that, then return first episode
        '''
        filters = []
        fields = ["playcount", "season"]
        next_episode = None

        # get the next unwatched episode after the last played episode
        last_played_episode = self.metadatautils.kodidb.episodes(sort=kodi_constants.SORT_LASTPLAYED,
                    filters=filters + [kodi_constants.FILTER_WATCHED], limits=(0, 1), tvshowid=show_id, fields=fields)
        if last_played_episode:
            last_played_episode = last_played_episode[0]
            filter_season = last_played_episode["season"] - 1
            
            if not self.options["episodes_enable_specials"]:
                filters.append({
                    "and": [
                        {
                            "field": "season",
                            "operator": "greaterthan",
                            "value": "0",
                        },
                        {
                            "field": "season",
                            "operator": "greaterthan",
                            "value": "%s" % filter_season
                        }
                    ]
                })
            else:
                filters.append({
                    "or": [
                        {
                            "field": "season",
                            "operator": "is",
                            "value": "0",
                        },
                        {
                            "field": "season",
                            "operator": "greaterthan",
                            "value": "%s" % filter_season
                        }
                    ]
                })
            
            all_episodes = self.metadatautils.kodidb.episodes(sort=kodi_constants.SORT_EPISODE,
                    filters=filters, tvshowid=show_id, fields=fields)
            # find index of last_played_episode in the list all_episodes
            try:
                for index, episode in enumerate(all_episodes):
                    if episode['episodeid'] == last_played_episode['episodeid']:
                        i = 1
                        while True:
                            if int(all_episodes[index + i]['playcount']) < 1:
                                next_episode = all_episodes[index + i]
                                break
                            i += 1
            except IndexError:
                # no unplayed episodes left
                next_episode = None
        # just get the first unwatched episode (e.g. when we simply do not yet have any fully played episodes)
        if not next_episode:
            next_episode = self.metadatautils.kodidb.episodes(
                sort=kodi_constants.SORT_EPISODE, filters=filters + [kodi_constants.FILTER_UNWATCHED],
                limits=(0, 1), tvshowid=show_id, fields=fields)
            next_episode = next_episode[0] if next_episode else None
        # return full details for our episode
        return self.metadatautils.kodidb.episode(next_episode["episodeid"]) if next_episode else None



I haven't used Embuary Helper widgets at all, so I don't know if it works with specials. Skin Helper Service Widgets was (at the time I made new widget) better fitting for my needs. 

Best regards,
Davor

[UbuntuUser]

In the past I was able to replace all instances of "script.artwork.beef" with "script.artwork.downloader" in IncludesDialogVideoInfo.xml and it worked I was still able to use artwork downloader.  But in this version when I do that I get the button, but it does not work.  Everytime I try to run it I get this error in the log...
error <general>: ExecuteAsync - Not executing non-existing script script.artwork.downloader

But I can very clearly see the script is there?  Any help would be greatly appreciated.

Thanks, UbuntuUser

[Fuchs2468]

In the past I was able to replace all instances of "script.artwork.beef" with "script.artwork.downloader" in IncludesDialogVideoInfo.xml and it worked I was still able to use artwork downloader.  But in this version when I do that I get the button, but it does not work.  Everytime I try to run it I get this error in the log...
error <general>: ExecuteAsync - Not executing non-existing script script.artwork.downloader

But I can very clearly see the script is there?  Any help would be greatly appreciated.

Thanks, UbuntuUser

Which command do you use to call script.artwork.downloader?

[aneurysm-]

hey ... I took the plunge (well I didn't actually, my media box ..Vero V updated without consent .. but it's on kodi 21 now. I know an upgrade would not work, so I removed the kodi folder to start from scratch. Installed the repo .. but I can't install the skin ... I'm getting Failed to Install a Dependency the entire time when wanting to install it. I had  this problem a few times in the past as well .. can't remember how I solved it ... any tips ?

[Fuchs2468]

hey ... I took the plunge (well I didn't actually, my media box ..Vero V updated without consent .. but it's on kodi 21 now. I know an upgrade would not work, so I removed the kodi folder to start from scratch. Installed the repo .. but I can't install the skin ... I'm getting Failed to Install a Dependency the entire time when wanting to install it. I had  this problem a few times in the past as well .. can't remember how I solved it ... any tips ?

Have you installed the correct repo version for Kodi 21?

repository.fuchs246-1.0.2 

And which dependency exactly could not be installed?

[aneurysm-]

hey .. yeah I did.. 1.0.2
I fixed it, seems that was a problem with the Vero. Had to install all dependencies separate 1-1 and then it installed. So that's good.
Wanted to ask though, cause I've had this problem also a lot before ... I'm getting a lot of "skin helper service errors" pop ups in general. And then some stuff don't work until I restart. (like backgrounds with movies & tv shows in the main menu, and more importantly .. showing rotten ratings & such in the movies view).

[aneurysm-]

2nd question .. It doesn't give me an option anymore to download fanart for the weather view ? Says there is nothing to download ?

[UbuntuUser]

In the past I was able to replace all instances of "script.artwork.beef" with "script.artwork.downloader" in IncludesDialogVideoInfo.xml and it worked I was still able to use artwork downloader.  But in this version when I do that I get the button, but it does not work.  Everytime I try to run it I get this error in the log...
error <general>: ExecuteAsync - Not executing non-existing script script.artwork.downloader

But I can very clearly see the script is there?  Any help would be greatly appreciated.

Thanks, UbuntuUser

Which command do you use to call script.artwork.downloader?

Thanks for the responds, I was able to figure it out.  It was because for some reason it had disabled the script.artwork.downloader, so as soon as I enabled it, it worked.

[UbuntuUser]

Is there anyway with this skin to use icons like this at the bottom instead of the text?

[davorf]

Hello!

I'm not 100% sure if that's what you want, but you can try changing "Style for media/codec info" to Large Icons Color. It's located in Settings -> Skin settings -> Media library views -> Media flag settings (section) -> Style for media/codec info.

Hope this helps.

Best regards,
Davor