Release Artist Slideshow addon (with skin and addon integration)
(2013-07-09, 03:35)scott967 Wrote: Thanks. I've been digging into getting 1.5.2 running. Having a problem with the script returning "site unreachable" from last.fm, but when I copy the url into a browser it works (returns data as expected). This is on XBMC 12.2 and Ace skin 1.7.0. For testing I set an AS local folder as "testmusic" (no local data is present for this artist though). Here is my log: http://xbmclogs.com/show.php?id=35532 with AS started on thread 6816 @ line 767. I tried my api key just in case (didn't think it would matter since it works in browser) and still get "site unreachable". Near as I can tell something is going wrong with a call to urllib.urlretrieve(url,filename)? I see another user seems to have had this problem, but if couldn't tell if it was ever resolved.

So I installed 1.5.3.009 just to see what would happen and it's a little hard to follow the logs but this time it worked, even though the same url to last.fm was generated.

Yea, while working on 1.5.3 I found a pretty long standing bug with last.fm URLs and Unicode. So I fixed it. I also migrated over to urllib2 at the same time. So that might be helping things too.

Quote:I did notice that 1.5.3.009 went to musicbrainz and did find the artist MBID, but when it couldn't find a matching release or recording it threw the artist MBID away (apparently). FWIW the script also logged an error on a unicode comparison. Sent a log on this to pastebin if interested. http://pastebin.com/EWVdAVGT

Musicbrainz is a special beast. Their search results default to giving you the most possible results even if there is only a small chance it's a match. So I have to do some additional comparisons, as I'd rather you get nothing back than the wrong artist. So AS checks to see if the currently playing album name is in the list of album names for a potential match. If it doesn't find anything, then it tries to find a match to the song name. If it still doesn't find anything then it gives up and passes back nothing. Without that logic about half my artists were coming back with incorrect artwork.

As to the Unicode thing, that's a bug. I'll go sacrifice another small animal to the Unicode gods and see if I can fix it. Would it be wrong of me to ask everyone to just start using Latin characters for everything? Big Grin

Disclaimer: I won't actually be sacrificing any animals, small or otherwise.
Reply


Messages In This Thread
New Test Version Available - by pkscout - 2012-03-08, 16:26
[No subject] - by mardup - 2012-03-10, 12:26
[No subject] - by pkscout - 2012-03-11, 01:35
RE: - by mardup - 2012-03-12, 17:50
RE: - by pkscout - 2012-03-13, 03:22
New Beta Version for Testing - by pkscout - 2012-07-13, 17:54
New Beta Version for Testing - by pkscout - 2012-07-14, 22:50
Pull Request for v1.4 Submitted - by pkscout - 2012-07-20, 23:01
New Beta Version for Testing - by pkscout - 2012-08-10, 03:18
New Frodo BETA Support Files - by pkscout - 2012-11-21, 06:20
RE: [RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration) - by pkscout - 2013-07-09, 03:45
New 2.0.0 Beta Coming Soon - by pkscout - 2016-05-12, 02:54
Writing tips - by Parkerbup - 2017-02-03, 14:56
Add-on Artist Slideshow - by jo26 - 2014-08-08, 22:58
Logout Mark Read Team Forum Stats Members Help
Artist Slideshow addon (with skin and addon integration)5