2021-03-08, 15:49
Since Kodi 19 there are no more separate binaries for Wayland and X11. This can (in my case) lead to unwanted behaviour: When I explicitly start kodi in X11 mode via kodi --windowing=x11 (I have reasons...), launch steam from the addon (which shuts down kodi) and exit steam afterwards (which launches kodi) my original preference on the rendering backend is ignored (which means kodi is being started on Wayland).
I crawled through steam-launcher.sh; the way it currently works it cannot distinguish between X11 and Wayland anymore by the name of the binary. To solve this it could instead take into account any command line arguments and recycle them later appropirately. In line 63 where
Alternatively you could implement an option in the addon settings which lets the user set command line arguments for kodi as is already there for the steam executable.
I would appreciate if you considered and took a look into this issue. I'd gladly file an issue on your GitHub repo if you wish.
I crawled through steam-launcher.sh; the way it currently works it cannot distinguish between X11 and Wayland anymore by the name of the binary. To solve this it could instead take into account any command line arguments and recycle them later appropirately. In line 63 where
$KODI_BIN is defined ps aux could be extended to find command line parameters, maybe with -o args. I'm not too much into bash magic, so I guess that's all the help I can give.Alternatively you could implement an option in the addon settings which lets the user set command line arguments for kodi as is already there for the steam executable.
I would appreciate if you considered and took a look into this issue. I'd gladly file an issue on your GitHub repo if you wish.
