2021-03-05, 20:30
2021-05-05, 14:42
(2020-04-10, 18:33)HiGhLaNdeR Wrote: Matrix version done, TEST please.Hi HiGhLaNdeR,
GITHUB:
https://github.com/highlandr/service.sub...atrix-Beta
Made a pull request, should be on the official repo soon.
Thanks.
First of all, thanks for all the work in maintaining the add-on and updating to the Matrix version.
I'm picking up on the previous comment in the thread, since I was also having issues with the "no subtitles found" message. So I did a bit of digging, and I may have found something worth looking into (TBC). I tested the fix and it worked for me, so I will send you some details via e-mail. Please let me know if you read this and/or the e-mail.
Thanks again, cheers
2021-07-12, 03:22
Hello, Warheart, if you want, you can talk to me at LD.
2021-12-27, 07:05
As we know, Highlander's latest release (1.0.4) is not working with Kodi 19. It installs and runs but never returns any results. On Highlander's Github there's a commit from another person (jpremelhe), which is said to resolve the issue. In fact it doesn't completely solve it. I think it might work with movies but not with tv shows. I tried it and it never returns anything for tv shows.
In the meantime, by looking at jpremelhe's improvements and by tweaking a bit more, the plugin now appears to be working well. I also corrected a couple of additional things so now it is able to return more results than before and doesn't throw out an error when the search results include a "popular" subtitle (more than 500 views, I believe).
The question now is: is there a way to commit these corrections to the official Kodi repo? It's a pity that a plugin is no longer working because the author is no longer available to update it but there's already a working solution from another source.
In the meantime, by looking at jpremelhe's improvements and by tweaking a bit more, the plugin now appears to be working well. I also corrected a couple of additional things so now it is able to return more results than before and doesn't throw out an error when the search results include a "popular" subtitle (more than 500 views, I believe).
The question now is: is there a way to commit these corrections to the official Kodi repo? It's a pity that a plugin is no longer working because the author is no longer available to update it but there's already a working solution from another source.
2021-12-28, 03:13
I'm here.
Trying to figure out why it works on my Kodi and not for you guys.
Tested on 2 TV shows. Expanse and Star Trek Discovery.
Checking my code against the code on github official xbmc repo.
Thanks.
Regards.
Edit: There's some superpopular.gif added to the html of the site which breaks the regex ... I'll have to look at that. Every movie or tv show with that superpopular.gif will break everything...
Edit1: change this line (102) in service.py till I get it updated in the official repo.
subtitle_pattern = "<div\sclass=\"sub_box\">.+?<div\sclass=\"sub_header\">.+?<b>(.+?)</b>\s\((\d\d\d\d)\)\s.+?name=User_Info&username=(.+?)'><b>.+?</div>.+?<table\sclass=\"sub_main\scolor1\"\scellspacing=\"0\">.+?<tr>.+?<th>CDs:</th>.+?<td>(.+?)</td>.+?<a\shref=\"\?name=Downloads&d_op=ratedownload&lid=(.+?)\">.+?<th\sclass=\"color2\">Hits:</th>.+?<td>(.+?)<img.+?<td>(.+?)</td>.+?<td\scolspan=\"5\"\sclass=\"td_desc\sbrd_up\">(.*?)</td>.+?<td\sclass"
Trying to figure out why it works on my Kodi and not for you guys.
Tested on 2 TV shows. Expanse and Star Trek Discovery.
Checking my code against the code on github official xbmc repo.
Thanks.
Regards.
Edit: There's some superpopular.gif added to the html of the site which breaks the regex ... I'll have to look at that. Every movie or tv show with that superpopular.gif will break everything...
Edit1: change this line (102) in service.py till I get it updated in the official repo.
subtitle_pattern = "<div\sclass=\"sub_box\">.+?<div\sclass=\"sub_header\">.+?<b>(.+?)</b>\s\((\d\d\d\d)\)\s.+?name=User_Info&username=(.+?)'><b>.+?</div>.+?<table\sclass=\"sub_main\scolor1\"\scellspacing=\"0\">.+?<tr>.+?<th>CDs:</th>.+?<td>(.+?)</td>.+?<a\shref=\"\?name=Downloads&d_op=ratedownload&lid=(.+?)\">.+?<th\sclass=\"color2\">Hits:</th>.+?<td>(.+?)<img.+?<td>(.+?)</td>.+?<td\scolspan=\"5\"\sclass=\"td_desc\sbrd_up\">(.*?)</td>.+?<td\sclass"
2021-12-28, 03:22
Hi, that is one issue but is not the main issue. The main issue is that the login process fails all the time. So, there's always no results. I discovered the "popular" bug after solving the login issue. The solution to the popular bug is quite easy. I used the login solution from jpremelhe, submitted to your github. Also did a small tweak to the search process, which now returns more results. I'll try to send the py file.
2021-12-28, 03:29
2021-12-28, 03:44
(2021-12-28, 03:13)HiGhLaNdeR Wrote: I'm here.
Trying to figure out why it works on my Kodi and not for you guys.
Tested on 2 TV shows. Expanse and Star Trek Discovery.
Checking my code against the code on github official xbmc repo.
Thanks.
Regards.
Edit: There's some superpopular.gif added to the html of the site which breaks the regex ... I'll have to look at that. Every movie or tv show with that superpopular.gif will break everything...
Edit1: change this line (102) in service.py till I get it updated in the official repo.
subtitle_pattern = "<div\sclass=\"sub_box\">.+?<div\sclass=\"sub_header\">.+?<b>(.+?)</b>\s\((\d\d\d\d)\)\s.+?name=User_Info&username=(.+?)'><b>.+?</div>.+?<table\sclass=\"sub_main\scolor1\"\scellspacing=\"0\">.+?<tr>.+?<th>CDs:</th>.+?<td>(.+?)</td>.+?<a\shref=\"\?name=Downloads&d_op=ratedownload&lid=(.+?)\">.+?<th\sclass=\"color2\">Hits:</th>.+?<td>(.+?)<img.+?<td>(.+?)</td>.+?<td\scolspan=\"5\"\sclass=\"td_desc\sbrd_up\">(.*?)</td>.+?<td\sclass"
I'm a Python newbie so your regex solution is more elegant, of course. But do note that the login is failing for us. Jpremelhe submitted a commit, where he created a sub, just for that, and also tweaked the login process itself. And it works.
2021-12-28, 13:36
Good morning.
Well my old repo Matrix-Beta had the file correctly working with Matrix. The only missing thing was the new regex I've made yesterday night.
I will request it to be added to the official repo.
Meanwhile please test the one here:
https://github.com/highlandr/service.sub...gendasdivx
Thanks.
Cheers!
Well my old repo Matrix-Beta had the file correctly working with Matrix. The only missing thing was the new regex I've made yesterday night.
I will request it to be added to the official repo.
Meanwhile please test the one here:
https://github.com/highlandr/service.sub...gendasdivx
Thanks.
Cheers!
2021-12-28, 17:27
I did a brief test, tv show, 1883, episodes 1 and 3. In both cases I received an error and, of course, no results. Later today I'll activate debug and check where the error was.
2021-12-28, 17:29
Submitted the v1.0.5.
Kodi Windows or Linux?
Kodi Windows or Linux?
2021-12-28, 17:31
2021-12-28, 17:33
Linux then 
Ok I will test in a linux\android box and see how it goes.
Thanks.
Ok I will test in a linux\android box and see how it goes.
Thanks.
2021-12-28, 19:55
This is good news! Thank you.
If you need my help, let me know.
If you need my help, let me know.
2021-12-28, 23:59
The error is still regex related:
ValueError: invalid literal for int() with base 10: '162 </td>\n<th>Pedidos:</th>\n<td>8 </td>\n<th>Origem:</th>\n<td>Adaptação </td>\n</tr>\n<tr>\n<th class="color2">Descrição:</th><td colspan="5" class="td_desc brd_up"><center>'
Maybe there's a better way but, when I found this error, I solved it this way:
hits = matches.group(6)
if len(hits) > 10 : hits = hits.split(' ', 1)[0]
id = matches.group(5)
id = str.split(id, '"')
id = id[0]
movieyear = matches.group(2)
no_files = matches.group(4)
downloads = int(hits) / 200
After adding that, there's no more errors but, then, there's another issue, for the "1883" tv show and episode 1, the search returns 32 results. When there are only 2 subtitles available. One PT and another PT-BR. I believe the search subroutine is flawed in this new version. The previous version was better.
ValueError: invalid literal for int() with base 10: '162 </td>\n<th>Pedidos:</th>\n<td>8 </td>\n<th>Origem:</th>\n<td>Adaptação </td>\n</tr>\n<tr>\n<th class="color2">Descrição:</th><td colspan="5" class="td_desc brd_up"><center>'
Maybe there's a better way but, when I found this error, I solved it this way:
hits = matches.group(6)
if len(hits) > 10 : hits = hits.split(' ', 1)[0]
id = matches.group(5)
id = str.split(id, '"')
id = id[0]
movieyear = matches.group(2)
no_files = matches.group(4)
downloads = int(hits) / 200
After adding that, there's no more errors but, then, there's another issue, for the "1883" tv show and episode 1, the search returns 32 results. When there are only 2 subtitles available. One PT and another PT-BR. I believe the search subroutine is flawed in this new version. The previous version was better.
