2018-12-01, 18:27
(2018-12-01, 02:43)mikeSiLVO Wrote: Ok. I'll change to guide when I remember to do it... If not "soon" please remind meI know about the Gamelibrary and I'll remind you about "Guide".
Game Library will not come until supported in Kodi core so that is not likely until at least middle of development or later for version 19 M****
(2018-12-01, 02:43)mikeSiLVO Wrote:I don't want to "kill" you I just wanted to point to some bugs and improvements without the need to add skinhelper-stuff (I know, you won't do that)(2018-11-30, 20:12)Solo0815 Wrote: Small Bugreport for LiveTV regarding the Topbar:
- Please change "Player.Progress" with "PVR.EpgEventProgress" for LiveTV in line 566 of Includes.xml. Maybe with a variable and a visible condition "!Pvr.IsPlayingTv" and "Pvr.IsPlayingTv"?
- do the same for line 651 --> Player.TimeRemaining vs PVR.EpgEventRemainingTime
Without this change the progressbar is always full filled and RemainingTime is around 00:01 until 00:10, which is wrong. The mentioned changes will solve this.
Haven't looked at the progress.cache. Maybe it could be the timeshift value for LiveTV?
Edit: I just wanted to mention the timeshift-info changes a few posts before. Without it, you don't see exactly, how much time you can go forward in timeshifting.
Your killing me here...
I'd like to get things squared away before the final Kodi Leia upload...
I will not add skin helper stuff but if you can show screenshots and code difference I can try my best to accommodate. Sorry but due to my lack of PVR this is all I can promise...
1. TopBar bug:
Have a look at these photos:
https://imgur.com/a/7x6tMV5
The first picture is without the fix, on the second, the progress bar for LiveTV is fixed --> correct progress, correct remaining time for the actual show
Here is the changed (fixed) version of Includes.xml: https://pastebin.com/JcfCMMzb
2. Add timeshift info (actual position, etc.):
The third pic is for timeshift info.
https://imgur.com/a/9QMAPeR
As you see, I hardcoded "Timeshift" atm. The code is already posted here
Includes_LiveTV:
replace code from line 149 to 193 with the one posted in the mentioned thread.
3. Missing Youtube Thumbnail in FullscreenInfo:
see here, line 175-251. I commented some things.
4. Add Plot/Description/Episodename for Recordings like in Movies, TVShows:
add PVR.IsPlayingRecording to line 116 in DialogFullscreenInfo.xml
Then you can have a look at the plot, like in movies etc.
Edit:
I found another bug:
5. Progressbar is not changing on "ChannelPreview"
The Progressbar for LiveTV is not changing, when "ChannelPreview" is active. To fix it, please have a look at the changes here:
https://pastebin.com/rxZL2fb3
Line 197-198, 234 and the progress-block with lines 237 - 245
Maybe you forgot to add this code, when you added the timeshift bar. It is in the code for Estuary here: https://github.com/xbmc/xbmc/blob/master...R.xml#L177