2019-04-07, 10:28
(2019-04-07, 04:39)mikeSiLVO Wrote:Aaaargh, I have to finally learn github commands *doh* Please have a look only at the changes in Variables.xml, that fixes Remaining time. The other changes shouldn't be in this PR.(2019-04-06, 12:06)Solo0815 Wrote: Fix for PVR remaining time:
https://github.com/mikesilvo164/Aeon-Nox-SiLVO/pull/86
Bug:
TVShows -> TVShow Fanart for unwatched items isn't working anymore. It just shows the default video PNG. Watched items show the episodepreview thumb.
It should look like this: https://forum.kodi.tv/showthread.php?tid...pid2721904
That PR has over a thousand lines of code changes so will not be merged cause it is too difficult to check all of them. I will edit the demo client to show a 61-69 minute "episode" and try to see where the variable is "messing up".
(2019-04-07, 04:39)mikeSiLVO Wrote: I just tested hiding episode thumbs and it is working exactly as expected in all episode views using v18.1 final. Where do you see it not working?It seems that "String.IsEqual(ListItem.Icon,OverlaySpoiler.png)" is never "true".
EDIT 3: If you say it is a problem with your damn Vitameatavegamin then we gonna have to throwdown...
...
Here are the corresponding Kodi-PRs:
https://github.com/xbmc/xbmc/pull/14914
https://github.com/xbmc/xbmc/pull/14971
The last one is IMHO the important one. It changes ListItenm.Icon corewise.
The fix for your skin is to change
withxml:String.IsEqual(ListItem.Overlay,OverlayUnwatched.png) + String.IsEqual(ListItem.Icon,OverlaySpoiler.png)
in "NoSpoilerIconVar" (Variables.xml).xml:String.IsEqual(ListItem.Plot,$LOCALIZE[20370])
This is tested on latest Kodi 18.2 RC, Milhouse build from 0304