2019-09-03, 21:23
(2019-09-03, 17:29)monisriz Wrote: Sorry for the late reply. I think it's working fine. I downloaded the zip from Github and checked on a test installation - looks good as far as I can tell.
Has this been pushed to the main Skin addon? I have not tested the scenarios on the main installation as yet.
Another thing that is messing with my OCD a bit is the "actor" images in the Video Info dialog. The smaller images/panel as you scroll down the info page looks great but upon selecting/highlighting an actor the poster on the left switches to a huge image of the actor. This brings up two issues in my mind:
1. This is a video info screen so the info displayed should mostly pertain to the video itself. We already see the actor image (smaller image on the right side in cast section). Blowing up the image to replace the movie/tv poster doesn't add value in my opinion.
2. Some of the actor images are low res. They look fine in the cast section where the images are smaller but look horrible when scaled up to replace the poster on the left side. Also some actors don't have images - in that case a black image is displayed in cast panel which looks fine but on the left there's a huge area covered in black.
Keeping movie/tv poster in place would help fix these issues. I would love to hear from you if you feel I am missing some thing here. I briefly tried looking around in the DialogVideoInfo.xml to try and fix this and create the pull request but didn't get much far. Couldn't find the logic that swaps the movie/tv poster with actor image on the left.. could you point me in the right direction?
Thanks for the great support and quick turn around as always!
1) It is like that for two reason.
- I want to make sure the user knows what item they are focused on. I don't want to have to add a focused border texture and the label changing colors might not be enough.
- Also I like showing the bigger image there for actors and all the other panels that might be available
2) I will change the current behavior and not show the default fallback (black) image when there isn't one available. You'll be able to test it when I push it to GitHub sometime today.
As for pointing the way you can check in Variables.xml or follow the commit changes when I push them to GitHub