2024-01-06, 19:50
(2024-01-06, 19:09)mikeSiLVO Wrote:Thanks..that brought back the title in list view but description under title is still not showing..(2024-01-06, 09:38)nordicguy Wrote: thank you so much. I really appreciate your hard work and creativity. I have done forking before but for my job programming and the way we do it is that after forking, editing and testing we merge the new changes. how would that work for your skin code? do I fork and keep my version and fork your version every time you make changes? or my changes are going to be merged after some point?
the reason I ask is that I am excited to add my edits to your repo, but at the same time I am not sure if they are stable. there are not errors or problem in my kodi due to these changes, but I haven't done any proper testing if you know what I mean. my testing is simply: 1- changes are appearing in the skin, 2- no errors in log, 3- kodi is applying these changes the way I expect
also my edits need some tweaking that I wasn't good able to do due to me not finding how or where I can make these small adjustments that will make the changes great instead of just good enough.
does that make sense
in any case, this sounds interesting so I will try to fork the repo and add my edits and hopefully since this is open source, you or someone else can look into my code and make it awesome.
in case you wonder, my edits are basically to support animated posters for movies and tv shows, support character poster for movies and tv shows, and support directors' thumbnails. I edited the code to add buttons in Silvo extra menu to toggle these on/off.
the adjustment that I couldn't figure out is how to make more views available in the director's thumbnail view. right now it is only icon view and it would work better with poster-like view dimension wise.
regards,
nordicguy
Not for a PR or merging in the skin. Just for keeping your changes.
You fork skin, create a new branch from whatever base you want to build on i.e. nexus/master (omega), name it nexus_nordic or whatever, commit your changes, then after any new updates from my side you just rebase skin on top of upstream branch with all the new changes.
I have used GitHub Desktop since SmartGit went paid, and I think it is easier than CLI.
(2024-01-06, 14:48)mariofenech Wrote: On all latest Aeon Nox Silvo..9.1.1,9.1.2
when I go to addon browser and install from repo in list view I can only see the icons of the repos no title and description..
anyone else?
(2024-01-06, 15:28)mariofenech Wrote: On all latest Aeon Nox Silvo..9.1.1,9.1.2
when I go to addon browser and install from repo in list view I can only see the icons of the repos no title and description..
anyone else?
Ok so it looks like there is something wrong with View_50_List.xml as replaced this with an old backup and works fine.
Fixed on Git. Will have to open PR to Kodi repo for this one