Thread Rating:
  • 0 Vote(s) - 0 Average
Solved Issue - Improve addon selection logic for settings
#1
It has always bugged me how we let users choose addons for a setting. The user gets to see a select dialog with all installed and enabled addons. If the user wants to take a look at all the available (i.e. not necessarily locally installed) addons he presses the "Get more..." button. But instead of showing all the addons available for installation in the same (or a new) select dialog he gets thrown out of the dialog and into the addon browser. Then when he has either downloaded an addon or done nothing he presses Back/Esc and lands back in the settings window but not in the previously open select dialog. Therefore the user has to activate the same setting again to get into the select dialog and choose the addon he wants (and may have previously installed). Last but not least when the user then goes out of the settings and into the addon browser he is thrown directly into the list that he was redirected to from the settings window. All of this seems very unideal to me.

Therefore I've started looking into extending CGUIWindowAddonBrowser::SelectAddonID() to automatically handle the "Get more..." functionality by opening another select dialog with all the addons available for installation. All of this works fine. What I'm unsure about and would like to get some feedback on is what to do if the user chooses a (or more) addon that isn't installed and needs to be downloaded.
  1. Should we prompt the user when closing the dialog whether he wants to download and install these addons?
  2. Should we show a modal progress dialog while downloading and installing the addons? We can't do it asynchronously because then the user would change the setting to an addon that isn't installed yet.
  3. Should we also support selecting disabled addons which would then automatically be enabled?
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#2
a clear NO to 1) - user already selected that he wants these addons, so why bugging him again with another dialog. Can't we instantly show the new selected addons in the settings dialog but sort of grey them out (or show a "please wait, installing" kind of overlay - like a progress bar/circle, ...) and only let him select the addons once they are downloaded?
Reply
#3
(2015-02-25, 11:04)da-anda Wrote: a clear NO to 1) - user already selected that he wants these addons, so why bugging him again with another dialog.
Yeah I agree that an additional prompt is unnecessary. I just asked because the current code provides a method that will always show a prompt before installing. But I can obviously adjust that.

(2015-02-25, 11:04)da-anda Wrote: Can't we instantly show the new selected addons in the settings dialog but sort of grey them out (or show a "please wait, installing" kind of overlay - like a progress bar/circle, ...) and only let him select the addons once they are downloaded?
How does that work? We don't want to download all available addons just in case the user decides to select one of them. We only want to download and install the addon(s) that the user has actually selected. By then the select dialog is already closed (because selecting an item results in closing the dialog).
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#4
(2015-02-25, 11:49)Montellese Wrote:
(2015-02-25, 11:04)da-anda Wrote: Can't we instantly show the new selected addons in the settings dialog but sort of grey them out (or show a "please wait, installing" kind of overlay - like a progress bar/circle, ...) and only let him select the addons once they are downloaded?
How does that work? We don't want to download all available addons just in case the user decides to select one of them. We only want to download and install the addon(s) that the user has actually selected. By then the select dialog is already closed (because selecting an item results in closing the dialog).
ah right - brainfart.
Reply



Improve addon selection logic for settings00