(2016-03-07, 12:44)marcelveldt Wrote: (2016-03-02, 21:48)Jayz2K Wrote: Hehe, more clear now, missed the skinsettings.xml part :p This is going to be a large file Really intuitive to work in this one.
Yeah, the ||PROMPTNUMERIC|| is what I need
Not sure the ||PROMPTSTRING|| makes sense here since AFAIK constants are numeric only ... ?
Also, while you're on skin settings, I'm using this great stuff a lot also to just build a select box and use the <onselect> action. But in this case, the dummy string name writes a useless skinstring. Should it be possible to add a ||SKIPSTRING|| so it writes nothing ?
https://github.com/marcelveldt/script.sk...e-argument
Many thanks.
Works fine on my side. I'm able to set a fully dynamic content in height / size directly in Windows. Really promising !
2 small things that are more fine tuning :
When using for example :
Code:
<setting id="TestSizeX" value="||PROMPTSTRING||" label="Width" condition="" icon="" description="" />
It launches DialogSelect first. Unneeded action IMO with ||PROMPTSTRING|| or ||PROMPTNUMERIC|| since DialogSelect then contains only 1 item. Much clearer to open DialogKeyboard or DialogNumeric direcly ? Or had you in mind to be able to set a constant with both NUMERIC and STRING ?
One thing I didn't thought about is the (-) minus. Since it's numeric settings, DialogNumeric has no negative sign so it's needed to use DialogKeyboard through ||PROMPTSTRING||. Works fine then but a bit weird. If you have an idea ...
One specific bug : escaping the DialogKeyboard or Numeric returns :
Code:
12:58:31 T:352 NOTICE: Skin Helper Service --> Kodi_Monitor: sender xbmc - method: Input.OnInputRequested - data: {"title":"Width","type":"keyboard","value":"emptyconstant"}
12:58:33 T:10912 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.TypeError'>
Error Contents: 'NoneType' object is not iterable
Traceback (most recent call last):
File "C:\Users\jerome.MTLSA\AppData\Roaming\Kodi\addons\script.skin.helper.service-master\default.py", line 304, in <module>
Main()
File "C:\Users\jerome.MTLSA\AppData\Roaming\Kodi\addons\script.skin.helper.service-master\default.py", line 70, in __init__
mainmodule.setSkinConstant(setting,windowHeader)
File "C:\Users\jerome.MTLSA\AppData\Roaming\Kodi\addons\script.skin.helper.service-master\resources\lib\MainModule.py", line 391, in setSkinConstant
value, label = setSkinSetting(setting=setting, windowHeader=windowHeader, sublevel="", valueOnly=allCurrentValues.get(setting,"emptyconstant"))
TypeError: 'NoneType' object is not iterable
-->End of Python script error report<--
12:58:33 T:352 NOTICE: Skin Helper Service --> Kodi_Monitor: sender xbmc - method: Input.OnInputFinished - data: null
Great job on this, huge things comin' !