2016-12-03, 17:27
(2016-12-02, 22:28)marcelveldt Wrote:Hi Marcel,(2016-12-02, 11:46)JohnyBee Wrote: Hi,
SkinHelper does not collect information for all music artists in my library.
SkinHelper takes only SkinHelper.ListItem.Art.Thumb and SkinHelper.ListItem.Art.FanArt.
Musical artists (for example, AC / DC, Alicia Keys, Ariana Grande, Avril Lavigne, Britney Spears, DEV ..........) have in their catalogs files banner.jpg, fanart.jpg, folder.jpg , logo.png and extrafanart folder with files xxxxxxxxx.jpg, but SkinHelper takes only SkinHelper.ListItem.Art.Thumb and SkinHelper.ListItem.Art.FanArt.
My settings for SkinHelper Music Artwork (EnableMusicArt, EnableExtendedArt, EnableExtraFanart) :
Enable online scraper (musicbrainz/audiodb/fanart/last.fm) - off
Lookup artwork in my music folders (library) - on
Lookup artwork in a custom folder (e.g. recordings folder) - off
I used the "Refresh (auto looup)" - but nothing changes
Maybe someone can help? What am I doing wrong?
Quote:It's working correctly on my setup with those exact same settings.Yes, I have the same structure of catalogs for music.
Do you have this folder structure for your music:
Artistname
-------------- artwork files
-------------- album name folder
---------------------------------------- album artwork (disc.png or folder.jpg)
---------------------------------------- songs
Also supported is an additional "disc" subfolder in the album.
Quote:Any errors in the logfile ?At logfile there is no errors for SkinHelper.
My test for following settings:
Lookup atrwork in a custom folder (e.g. recording folder) -ON
Download (missing) atwork to my custom folder - ON
Durring test for chosen artist I start function: Refresh (auto lookup)
I found problem at fuction get_customfolder_path (file: \addons\script.module.skin.helper.artutils\lib\helpers\musicartwork.py) (when I was analizing and testing your code (is huge )
You function always analizing only first artist folder at custom folder and give back empty string.
Your code:
PHP Code:
def get_customfolder_path(self, customfolder, foldername):
'''search recursively for a specific folder'''
if "\\" in customfolder:
delim = "\\"
else:
delim = "/"
dirs = xbmcvfs.listdir(customfolder)[0]
for strictness in [1, 0.95, 0.9, 0.8]:
for directory in dirs:
directory = directory.decode("utf-8")
curpath = os.path.join(customfolder, directory) + delim
match = SM(None, foldername.lower(), directory.lower()).ratio()
if match >= strictness:
return curpath
else:
return self.get_customfolder_path(curpath, foldername)
return ""
My code after testing works good (it found folder of artist, copy banner.jpg, fanar.jpg, folder.jpg, logo.jpg to this folder and save to properties of SkinHelper)
My code for testing:
PHP Code:
def get_customfolder_path(self, customfolder, foldername):
'''search recursively for a specific folder'''
if "\\" in customfolder:
delim = "\\"
else:
delim = "/"
dirs = xbmcvfs.listdir(customfolder)[0]
for strictness in [1, 0.95, 0.9, 0.8]:
for directory in dirs:
directory = directory.decode("utf-8")
curpath = os.path.join(customfolder, directory) + delim
match = SM(None, foldername.lower(), directory.lower()).ratio()
if match >= strictness:
return curpath
# else:
# return self.get_customfolder_path(curpath, foldername)
return ""
If you find a litte time, check it please.