• 1(current)
  • 2
  • 3
  • 4
  • 5
  • 12
  •   
[RELEASE] Reddit Viewer
#1
Hello,

This is an addon for viewing video and images on reddit. This is a fork of the Reddit.com addon by AddonscriptorDE and ranjani
I used this addon to learn python and kodi programming.

download Zip from github and install as zip file.
https://github.com/gedisony/plugin.video.reddit_viewer

No repo for now. I haven't figured out how to do one yet.




Supported media from sites:
YouTube (via youtube addon)
Vimeo (via vimeo addon)
DailyMotion (via dailymotion addon)
LiveLeak
Gfycat
Imgur
Redd.it
Vine
Vidme
Instagram
Blogspot
Reddit.com text posts
Tumblr
Streamable

Media from these sites supported via the youtube_dl addon:

funnyclips.me, engagemedia.org, videosift.com, break.com, veoh.com, viddler.com, schooltube.com, videos.sapo.pt, funnyordie.com

3movs.com, anysex.com, cliphunter.com, crocotube.com, cutegirlsgifs.info, daporn.com, drtuber.com, efukt.com, eroshare.com, faapy.com, fapality.com, faptube.xyz, gyazo.com, hclips.com, hotgoo.com, japan-whores.com, mofosex.com, mylust.com, onlypron.com, panapin.com, porndoe.com, porneq.com, pornfun.com, pornhd.com, pornhub.com, porntrex.com, pussy.com, redclip.xyz, redtube.com, secret.sex, sendvid.com, sex24open.com, sexfactor.com, shameless.com, smotri.com, spankbang.com, stickyxxx.com, submityourflicks.com, teenfucktory.com, thisvid.com, tnaflix.com, tube8.com, txxx.com, vporn.com, worldsex.com, xbabe.com, xbabe.com, xcafe.com, xcum.com, xhamster.com, xnxx.com, xtube.com, xvideos.com, xvids.us, xxxymovies.com, xxxyours.com, youporn.com, zedporn.com


also credit to LazyTv and the Big Picture addons. I used assets from these addons to show images
Reply
#2
Hello mac1202,


Quote:@gedisony if i can suggest you some improvement :
- when "show only comment that have a link" is set to yes, it would be nice that the number next to the show comment entry will only reflect the number of comment that have actually a link and not all the comments (Hope i make my point clear english isnt my first language).
- Having an accurate count of the comments will significantly slow down the addon. explanation: when you click on a subreddit like r/all, reddit will send info about the posts in that subreddit. the addon will parse that data and list the ones that are supported. reddit does not send info about comments during this phase. if the addon asks reddit about the comments for each of those posts it will take a long time for the user to see r/all.

Quote:- When using add to addon favorites a favorite is added in the addon_data directory but i cant see how to access them in the addon.
- this is from reddit_tv, i've never investigated this feature. i'll check into it but will probably remove.

Quote:- Possiblity to set a custom name for the subreddit. For example instead of displaying "music+listentothis/new" i can set a custom name like "New music".
- this is a good feature. I will add it in.

Quote:-Sometimes there is the same link posted in different subreddit as result they appears several time. For example in site:liveleak.com they could be 5-6 post with the same video an option to detect and hide dupes link would be awesome.
- not sure about this feature. i'll probably add it coz it is an interesting challenge but not sure if practical. which subreddit to prioritize? user might want to see different comments...
Reply
#3
(2016-06-21, 05:20)gedisony Wrote: Hello mac1202,
- Having an accurate count of the comments will significantly slow down the addon. explanation: when you click on a subreddit like r/all, reddit will send info about the posts in that subreddit. the addon will parse that data and list the ones that are supported. reddit does not send info about comments during this phase. if the addon asks reddit about the comments for each of those posts it will take a long time for the user to see r/all.

If it's possible making the addon ask reddit about comment for the selected post and only when the user press the key to display the context it shouldn't slow down the addon this way ?

(2016-06-21, 05:20)gedisony Wrote: - not sure about this feature. i'll probably add it coz it is an interesting challenge but not sure if practical. which subreddit to prioritize? user might want to see different comments...

Maybe the addon could display the one with the most upvote and add a visual indicator that dupes are available and add a context menu entry to display the dupes post.


This is just some suggestion I have absoultely no idea if it's technically possible Smile
Reply
#4
Quote:If it's possible making the addon ask reddit about comment for the selected post and only when the user press the key to display the context it shouldn't slow down the addon this way ?
I think it is possible but I'm not willing to spend the amount of effort needed to find out if it really is possible and to make it happen.
Once your addon presents a list of items to the user, it is done running. Kodi will run your addon(or a different one) again to handle things that the user selects.
To ask reddit about something after a list has been presented to the user involves having a separate component(service) of your addon that will run in the background, monitoring user activity, doing those requests and updating the presentation

Quote:Maybe the addon could display the one with the most upvote and add a visual indicator that dupes are available and add a context menu entry to display the dupes post.

This is just some suggestion I have absoultely no idea if it's technically possible Smile
Reply
#5
And just for information is there a difference between site: and /domain/ ?
It seems to do the same thing to me.
Reply
#6
"site:" and "/domain/" does the same thing.
They are just prefixes to tell the addon that any text after those characters are to be put after "https://www.reddit.com/domain/" when it queries reddit for posts.

Actually, anything before the ':' on "site:" doesn't matter.
You can call it "domain:" or "asdf:"
Reply
#7
Just a little glitch in the 2.6.8 version in the alias fonction. music+listentothis[cool sounds] is displayed as [cool sounds] instead of cool sounds.
Reply
#8
hello mac1202, I intended the alias to show up with brackets so that it won't be confused as a subreddit.

I'm going to skip the duplicates purge. I need to start testing for kodi17.
Reply
#9
Hi some feedback after using your addon on daily basis :

- moving the comment count from context menu to description was a nice idea
- I think that removing the "show only comments that have a link" option and replacing it with two context menu entry :
- show comment links
- show comments
will be more convenient.
- I hope you'll figure a way to make the picture viewer work in krypton like in version prior to 2.6.9 it was much more pleasant to use.
- Add a option to force the view of the image album. (they are displayed as list I personally prefer if i could set the view to thumbnail)
- Are you going to try to add the duplicates purge after the krypton testing ?
-In the download section of the option when i try to setup the quality/directory for youtube, vimeo or dailymotion it ask me to install the reddit.com addon.

and to finish a big thank you for bringing us so much improvement over the original reddit addon.
Reply
#10
I appreciate the encouraging words mac1202.

I like your idea about the context menu entries for comments. I'll have that in the next version.
I'll also add the option to pick the view id for displaying albums. afaik, view id's are skin specific so the user needs to know what view id correspond to 'thumbnails'

I do intend to improve the picture viewer. Much of the code for previous one was borrowed from a picture addon called "the big picture". I had a hard time getting it to work and when I discovered that it doesn't work on kodi 17 I decided to just use the simple picture viewer until I learn more.

I'm going to leave the duplicates alone.

The download section is a leftover from reddit.tv. I left it alone in case I'm going to add a download option in reddit viewer.

Thanks for testing mac!
Reply
#11
I'm getting an error trying to run this Sad
Quote:17:24:55 78914.585938 T:1963470848 ERROR: Control 50 in window 10025 has been asked to focus, but it can't
17:24:55 78915.265625 T:1502671776 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.ValueError'>
Error Contents: invalid literal for int() with base 10: ''
Traceback (most recent call last):
File "/storage/.kodi/addons/plugin.video.reddit_viewer-master/default.py", line 96, in <module>
searchSort = int(addon.getSetting("searchSort"))
ValueError: invalid literal for int() with base 10: ''
-->End of Python script error report<--
17:24:55 78915.507812 T:1963470848 ERROR: GetDirectory - Error getting plugin://plugin.video.reddit_viewer/
17:24:55 78915.507812 T:1963470848 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.reddit_viewer/) failed
Reply
#12
The error was because the addon was expecting values from the old setting that I've already removed.
I keep forgetting to test it on a fresh install system.

updated version should be up shortly.
Reply
#13
any chance 'login' option adding this pugin?
Reply
#14
SPMC 16.3.0 / Nvidia Shield TV (Android 6)

When entering the add-on:

Code:
17:51:37 T:1472149808   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.SyntaxError'>
                                            Error Contents: ('invalid syntax', ('/storage/emulated/0/Android/data/com.semperpax.spmc16/files/.spmc/addons/plugin.video.reddit_viewer/default.py', 352, 27, "        elif ext in {'gif', 'gifv', 'webm', 'mp4'}:\n"))
                                            SyntaxError: ('invalid syntax', ('/storage/emulated/0/Android/data/com.semperpax.spmc16/files/.spmc/addons/plugin.video.reddit_viewer/default.py', 352, 27, "        elif ext in {'gif', 'gifv', 'webm', 'mp4'}:\n"))
                                            -->End of Python script error report<--
17:51:37 T:1387370800   ERROR: static bool XFILE::CDirectory::GetDirectory(const CURL&, CFileItemList&, const XFILE::CDirectory::CHints&, bool) - Error getting plugin://plugin.video.reddit_viewer/
17:51:37 T:1387370800   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.reddit_viewer/) failed
Reply
#15
thanks for testing on android. fix should be up shortly.
Reply
  • 1(current)
  • 2
  • 3
  • 4
  • 5
  • 12
  •   



Logout Mark Read Team Forum Stats Members Help
[RELEASE] Reddit Viewer1
This forum uses Lukasz Tkacz MyBB addons.