Login at Kodi Home

**garbear** · 2017-08-02, 18:52

Vel0city and I came up with an idea for shader selection:

It's loosely based on the bookmarks manager:

Should the bookmarks manager be adapted to work for shaders? Or should it get a new dialog (possible used for other game dialogs, like selecting a scaling mode)

**Hitcher** · 2017-08-02, 23:34

Wouldn't DialogSelect suffice? It has an image and 2 lines of dialog for each selection.

**garbear** · (This post was last modified: 2017-08-03, 23:43 by garbear.)

I don't understand, DialogSelect looks nothing like VideoOSDBookmarks. Would you have to wrap the entire dialog in a visible statement, and then create an entirely new dialog for the screenshot I posted? How is this different than just adding a new dialog XML?

**Hitcher** · (This post was last modified: 2017-08-04, 07:35 by Hitcher.)

Well it's vertical and not horizontal I'll give you that but everything else should fit in correctly.

**garbear** · 2017-08-04, 07:50

This doesn't fit for a number of reasons. Primarily, we don't want the dialog to fully block the fullscreen game so that we can do live previews. We want the dialog to be as out of the way as possible, and the part that is visible should be translucent. We also don't need the buttons on the right side. And we need the icons to be much bigger, because differences between shaders can be minor.

**jurialmunkey** · 2017-08-04, 13:25

I think bookmarks manager should be adapted. If the buttons for bookmark manager in estuary are moved to the bottom, then all that would need to be added is a textbox for the description and some conditional visibility to switch between showing the buttons (bookmark manager) and showing the textbox (shaders).

User 55003 · 2017-08-04, 16:29

+1 for Hitchers proposal. A simple dialog select is totally adequate for this type of thing.
Who need a sad little panel of pictures and some worthless description.
Grow up!

**Hitcher** · (This post was last modified: 2017-08-04, 16:40 by Hitcher.)

(2017-08-04, 07:50)garbear Wrote: This doesn't fit for a number of reasons. Primarily, we don't want the dialog to fully block the fullscreen game so that we can do live previews. We want the dialog to be as out of the way as possible, and the part that is visible should be translucent. We also don't need the buttons on the right side. And we need the icons to be much bigger, because differences between shaders can be minor.

Ah, in that case a new dialog might be a better idea as bookmarks in other skins don't show much of the screen either.

**garbear** · (This post was last modified: 2017-08-04, 23:50 by garbear.)

(2017-08-04, 16:38)Hitcher Wrote: Ah, in that case a new dialog might be a better idea

That's my thinking. I'm doing my best to reuse existing skin parts, but gameplay is a fundamental paradigm shift from video playback. I'm not having much success in designing an OSD using elements that are built on an entirely different set of assumptions.

For Leia, I think I want to break fresh from existing elements. Only as far as the OSD goes though, because the only new paradigms being introduced are during gameplay. Here's how I envision the release notes for the next two versions looking:

SKIN CHANGES FOR LEIA:

New dialogs for the in-game OSD:

Root OSD, GameOSD.xml
Video filter and scaling selection, GameVideoSelect.xml
Player management, GamePlayers.xml
Saved game management, GameSaves.xml

SKIN CHANGES FOR M***:

Cheats, GameCheats.xml
Netplay, GameNetplay.xml

**garbear** · 2017-08-06, 00:55

Screenshots of the new root OSD and video selection dialogs has been posted in PR12639.

**Jeroen** · 2017-08-06, 01:24

Will there be some sort of demo add-on like there is for the PVR so that skinners can create these dialogs without having to do more blind skinning?

**garbear** · 2017-08-06, 01:39

This sounds like a good idea. What sort of demo did PVR do?

**Jeroen** · 2017-08-06, 02:20

(2017-08-06, 01:39)garbear Wrote: This sounds like a good idea. What sort of demo did PVR do?

Basically an add-on containing "fake' channel / programme data. Starting a channel would start a videostream, things like that.

A game add-on could maybe load a really simple built-in game or any other stub that would allow all the dialogs to be shown. It would really help a lot and lower the threshold for skinners to include retro player support.

**garbear** · 2017-08-06, 02:50

Good news, this already exists:

Download and install a nightly
Enable games with the cheat code
Find 2048 in the add-on manager and enable it
Play 2048

Since RetroPlayer was merged in December we've shipped with 2048 (a port of a popular web app). This should serve as a great demo add-on.

Unfortunately, keyboard input is currently broken, so you'll need a game controller to play. This will be fixed with the release of my Player Manager dialog in a few weeks. The menus are still accessible though.

**Jeroen** · 2017-08-06, 12:53

Oh, I had no idea Smile

Good to know, I'll try it out, cheers