[axlt2002]

 

• Hello @axlt2002
  

I have run the tests for v4.0.0 using v3.5.1 as the comparison.

The test consists of the following:

• Movies = 176
  
• TV Shows = 49
  
• Episodes = 1484
  
• Total = 1709
  

In my test database I deleted the following

• All IMDB ratings for Movies, TV Shows and Episodes
  
• All IMDB uniqueid's for TV Shows and Episodes
  

I ran the test on v3.5.1 first with the following results (from the log)

• Movies - 56 seconds
  
• TV Shows - 11 min 40 sec
  

A total of 1672 ratings were updated out of 1709 items
Looking at the log, I noticed that 37 Items were logged as Impossible To Update. Some were expected as they were my own modifications to the episode listing or TheTVDB show was locked and IMDB data could not be entered. There were 4 movies that had an Impossible to Update which I found curious as the IMDB ID existed for the movie. But checking the Export, the IMDB's were recorded for 3 of the four movies. The fourth movie had no rating at IMDB. Not sure how that happened.

I ran the test on v4.0.0 with the following results (using a stopwatch as not enough info in the log)

• Movies - 36 seconds
  
• TV Shows - 2 min 55 sec
  

A total of 1700 ratings were updated out of 1709 items
It was even able to update the ratings for the shows that had no IMDB ratings at TVDB.
A definite improvement.

Questions

• As most of the Debug Log information has been removed, is there some post-run report that can be generated to enable us to go back and fix entries with missing IMDB ID's?
  
• The add-on no longer adds the IMDB ID's for Episodes into the uniqueid table. Is there a reason you removed that function?
  

I'll keep the logs and Databases for a few days. If you need them, let me know.

Thanks for your efforts     

Good morning @Karellen and thanks a lot for your analysis! I think that the results confirm the improvements of version 4.0.0 with respect to 3.5.1! 

Of course it would be great the have the log file of the add-on to check the 9 entries that were not updated. Now all the debug information are reported in a separate file and no more in the kodi.log one (this because I wanted users to no more activate the logging function in Kodi); you can find the update.log file under userdata\addon_data\script.light.imdb.ratings.update. Now the log is always saved (there is no more an option in the settings for that) and from that you can retrieve also the timings of the start and finish of an update (no need to use stopwatch at all). So please post or send me the file so that I can check the update.

About your questions:

• Do you mean to have the possilbity to manually enter the missing IMDb IDs for episodes? As post-run report, please refer to the updat.log file I have just mentioned. 
  
• In general I think that the retrieve of IDs is a task for the meta-data providers add-ons (e.g. theTVDB or TMDB scrapers of Kodi) or media manager programs (e.g. Ember Media Manager) and not for an add-on that is targeting just to update votes. I guess that some work on the TMDB scraper for TV shows is currently ongoing and this could include the retrieve of the IMDb IDs. Of course, if users consider this feature foundamental, I can consider to reintroduce it.
  

Looking forward for your reply and thanks again for your participation! This kind of proactivity is exactly what gives me the energies and pleasure to continuing in the development of my add-on and make it available to the community!

Have a great day!