2023-12-09, 20:37
(2023-12-09, 01:57)mikeSiLVO Wrote: As for the INFO labels, I mentioned previously that I cannot get IsVideoExtras to be true.@mikeSiLVO How/where did you test this?
(2023-12-09, 01:57)mikeSiLVO Wrote: As for the INFO labels, I mentioned previously that I cannot get IsVideoExtras to be true.@mikeSiLVO How/where did you test this?
(2023-12-09, 18:11)XODIDOX Wrote:(2023-12-09, 17:51)jjd-uk Wrote: @XODIDOX something odd is happening with that branch. Initially I thought great it was now working as I got the correct Estuary defined colour for selected however after restarting Kodi it appears to have stopped working, and I'm back to white text for the selected item. Need to investigate further.
I tested it and it worked after restarting Kodi. May be your color modification lost after restarting. Are you sure the expected defaults.xml file is used after restarting Kodi?
(2023-12-09, 23:32)jjd-uk Wrote: Ping me once you get to creating a PR.
(2023-12-09, 20:37)XODIDOX Wrote: @mikeSiLVO How/where did you test this?
(2023-12-10, 04:02)mikeSiLVO Wrote: In the library views and in DialogVideoVersions.xml with an item that has extras. I'd expect it to be true when focused on or selecting an extra.Seems there is a misunderstanding for this label. The IsVideoExtras infoLabel is for the extras item itself, not for the parent movie item which will always be false. When in library, it's only applicable when you turned on the "Show video with multiple versions as folder" option, this container contains all movie versions and extras, you can use ListItem.IsVideoExtras to check if a specific one is extras or version. In the video version dialog, you should check the Container(51).ListItem, instead of ListItem which is the parent movie item.
Quote:Using the latest Kodi version (5e70594e) I also see that videoversionplay was changed to videoversionselect. Will that be the final window name?"videoversionselect" should be the final name.
(2023-12-10, 04:21)XODIDOX Wrote: Seems there is a misunderstanding for this label. The IsVideoExtras infoLabel is for the extras item itself, not for the parent movie item which will always be false. When in library, it's only applicable when you turned on the "Show video with multiple versions as folder" option, this container contains all movie versions and extras, you can use ListItem.IsVideoExtras to check if a specific one is extras or version. In the video version dialog, you should check the Container(51).ListItem, instead of ListItem which is the parent movie item.
(2023-12-10, 04:27)mikeSiLVO Wrote:(2023-12-10, 04:21)XODIDOX Wrote: Seems there is a misunderstanding for this label. The IsVideoExtras infoLabel is for the extras item itself, not for the parent movie item which will always be false. When in library, it's only applicable when you turned on the "Show video with multiple versions as folder" option, this container contains all movie versions and extras, you can use ListItem.IsVideoExtras to check if a specific one is extras or version. In the video version dialog, you should check the Container(51).ListItem, instead of ListItem which is the parent movie item.
I see, I did not think to check that. It is indeed true when the folder option is turned on.
(2023-12-10, 04:55)XODIDOX Wrote: As a general rule, checking mediatype is "videoversion" (a new media type) before checking IsVideoExtras.
(2023-12-12, 01:51)scott967 Wrote: It seems like the flow I would want is to select a movie title, open the movie info dialog and click version, to get the video version dialog and in there I can rename to add my version but I don't see any way in the dialog to add the movie version to the default? I have to back out of the dialogs and then open the context menu and drill down through the "manage" to get to "convert" but seems to have forgotten that I renamed it already as it asks for a name. Then I get a title list to select from. Is there some reason I can't do that from the video version dialog? In that dialog there is a "add version" button that opens the file browser -- not sure why I want that?