[XODIDOX]

It doesn't affect this at all, the whole video version feature is implemented separately, it doesn't alter the existing tables (except when changing the default video version, which just changes the file associated with a video item).

So separate tables and such in a new local database ?  If so, I presume the media importer would need to write to the new tables / db to share version info on the server with the local Kodi instance and with other sharing solutions how would folks share version info across multiple instances of Kodi ?  I am not trying to poke holes in anything being done here.  Just seeking to understand how it is implemented more under the covers.


Thanks,

Jeff

No, just separate tables in video db. When a new movie added to kodi, the db trigger will set a default version for this new movie. How the importer can modify the table for other versions is out of my control.

[XODIDOX]

suggestion

instead of making users conform to a set of versions that can be found, it would be better to allow the versions to be variable

use a format already in place on other platforms which will meet existing file naming for *most

the recommended naming is use anything after Year and before Resolution in the filename

f.e. Deadpool.2.2018.Super.Duper.Cut.2160p

the version would be 'Super Duper Cut'

this would allow users to make any version name text they wish and easily extracted by looking for text in the filename with a regex, limits would be programmatic length and invalid characters Only


just a recommendation

User can define whatever versions they want, there is button in UI to do that. The system defined list is just I want to reduce the user input from remote. Auto naming based on file name is only working for video extras currently, as the format for the versioning based on file name needs a through discussion before implementation.

The previous brief discussion:

Hi @Karellen, thanks for the comment. If we want to get this from file name, we need have a strict naming convention, which is not easyfor many users, IMHO.

Ideally, if we can force the movie naming in the following format, the versioning can be done automatically, though I personally do this for all my movies, I can imagine a lot of people don't do this:

{Name}.{Year}.{Version}.{Resolution}.{Source}.{VidoeCodec}.{AudioCodec}-{Addition}.{Extension}

For example:
Big.Buck.Bunny.2008.EXTENDED.1080p.WEB-DL.x264.MPGA-DDD.mkv

[izprtxqkft]

perfect

that would line up with what i already use for jellyfin, which i am sure is a copy from emby which is probably a copy of plex - https://jellyfin.org/docs/general/server...of-a-movie

the only addition would be in the absence of Resolution allow the remainder of the filename to be used

Big.Buck.Bunny.2008.EXTENDED.1080p.WEB-DL.x264.MPGA-DDD.mkv would be EXTENDED
as would Big.Buck.Bunny.2008.EXTENDED.mkv

the combination should yield good results

[jbinkley60]

No, just separate tables in video db. When a new movie added to kodi, the db trigger will set a default version for this new movie. How the importer can modify the table for other versions is out of my control.

Thanks. Separate tables in the video db is what I suspected, based upon the dialog I was seeing, and was my original question.

We can sort this out once the video database documentation is updated. I may also download a build and take a look at the changes.


Thanks,

Jeff

[ashlar]

The more I think about this, the more I feel that the big disconnect (for me) stems from the difference in presentation between Movie Versions and Movie Sets. When I select a Movie Set, I navigate "inside", where I see a list of movies that the set contains. I think my unconscious expectation, so far, was to have that for Movie Versions as well.

That's how I envisaged this feature would work as well. Maybe it would be clearer with some images.

Movies view showing that 'Alien' has different versions as indicated by the versions icon similar to how collections work -



And, in the same way as collections, clicking on 'Alien' shows all versions available -



And then clicking which version you want will play it (or whatever your default action is).

Yes, this is exactly what I meant as well. Thanks for showing it with pictures. @black_eagle this is what I meant.

[XODIDOX]

I pushed the latest update to the PR.

@ashlar / @black_eagle, now when you open a movie version in Library->Movie->Versions, the specified movie version will be played automatically without prompt.
@Hitcher, Version selection dialog will use poster automatically if it exists for a movie version, otherwise, the thumbnail will be used.

[ashlar]

I pushed the latest update to the PR.

@ashlar / @black_eagle, now when you open a movie version in Library->Movie->Versions, the specified movie version will be played automatically without prompt.
@Hitcher, Version selection dialog will use poster automatically if it exists for a movie version, otherwise, the thumbnail will be used.

If there's interest in widespread testing (or, at least, more widespread testing), I humbly suggest having updated builds whenever possible. I read about your modifications but I don't have a way of testing them. :-)

[XODIDOX]

@ashlar, the test build is not generated automatically at https://mirrors.kodi.tv/test-builds/, a Kodi team member has to do it manually I believe. @Hitcher, can you help to make a test build for the latest changes? I just pushed an update to fix a crash issue.

[jjd-uk]

@ashlar, the test build is not generated automatically at https://mirrors.kodi.tv/test-builds/, a Kodi team member has to do it manually I believe. @Hitcher, can you help to make a test build for the latest changes? I just pushed an update to fix a crash issue.

I saw that crash report and was waiting for your response before starting off a new set of test builds. I've just started the builds off now and progress can be checked at https://jenkins.kodi.tv/job/BuildMulti-All/2657/ once complete they'll automatically start appearing under https://mirrors.kodi.tv/test-builds/

[XODIDOX]

@ashlar, the test build is not generated automatically at https://mirrors.kodi.tv/test-builds/, a Kodi team member has to do it manually I believe. @Hitcher, can you help to make a test build for the latest changes? I just pushed an update to fix a crash issue.

I saw that crash report and was waiting for your response before starting off a new set of test builds. I've just started the builds off now and progress can be checked at https://jenkins.kodi.tv/job/BuildMulti-All/2657/ once complete they'll automatically start appearing under https://mirrors.kodi.tv/test-builds/

Thank you!

[ashlar]

@ashlar, the test build is not generated automatically at https://mirrors.kodi.tv/test-builds/, a Kodi team member has to do it manually I believe. @Hitcher, can you help to make a test build for the latest changes? I just pushed an update to fix a crash issue.

I saw that crash report and was waiting for your response before starting off a new set of test builds. I've just started the builds off now and progress can be checked at https://jenkins.kodi.tv/job/BuildMulti-All/2657/ once complete they'll automatically start appearing under https://mirrors.kodi.tv/test-builds/

Thanks a lot! I wish to stress that I wasn't complaining but having automated builds will probably streamline the testing process for all. Although, I have to say, I am quite surprised to be almost the only end-user chiming in for this.

[XODIDOX]

Updated the latest test builds.

[tmihai20]

Oh, wow. I was surprised to see the first post dated to 2018. This is indeed an extremely useful feature. I do have several versions of the same movie. Unfortunately I am using CoreElec and I did not find a way to test it. I would greatly appreciated to see it in an update.

[voochi]

For anyone has interest in this feature:

Please check the system defined version list at the end of this file, I tried my best to collect these and gave a widely used names, but I must miss something, or the naming is not very good for some. Please give feedback on these. Thanks!

https://github.com/xbmc/xbmc/pull/14972/...3663c01d79

Personally I would make the list shorter. I understand the purpose of the list is to save the user time (button-clicks). But a long list does the opposite, it takes many clicks to get to the one you want (or even to see what is available).

I would cut it to 20 or less. Use the following criteria:
a) how common is it
b) how much button presses does it save to include it in the system-defined list versus entering manually

for example
Extended Edition - a) Very common. b) has lots of letters so takes a long time to type via on-screen keyboard. Keep it.
VHS - a) Very uncommon. b) Only 3 letters so can be typed pretty quickly. Lose it

[ashlar]

Personally I would make the list shorter. I understand the purpose of the list is to save the user time (button-clicks). But a long list does the opposite, it takes many clicks to get to the one you want (or even to see what is available).

I would cut it to 20 or less. Use the following criteria:
a) how common is it
b) how much button presses does it save to include it in the system-defined list versus entering manually

for example
Extended Edition - a) Very common. b) has lots of letters so takes a long time to type via on-screen keyboard. Keep it.
VHS - a) Very uncommon. b) Only 3 letters so can be typed pretty quickly. Lose it

This is a good idea. My suggestion would be to have this file, editable, somewhere in the user directory. This way one could customize it to their needs.

I have thousands of movies. Once this feature is implemented officially I will need to go through all of them, to properly identify versions. My main usage will be for 4K/1080 versions. Others might have lots of Criterion versions, others different needs. If the list could be customizable, it would make it easier for big libraries to be adapted.

I am not saying to eliminate the list. It makes sense for new users and, generally, to give an idea of the possibilities. But if it could be customized, it would be nice. If this is too complex, ignore the suggestion. I don't want to overcomplicate things (the suggestion goes the opposite way, from an end-user point of view).