2020-01-26, 23:18
@-zero- thanks, will look into it.
For ssh it looks like an issue with the Python3 conversion.
For Samba, we have this which is just all kinds of wrong... we end up setting your password as
I'm thinking those two lines should be removed... and the call to
For ssh it looks like an issue with the Python3 conversion.
For Samba, we have this which is just all kinds of wrong... we end up setting your password as
1test2
even though you entered 1test2!
. Which is insane. I have no idea why this is necessary as the original commit doesn't mention it. I've tested a password of 1test2!
on LibreELEC (without the two lines that mangle the username and password) and that works fine with an Ubuntu Samba client. Maybe _some_ (old? broken?) Samba clients have limitations on username and password but if that's the reason then we shouldn't try and fix that in the server as it's a client issue (not our problem).I'm thinking those two lines should be removed... and the call to
smbpasswd
isn't particularly safe either (which may also be why the password is being mangled in the first place).