(2019-11-02, 00:36)fandangos Wrote: (2019-11-01, 23:59)te36 Wrote: (2019-10-31, 21:16)fandangos Wrote: I don't own a 3D display and even at the dolby cinema in Eindhoven I felt it wasn't that exciting maybe I'm part of the population that can't see 3D effects.
So, as far as I know MVC can't be integrated with Kodi 19.
It needs a Leia build.
You should PM Wanilton or visit xbmcbrasil. I believe you might find what you are looking for.
Thanks. See my other reply. Trying to compile mvc.v18 with your libbluray-1.1.2 resulted in the missing libbluray MVC patch.
Any pointers of how i would compile libbluray-1.1.2 on windows ? I could then try to see if i can rebase that libbluray patch i found.
This helped me with compiling libbluray by myself:
https://github.com/ShiftMediaProject/libbluray
Before the guy released his compiled version of 1.1.2 I used his sln visual studio file to compile it.
He also has all 3 dependencies compiled on his github.
Also just some heads up, the main advantage of libbluray 1.1.x is the support for uhd titles which doesn't have 3D.
I know your main goal is to have everything into a single place but you can have 2 kodi installs.
And since you seem to be getting into this, if you manage to bring full mvc support to Kodi 19 and feel like doing you can share your code and I'll add it to my fork.
And finally if you really dig into libbluray there are a few problems that with my limited knowledge I can't solve, for UHD BD the current chapter is always zero.
Chapter skipping doesn't work.
Seeking end up putting you on random time stamps.
Let us know or any development on your end.
I am the current owner of the MVC fork (kodi v19 & early v20
365120 (thread))
My current task is updating libbluray in kodi to 1.3.0 (
367093 (thread)) and this is how i found this thread... I was looking for the patch myself and indeed found it (
https://searchcode.com/file/116503483/pa...ort.patch/) but it is lacking a lot of functions related to reading and seeking in unorderly fashion.
for that i am changing how MVC's 2nd eye was treated in the blurayinputstream in conjunction with libbluray. Also, I am making libbluray compile along with kodi during build so it is easy to apply my small changes to libbluray.
I am basing all of my changes on paxxy's repository (
https://github.com/Paxxi/libbluray/tree/...libbluray) which is being used to build the kodi dependencies forward - also it has cmakelists.txt and it was easier to integrate as an externalproject to kodi.
My current patch for libbluray (over paxxy's kodi branch) is very small - still WIP and not finalized yet:
cpp:
From 8ed215e2dc564b9aefed28ea1e9baf1dd4e19699 Mon Sep 17 00:00:00 2001
From: Assaf Paz <damagedspline_ATT_gmail.com>
Date: Tue, 15 Feb 2022 23:06:36 +0200
Subject: [PATCH] Return functions required for 3D MVC identification
Signed-off-by: Assaf Paz <damagedspline_ATT_gmail.com>
---
CMakeLists.txt | 2 ++
src/libbluray/bluray.c | 7 +++++++
src/libbluray/bluray.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index f753cf67..ecec33bc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -260,6 +260,8 @@ install(FILES
${CMAKE_CURRENT_SOURCE_DIR}/src/libbluray/player_settings.h
${CMAKE_CURRENT_SOURCE_DIR}/src/util/log_control.h
${CMAKE_CURRENT_SOURCE_DIR}/src/libbluray/bdnav/meta_data.h
+ ${CMAKE_CURRENT_SOURCE_DIR}/src/libbluray/bdnav/mpls_data.h
+ ${CMAKE_CURRENT_SOURCE_DIR}/src/libbluray/bdnav/uo_mask_table.h
DESTINATION include/libbluray)
install(FILES
diff --git a/src/libbluray/bluray.c b/src/libbluray/bluray.c
index fcb3e6a3..e3398daf 100644
--- a/src/libbluray/bluray.c
+++ b/src/libbluray/bluray.c
@@ -3988,6 +3988,13 @@ struct mpls_pl *bd_read_mpls(const char *mpls_file)
return mpls_parse(mpls_file);
}
+struct mpls_pl *bd_get_title_mpls(BLURAY *bd)
+{
+ if (bd != NULL && bd->title != NULL && bd->title->pl != NULL)
+ return bd->title->pl;
+ return NULL;
+}
+
void bd_free_mpls(struct mpls_pl *pl)
{
mpls_free(&pl);
diff --git a/src/libbluray/bluray.h b/src/libbluray/bluray.h
index 01d46711..049a94d2 100644
--- a/src/libbluray/bluray.h
+++ b/src/libbluray/bluray.h
@@ -1079,6 +1079,7 @@ void bd_free_clpi(struct clpi_cl *cl);
struct mpls_pl;
+struct mpls_pl *bd_get_title_mpls(BLURAY *bd);
struct mpls_pl *bd_read_mpls(const char *mpls_file);
void bd_free_mpls(struct mpls_pl *);
--
2.30.0.windows.2
