2020-12-21, 12:24
@fandangos
Added some logging to DVDVideoCodecAndroidMediaCodec to see the actual values of the MK/MKBETAGS, as well as the value of m_hints.codec_tag:
Which generates this output:
Seems like the m_hints.codec_tag is always 0 for MKV containers, tested with SDR, HDR10 and DV HEVC.
For MP4/MOV containers m_hints.codec_tag seems to work. I get 1701344868(which corresponds to MKTAG('d','v','h','e'), 828929636(MKTAG('d','v','h','1'), and last, 828601960 for an ordinary HDR10 MP4.
So it seems like a method for getting the codec_tag from MKVs needs to be implemented.
Added some logging to DVDVideoCodecAndroidMediaCodec to see the actual values of the MK/MKBETAGS, as well as the value of m_hints.codec_tag:
Code:
CLog::Log(LOGINFO, "M_HINTS_CODEC_TAG: %d", m_hints.codec_tag);
CLog::Log(LOGINFO, "dvhe_b: %d", MKBETAG('d', 'v', 'h', 'e'));
CLog::Log(LOGINFO, "dvh1_b: %d", MKBETAG('d', 'v', 'h', '1'));
CLog::Log(LOGINFO, "dvcC_b: %d", MKBETAG('d', 'v', 'c', 'C'));
CLog::Log(LOGINFO, "dvvV_b: %d", MKBETAG('d', 'v', 'V', 'C'));
CLog::Log(LOGINFO, "dvhe: %d", MKTAG('d', 'v', 'h', 'e'));
CLog::Log(LOGINFO, "dvh1: %d", MKTAG('d', 'v', 'h', '1'));
CLog::Log(LOGINFO, "dvcC: %d", MKTAG('d', 'v', 'c', 'C'));
CLog::Log(LOGINFO, "dvvC: %d", MKTAG('d', 'v', 'v, 'C'));
Which generates this output:
Code:
INFO <general>: M_HINTS_CODEC_TAG: 0
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvhe_b: 1685481573
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvh1_b: 1685481521
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvcC_b: 1685480259
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvvV_b: 1685476931
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvhe: 1701344868
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvh1: 828929636
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvcC: 1130591844
2020-12-21 10:54:43.198 T:10961 INFO <general>: dvvC: 1131837028
Seems like the m_hints.codec_tag is always 0 for MKV containers, tested with SDR, HDR10 and DV HEVC.
For MP4/MOV containers m_hints.codec_tag seems to work. I get 1701344868(which corresponds to MKTAG('d','v','h','e'), 828929636(MKTAG('d','v','h','1'), and last, 828601960 for an ordinary HDR10 MP4.
So it seems like a method for getting the codec_tag from MKVs needs to be implemented.