2015-07-31, 04:48
Hey man, nice to see someone picked up the torch ! Thanks for the mention and glad if it helped you a bit
I feel a little stupid about not getting the VOD to work, seeing your solution. Your code is a lot cleaner than my mess, too :p
Here's some stuff I'd improve (If you don't get to them before uploading to Github, I may try to work on them and send you a pull request.)
Good luck and looking forward to the Github
I feel a little stupid about not getting the VOD to work, seeing your solution. Your code is a lot cleaner than my mess, too :p
Here's some stuff I'd improve (If you don't get to them before uploading to Github, I may try to work on them and send you a pull request.)
- Handle the empty login. It should raise a login prompt when the login field in the settings are empty. (Might need to build a dialog for this... Alternatively, you could prevent the script from running and throw a dialog asking to enter login info)
- Localize your strings. I was going to do this later on my addon. It's required in order to get on the official repositories and it's generally a nice thing to have for international users
- Get as much metadata off the JSON as you can. Love that you kept the TV view (Add-ons that only have a regular view and don't use any metadata drive me nuts :p ). I'd try to get the sorting working (To be able to sort the episodes by date) and add HD ClearLogos for the show and other optionnal stuff (Put them in a subdirectory of the add-on or try to get them off of Fanart.tv. Artwork Downloader actually works with the items in the addon, it just needs proper metadata to find the shows.)
Good luck and looking forward to the Github