2023-03-02, 00:18
(2023-03-01, 21:53)gaze Wrote:It's much easier for me to work outside of github, I often change some things and then it will happen that someone makes a PR and then I'll change something again... it's easier for me to implement someone's request.(2023-03-01, 08:51)matke Wrote:OK yeah I noticed that. Doing it this way may be putting off some people who would like to help/contribute. Just missing commit history is making development a bit hard at times.(2023-03-01, 08:21)gaze Wrote: BTW there are a couple of improvements I'm going to try to implement. Where can I make a PR?I update skin a little differently, I don't do it via github, I just release the final version on github. You can currently use the existing version, so I'll see what it's all about.
https://github.com/AchillesPunks/skin.titan.bingie.mod
I am looking at xml/IncludesMediaFlags.xml. Subtitle language is commented out from media flags. I re-enabled it and got it to work in videoplayer by replacing VideoPlayer.SubtitleLanguage with VideoPlayer.SubtitlesLanguage. Do you happen to know why this feature was removed from mediaflags?
Seeing selected subtitle language is a very important feature for me and this is one of the things I am interested in fixing / improving.
Also seeing the subtitle languages of a file is important but I know this is kind of hard to do currently - I was thinking of maybe trying to add a feature where you could configure a filter of important languages and show flags only for those that you are interested in. I can really read only two languages so I would like to show media flags only for these two languages. What do you think? Is this possible in xml?
I just care more about the netflix look, but I think I fixed it that for subtitle. If we mean the info bar in non bingie OSD view.
I don't know, I'll look when I have time. I'm dealing with some more important things now.