[mmortal03]

It should be a replacement but I forgot to do a release build.  I suggest trying the dll in the appropriate one from https://jenkins.kodi.tv/blue/organizatio.../artifacts  I changed all the stoi's to atoi for safety.

Totally untested though but that is how it was done in Leia

Martin

Frustrating, but that just seems to replace the error with "invalid stoul argument", so it looks like the issue is something deeper:

2021-01-17 12:17:02.596 T:11768   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:02.611 T:11768   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:02.619 T:11768   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServerVersion|2021-01-17 18:17:02|192.168.0.114"
2021-01-17 12:17:02.690 T:11768    INFO <general>: AddOnLog: pvr.wmc: Setting ServerWMC Server MAC Address to 'F4:6D:04:C2:82:AD'
2021-01-17 12:17:02.691 T:11768   DEBUG <general>: AddOnLog: pvr.wmc: wrote file C:\Users\DVR\AppData\Roaming\Kodi\userdata\addon_data\pvr.wmc\\ServerMACAddr.txt
2021-01-17 12:17:02.696 T:11768    INFO <general>: PVR Manager: Starting
2021-01-17 12:17:02.696 T:11088   DEBUG <general>: Thread PVRManager start, auto delete: false
2021-01-17 12:17:02.697 T:6652    DEBUG <general>: Thread PVRGUIProgressHandler start, auto delete: true
2021-01-17 12:17:02.698 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:02.699 T:10976   DEBUG <general>: ------ Window Init (DialogExtendedProgressBar.xml) ------
2021-01-17 12:17:02.720 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetChannels|False"
2021-01-17 12:17:03.184 T:8092    DEBUG <general>: CIRServerSuite::Connect: connecting to: 127.0.0.1:24000 ...
2021-01-17 12:17:05.224 T:8092    DEBUG <general>: CIRServerSuite::Connect: failed to connect
2021-01-17 12:17:05.225 T:8092     INFO <general>: CIRServerSuite:: Process: failed to connect to irss, will keep retrying every 5 seconds
2021-01-17 12:17:06.097 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:06.105 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetChannelGroups|False"
2021-01-17 12:17:06.124 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:06.131 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetChannelGroupMembers|False|Most Viewed"
2021-01-17 12:17:06.155 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:06.163 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetChannels|True"
2021-01-17 12:17:06.175 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:06.184 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetChannelGroups|True"
2021-01-17 12:17:06.201 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:06.211 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetChannelGroupMembers|True|Most Viewed"
2021-01-17 12:17:06.226 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetServiceStatus|6.1.0|windows"
2021-01-17 12:17:06.233 T:11088   DEBUG <general>: AddOnLog: pvr.wmc: Socket::GetVector> Send request "GetSeriesTimers"
2021-01-17 12:17:06.406 T:11088   DEBUG <general>: Thread Terminating with Exception: invalid stoul argument

[phunkyfish]

That’s progress. It’s a similar issue to stoi/ atoi so should just mean updating the PR.

[emveepee]

It is deeper for sure, a lot of assumptions where made during the conversion.  I can change several other std:tring conversions back to c string equivalents but the better choice is to use a supported addon.

Martin

[phunkyfish]

I’d say it’s only the std string functions. I remember when we did the C++ API work we stopped using the newer functions for this reason. It appears we did not undo this in pvr.wmc.

[mmortal03]

 but the better choice is to use a supported addon.

Yeah, since I upgraded to an HDHomeRun tuner last year, that may be a possibility now that I hadn't considered. At the moment, I don't have a need for guide data, and just want the ability to record a few shows on a fixed schedule, and stream them later through Kodi. I just googled around, and NextPVR could potentially work. I just tested its Kodi PVR add-on in Leia, and it seemed to work okay. I installed Matrix RC1 on top of that, and after add-on migration, it told me that the NextPVR client wasn't compatible, but maybe it just meant the Leia version of the add-on, as it still seems to be functioning. I'll have to test it some more on multiple devices.

I’d say it’s only the std string functions. I remember when we did the C++ API work we stopped using the newer functions for this reason. It appears we did not undo this in pvr.wmc.

 If it turns out to be as straightforward as changing all the std:: stoul instances to something that's comparable, that would be great.

[emveepee]

I just submitted that, had to get some cross-country skiing in.  Try one of these https://jenkins.kodi.tv/job/kodi-pvr/job...job/PR-91/   The diff needs to be reviewed a bit.  @krustyreturns perhaps you can look to see where you might return nullptr instead of numbers on the server.

Martin

[mmortal03]

I just submitted that, had to get some cross-country skiing in.  Try one of these https://jenkins.kodi.tv/job/kodi-pvr/job...job/PR-91/   The diff needs to be reviewed a bit.  @krustyreturns perhaps you can look to see where you might return nullptr instead of numbers on the server.

Martin

That may be the ticket! It at least seems to fix the problem on Windows x86-64, which is what I've tested so far. I will test it on Android later. At least this will allow further testing on Matrix from here. Thanks so much for your help on this!

[phunkyfish]

If it works on Android and @krustyreturns also has success I’ll review the PR.

[krustyreturns]

Don't wait for me I can't test it.  Thanks for fixing it (hopefully)!  lol...strings, why does it always have to be strings...

[emveepee]

Don't wait for me I can't test it.  Thanks for fixing it (hopefully)!  lol...strings, why does it always have to be strings...

I wasn't looking for a test, more confirmation that the pipe delimited string the server sends  could be "||" when the existing Matrix code would be looking for "|0|"  etc to help explain the crashing  I am also not t sure what would happen if the pipe character was ever included in text.

Martin

[krustyreturns]

Yes, its possible for the server to return "||" , i.e. a null string.  Also, pipe chars are filtered out of strings at the server.

[mmortal03]

If it works on Android and @krustyreturns also has success I’ll review the PR.

Looks good on Android. Thanks!

[phunkyfish]

Ok. If you want to add the addon.xml change too @emveepee I’ll review when I can.

Thanks for your help with this.

[emveepee]

Ok. If you want to add the addon.xml change too @emveepee I’ll review when I can.

I bumped it and the changelog with the second commit yesterday  It should be 6.1.1 now.

Martin

[hoopty1]

Hey Guys,

I suck at coding but I am willing to try and help. I am unfortunately stuck with a cablecard tuner and cannot get away from WMC.  Let me know what I can do.