Login at Kodi Home

**jogal**

Hi all,

A new build to test:

Version 7.0.0
Updated at 26-12-2020 (forked from Kodi 19 beta2 master).

Tonemap Kodi GUI to HDR PQ while in playback of HDR pass-through mode.
Fixes very bright OSD, subtitles, etc. and wrong color space (oversaturated).

https://github.com/thexai/xbmc/releases

Feedback will be appreciated Smile

Pr.Sinister · 2020-12-26, 17:01

(2020-12-26, 13:04)jogal Wrote: Hi all,

A new build to test:

Version 7.0.0
Updated at 26-12-2020 (forked from Kodi 19 beta2 master).

Tonemap Kodi GUI to HDR PQ while is playback in HDR passthrough mode.
Fixes extremely bright OSD / subtitles, etc.

https://github.com/thexai/xbmc/releases

Feedback will be appreciated

Damn you're efficient! You remind me of myself Wink

SDR overlays while HDR content is paused look good and rotating fanart screensaver is also looking good.

-Pr.

**Hitcher** · 2020-12-26, 17:23

You should PR this.

**PatK** · (This post was last modified: 2021-01-07, 19:26 by PatK.)

For those that are a little bewildered, or just don't understand, there's this wiki of Tone Mapping.

This article might be a worthy read, and this video regarding different tone mapping might be something to check-out.

**jogal** · 2020-12-26, 18:44

(2020-12-26, 17:23)Hitcher Wrote: You should PR this.

Done!

https://github.com/xbmc/xbmc/pull/18984

**Hitcher** · 2020-12-26, 22:30

Thanks for the contribution.

magician94 · 2020-12-26, 23:44

Thanks a lot for this great improvement!

It is much better than it was before.

If I understood the meaning of this change correctly, the kodi gui should look "exactly" the same in both sdr and hdr mode.

Here that is not the case however, the colors are more muted and white is greyish in hdr mode. I don't know how I can show it. Would print screens or something work?

I use an nuc8i3bek with an oled55c7v via denon avr 3400h. Image mode technicolor expert in hdr and sdr. Using a different image mode in the tv in hdr does have an effect but it never becomes the same as sdr.

For testing I disabled the automatic hdr switch and did it manually with F11 to be able to easily toggle the two.

At a certain point while toggling while playing video, the colors of kodi became very washed out.Also I managed to crash kodi with that a few times. At the moment I can not reproduce and don't have logs.

Will look into it more later, or maybe it does already ring a bell.

Any way, much better then before! Thanks for your efforts!

Pr.Sinister · 2020-12-27, 04:29

(2020-12-26, 23:44)magician94 Wrote: Here that is not the case however, the colors are more muted and white is greyish in hdr mode. I don't know how I can show it. Would print screens or something work?

I would look at this thread to see if maybe one of the other render methods look better for you: https://forum.kodi.tv/showthread.php?tid=358128

magician94 · (This post was last modified: 2020-12-27, 12:38 by magician94.)

I managed to reproduce one of the issues.

I played an HDR movie (https://we.tl/t-VeXLi867ue) in SDR mode (use display hdr off)
Paused
F11, switch to HDR (looks OK, but not exactly as SDR mode)
Wait until HDR shows and toast message is gone
F11 again to switch back to SDR. Now the colors are wrong (muted).

https://paste.kodi.tv/tixotomore.kodi

To keep the logs as clean as possible I created the screenshots in a separate run.

Screenshot one (11:23) is after step 2. Screenshot 2 (11:21) is after step 5

**jogal** · (This post was last modified: 2020-12-27, 13:35 by jogal.)

Well the OSD / GUI should look like screenshoot 1 in both HDR and SDR. I understand that this is so with normal operation (auto HDR switch / Use HDR display capabilities = ON).

In the second screenshoot you have managed to get playing SDR with the GUI still mapped to HDR (SDR => HDR). If you look at it, it looks dimmed just like when you watch an HDR video on an SDR screen with out tone mapping.

It is a small bug in the switching logic probably because the GUI status is not updated while the video is paused. Anyway I will look to see if it is possible to fix it easily.

magician94 · 2020-12-27, 13:41

The kodi GUI in HDR mode (either automatic or via F11) looks like something in between the two screenshots.

I don't know if that is a flaw in your code or if it is a setting or feature of my tv. Whichever of the two it is: it is a huge improvement over how it was before your changes and I am happy with it!

**jogal** · 2020-12-27, 14:12

Manual switching fixed Smile

https://github.com/thexai/xbmc/releases

**jogal** · (This post was last modified: 2020-12-27, 14:25 by jogal.)

(2020-12-26, 23:44)magician94 Wrote: If I understood the meaning of this change correctly, the kodi gui should look "exactly" the same in both sdr and hdr mode.

This is is only on a theoretical level. Note that TVs use different (separate) internal presets, calibrations and algorithms for HDR / SDR and user settings may also be different.

In fact, the image would not look exactly the same on two different HDR TVs if you saw them side by side.

Precisely the article that PatK mentioned on #4 talks about this:

Why HDR Looks Too Dark on Your TV, and How to Fix It

I would add another point: if the HDR image is very bright, the Kodi GUI will appear less bright than it is (our brain tricks us because it always works by comparison).

**ashlar** · 2020-12-27, 15:36

Jogal for president! :-D

Thanks for all your work.

ciukacz · 2020-12-27, 16:10

working great! one minor nitpick after this PR gets into master: can you add a setting for white point? currently it's hardcoded at 100 nits, right?