[Fuchs2468]

I'm currently working on my skin update, normally I work on my PC with a monitor resolution of 1920 x 1080 or on a 4k UHD TV, but at the moment I'm working on a laptop with a resolution of 1600 x 900.

I noticed that 1440p youtube videos are labeled as 4K videos by kodi. This is definitely not correct.

I found this
https://github.com/xbmc/xbmc/blob/2307e4...#L580-L607

I think these lines should be revised.

"return" should only show "720,1080,1440 or 2160" as an example (not 4K or 8K as currently defined).
The video resolution type can then be defined via the skin (example: SD,HD,FHD,QHD,2K,4K).
1440p should be added as a video resolution (format name: QHD, WQHD or also referred to as 2k).
It is a common format on youtube.

[jurialmunkey]

You should report the bug/issue on github
https://github.com/xbmc/xbmc/issues

This subforum is mostly only frequented by skinners and it's unlikely that many will have C++ skills to submit a PR themselves.
You'll get more visibility with devs who have C++ skills by submitting a github issue.

Definitely agree with you though, the logic in those resolution conditions is not great, especially since QHD is quite a common format at the moment.

IMHO, the label should simply return the vertical resolution as an integer. Then a skin can implement a simple variable using Integer.IsLess() conditions to get the same result. Far more accurate and far more adaptable.

I think this must be a holdover from the days before skin variables existed and so it was necessary for displaying resolution flag images. Really seems unnecessary now.

[Chillbo]

IMHO the resolution should be returned as two separate info labels for skinners to be able to do with the proper information what they choose to... Pre-selecting what is offered doesn't really help much.

@graham-h has something in the pipeline to offer upstream for v21, I've heard 😇