2021-07-14, 02:38
I'm not going to go parsing skin files in a hurry, that's for sure, and it really shouldn't be necessary. And it's not really about where they are stored either, ultimately. Already there or not, the patcher should copy the patched skin files if it can. It only stops if the backups don't exist and it can't make them. And then tells you that.
I.e. even if new backups are not being made because the backup files already exist (and you're talking about this error happening when OSMC itself updates, right, not skin updates as such yeah? - I will confirm the expected flow there with the Kodi devs anyway...)...you can see here:
https://github.com/bossanova808/reposito...er.py#L105
...that the backup bit is then just skipped...and it proceeds on to copying the skin files anyway (it only stops if the backups don't exist, and it can't make backups...as it should). It should still therefore copy the skin files if that is possible.
To be honest, you should only need to do an update IF the skin itself has actually changed/been updated. Just because OSMC has been updated doesn't mean Estuary has. And even if it does do this (update the skin 'outside of band' and not using the Kodi process - maybe they patch in some OSMC specific stuff??) - then as long as the file permissions are ok at the end of that, the patcher should still work anyway.
All of which brings us full circle to the need for a debug log...because that will log the actual error that occurs when the copy is attempted - https://github.com/bossanova808/reposito...er.py#L158
I.e. even if new backups are not being made because the backup files already exist (and you're talking about this error happening when OSMC itself updates, right, not skin updates as such yeah? - I will confirm the expected flow there with the Kodi devs anyway...)...you can see here:
https://github.com/bossanova808/reposito...er.py#L105
...that the backup bit is then just skipped...and it proceeds on to copying the skin files anyway (it only stops if the backups don't exist, and it can't make backups...as it should). It should still therefore copy the skin files if that is possible.
To be honest, you should only need to do an update IF the skin itself has actually changed/been updated. Just because OSMC has been updated doesn't mean Estuary has. And even if it does do this (update the skin 'outside of band' and not using the Kodi process - maybe they patch in some OSMC specific stuff??) - then as long as the file permissions are ok at the end of that, the patcher should still work anyway.
All of which brings us full circle to the need for a debug log...because that will log the actual error that occurs when the copy is attempted - https://github.com/bossanova808/reposito...er.py#L158
