[fritsch]

That is a good idea and fully enough. With a low pass frequency dividing filter - something more would be possible :-).

[jjd-uk]

So we make this a setting for music and mix it like Jonathan has suggested?
Thus, a normal 2 channel piece of music gets the Left and Right channels duplicated into the Back left + Back right, and mixed into the Center + LFE.

Personally I'd fine with that but it's no longer a big deal for me as most of my music listening is done in the main room, it's certainly been an often requested feature for music particularly from people who like myself migrated from the xbox.

There possibly might be some complaints about it's removal for video for anyone using analog outs, for anyone using digital SPDIF/HDMI then personally I think Pro-Logic processing on the AVR is better solution.

[da-anda]

don't forget about music videos, so it's not paplayer only. I'd say, if one enables stereo upmix, do it for every non-passthrou stereo source (JM style) and don't add unnecessary complexity to it. If really demanded by many we can still make it depending on source or add it once we have a DSP/EQ and make it more intelligent (e.g. for TV only move sound available in left and right to center and not just everything).

[FernetMenta]

I am not a fan of just moving quick hacks forward. The current implementation may be ok for music but is crap for video. Either we do it at least in a half decent way or we skip it.
The setting is still alive for videos in the audio dialog of dvdplayer. We can pass this as an option to AE when creating a stream.

[Ace]

I'm not sure if this was reported before: switching (in my case) from analog to optical and back to analog crashes the engine.
Here'e the log: http://xbmclogs.com/show.php?id=46852

What exactly did you do? Your log does not even state that you entered the audio settings page.

Nothing special, line 923:

Code:

18:41:15 T:9224   DEBUG: CApplication::ExecuteXBMCAction : Translating ActivateWindow(OSDAudioSettings)

[da-anda]

here is a recent windows testbuild for willing testers: http://mirrors.xbmc.org/test-builds/win3...9-HEAD.exe

@FernetMenta - is it possible atm to f.e. only mix audio information available in both (left/right) streams to the center speaker?

[FernetMenta]

I'm not sure if this was reported before: switching (in my case) from analog to optical and back to analog crashes the engine.
Here'e the log: http://xbmclogs.com/show.php?id=46852

What exactly did you do? Your log does not even state that you entered the audio settings page.

Nothing special, line 923:

Code:

18:41:15 T:9224   DEBUG: CApplication::ExecuteXBMCAction : Translating ActivateWindow(OSDAudioSettings)

I tried this with SoftAE and it made my system hang. This setting needs to be renamed to PCM/passthrough

[FernetMenta]

here is a recent windows testbuild for willing testers: http://mirrors.xbmc.org/test-builds/win3...9-HEAD.exe

@FernetMenta - is it possible atm to f.e. only mix audio information available in both (left/right) streams to the center speaker?

what do you mean? we have so separate streams per channel. in order to get this right for video we would need to analyze frequencies and decide what to mix upon this information.

[Ace]

Completely? I "just" get a terrible sound and stuttering video, but I can navigate thorough xbmc normaly.

[da-anda]

@FernetMenta - is it possible atm to f.e. only mix audio information available in both (left/right) streams to the center speaker?

what do you mean? we have so separate streams per channel. in order to get this right for video we would need to analyze frequencies and decide what to mix upon this information.

yep, something like that. That's why I wrote probably add it once we have DSP etc. - but it's up to you.

[jjd-uk]

Good news is that I can now confirmed the LPCM 7.1 channel mapping problem is fixed.

Bad news is I've confirmed I have an issue with music playback having distortions/crackles (tracks are fine in SoftAE), could this be clipping? I'm currently investigating and will post debug logs and more info once done.

The music files are just 2 channel mp3 so not anything exotic.

[FernetMenta]

Completely? I "just" get a terrible sound and stuttering video, but I can navigate thorough xbmc normaly.

yes, SoftAE completely froze. should be fixed now in the PR

[FernetMenta]

Good news is that I can now confirmed the LPCM 7.1 channel mapping problem is fixed.

Bad news is I've confirmed I have an issue with music playback having distortions/crackles (tracks are fine in SoftAE), could this be clipping? I'm currently investigating and will post debug logs and more info once done.

The music files are just 2 channel mp3 so not anything exotic.

check the comments on this commit: https://github.com/xbmc/xbmc/commit/e4fc...2ccb931889
i would be grateful if you could do the remaining work. should be clamped in this function.

[fritsch]

After the 5.1 to Ac3 audio was fixed. I looked a bit into the 5.1 96khz flac via LPCM, that my AVR did not get right and in deed.

When I change speakers to 4.0 - i can hear all speakers. So I thought, that must be a bandwidth problem. On linux der is not SNE24 format. All the 24 get into SNE32 something. So if one calcs the overhead, it is for 6 channels exact two channels too much:

6*32 - 6 * 24 = 6*(32-24) = 2* 24

So - two ways to fix that:
a) check for channels > 4 and check the bitrate and choose 48khz (is trivial and here: https://github.com/fritsch/xbmc/commit/7...892a4238cd)
b) check if number of bits of sink format equals number of bits input format, if yes - keep all as is - if not - downsample.

Btw. the windows guys with SNE24 should have it working.

PS: A theory is as long invalid until it is proofed correct.

[FernetMenta]

are you crying for another setting?
hd audio bitstreaming uses 8 channels at 192khz. i don't think this is a HDMI bandwidth problem.