Posts: 3,575
Joined: Jan 2011
Reputation:
382
pkscout
Team-Kodi Member
Posts: 3,575
2014-05-23, 22:27
(This post was last modified: 2014-05-23, 22:27 by pkscout.)
Mahalo for the heads up. I'll check on why the wiki page is out of date. That information is suppose to be auto-generated, and I see that other add-ons are listed for both repos.
Posts: 979
Joined: Sep 2013
2014-05-25, 16:39
(This post was last modified: 2014-05-25, 16:51 by robwebset.)
Hi pkscuot,
Thanks for your work with Artist Slideshow - I have just made use of it in the
Sonos addon, looks really nice!
I have read through the wiki, and have made use of:
- Images of the artist (Core slideshow)
- Artist Biography
- Other Albums from the same artist
Was I missing anything else juicy that it supplies and I should add support for?
I do have some questions/requests - I hope you don't mind?
- Would it be possible to have a setting in Artist Slideshow to enable/disable the logging (only when XBMC logging is on) as now I have it installed, if I enable debugging on one of the other addons to see what is happening - I automatically get Artist Slideshow logging as well (can make the log file a little harder to read).
- As I have launched it from another addon - I was wondering if there is an interface on Artist Slideshow that I can call to "pre-cache" an artist's information (It would help reduce the delay in data loading for the Sonos addon) - especially when the Sonos Addon can see what is coming up next in the playlist.
Thanks again for the addon!
Rob
Posts: 979
Joined: Sep 2013
Maybe for request 2, something as simple as some more properties on the window:
"NEXTARTIST", "NEXTTITLE", "NEXTALBUM", "NEXTMBID"
Thoughts?
Rob
Posts: 979
Joined: Sep 2013
Hi pkscuot,
Item 1 is really an "etiquette" type of request - it will generally make it easier for other addon developers when they are trying to track down their own issues on other peoples installs.
I spotted this with TvTunes - which (if we didn't have an options in TvTunes settings) would pollute the log quite heavily if some-one had it on their system, and they were trying to generate debug for a different add-ons problem.
Hope you understand.
Thanks
Rob
Posts: 979
Joined: Sep 2013
(2014-05-25, 19:02)pkscuot Wrote: #2 really isn't a viable option. AS is designed at it's core to act on the current song and wait for a change to do something new. It would require some pretty substantial changes to do anything else. The majority of the delays come the very first time you listen to an artist. After that it's pretty quick to show existing artwork.
Yes, I only had a quick look at the code, but it looks like the arguments to several methods would need to be parameterised rather that reading from class variables in methods such as _use_correct_artwork and _start_download, then different arguments could be passed to them from the loop in __init__
Rob
Posts: 979
Joined: Sep 2013
2014-05-29, 06:37
(This post was last modified: 2014-05-29, 06:38 by robwebset.)
(2014-05-29, 02:55)pkscuot Wrote: NEW BETA RELEASE
v.1.6.5.2
- added option to suppress all logging
https://github.com/pkscout/script.artist...master.zip
This is a really minor release that adds the option to suppress all logging. Because I had to add a setting, it'll be awhile before all the translations catch up. So this probably won't get pushed into the repo for quite a bit. But if you really need to have the option to suppress logging, you can use this beta.
Thanks for adding that pkscuot.
Please can I suggest that logging is suppressed by default, otherwise every other addon will need to ask for it to be turned off when their logging is turned on.
For example, I want to request that some-one supplies a debug log for TvTunes, I have to ask:
1) Enable system logging
2) Go to the Artist Slideshow addon (if installed) - disable logging
3) Go to TvTunes and enable logging
Similarly for Video Extras:
1) Enable system logging
2) Go to the Artist Slideshow addon (if installed) - disable logging
3) Go to VideoExtras and enable logging
Where there shouldn't really be a need to refer to a different addon when wanting logging.
Hope that makes sense.
Thanks
Rob
Posts: 3,575
Joined: Jan 2011
Reputation:
382
pkscout
Team-Kodi Member
Posts: 3,575
I've done all I'm going to do on the logging. I often wade through debug logs that have lots of addon data and manage. Disabling logging by default would mean I have to tell people to go do two things just to get a log that's helpful (turn on debug logging *and* enable logging in the addon).