2016-01-17, 17:00
Log as requested:
http://xbmclogs.com/pgwz5svr9
If there's anything else you require me to do, please let me know.
http://xbmclogs.com/pgwz5svr9
If there's anything else you require me to do, please let me know.
(2016-01-17, 02:35)Lappskij Wrote: Could there be a bug preventing the addon from reading from file correctly when using the "-" sep?
(2016-01-17, 02:35)Lappskij Wrote: Also, since you have a option for removing Chinese text why not also include Korean etc. since you now seems to be using Korean scraper sites?
(2016-01-17, 17:00)CrankyCraig Wrote: Log as requested:
http://xbmclogs.com/pgwz5svr9
If there's anything else you require me to do, please let me know.
(2016-01-17, 17:14)ronie Wrote:(2016-01-17, 17:00)CrankyCraig Wrote: Log as requested:
http://xbmclogs.com/pgwz5svr9
If there's anything else you require me to do, please let me know.
thx. since i don't have a plexbmc setup, it a bit more difficult to troubleshoot.
i've added some additional logging to the addon to be able to see what going on.
could you get me another debug log with this version?
(also enable logging in the cu lrc addon settings!)
script.cu.lrclyrics-3.2.2.zip
(2016-01-17, 18:05)CrankyCraig Wrote: Absolutely. I've used a different machine with a new and updated Kodi install and very few extras, which will hopefully prove a bit simpler to understand.
http://xbmclogs.com/pclebenvd
Again, if there's anything else I can do Ronie, just let me know.
(2016-01-17, 17:01)ronie Wrote:(2016-01-17, 02:35)Lappskij Wrote: Could there be a bug preventing the addon from reading from file correctly when using the "-" sep?
yup, indeed a bug, thanx for the heads-up!
(2016-01-17, 02:35)Lappskij Wrote: Also, since you have a option for removing Chinese text why not also include Korean etc. since you now seems to be using Korean scraper sites?
good idea, i've added it;
mind testing if this fixes both issues?
script.cu.lrclyrics-4.1.7.zip
(2016-01-18, 05:06)Lappskij Wrote:(2016-01-17, 17:01)ronie Wrote:(2016-01-17, 02:35)Lappskij Wrote: Could there be a bug preventing the addon from reading from file correctly when using the "-" sep?
yup, indeed a bug, thanx for the heads-up!
(2016-01-17, 02:35)Lappskij Wrote: Also, since you have a option for removing Chinese text why not also include Korean etc. since you now seems to be using Korean scraper sites?
good idea, i've added it;
mind testing if this fixes both issues?
script.cu.lrclyrics-4.1.7.zip
Brilliant!!!
Thanks. That took care of the seperator bug and I think also gained more accuracy in the search ;-)
So, 1 down - 1 to go!!!!
Unfortunately still not working 100% since there's still some song lyrics that are just totally wrong...
Been trying both variations (tag and file search), but same results. Starting to wonder if the problem lies with the scrapers and the persons posting lyrics with poor information or corrupt tagging.
Any possibility to get a more strict policy on the search? Because I can see that lyrics are being downloaded that have wrong title or artist or missing all in all... Would love to have an "Artist & Title" zero variation tolerance. If no hit on both criterias, then DO NOT download ....
(Do understand that using album in the search probably won't work with many scrapers, but one can dream...)
Any bright ideas?
And once againg thanks for your brilliant addon and the effort you are showing.
(2016-01-18, 10:37)CrankyCraig Wrote:(2016-01-18, 05:06)Lappskij Wrote:(2016-01-17, 17:01)ronie Wrote: yup, indeed a bug, thanx for the heads-up!
good idea, i've added it;
mind testing if this fixes both issues?
script.cu.lrclyrics-4.1.7.zip
Brilliant!!!
Thanks. That took care of the seperator bug and I think also gained more accuracy in the search ;-)
So, 1 down - 1 to go!!!!
Unfortunately still not working 100% since there's still some song lyrics that are just totally wrong...
Been trying both variations (tag and file search), but same results. Starting to wonder if the problem lies with the scrapers and the persons posting lyrics with poor information or corrupt tagging.
Any possibility to get a more strict policy on the search? Because I can see that lyrics are being downloaded that have wrong title or artist or missing all in all... Would love to have an "Artist & Title" zero variation tolerance. If no hit on both criterias, then DO NOT download ....
(Do understand that using album in the search probably won't work with many scrapers, but one can dream...)
Any bright ideas?
And once againg thanks for your brilliant addon and the effort you are showing.
You may well have tried this, but just in case, have you tried deleting the lyrics folder contents in Kodi app data? I had similar symptoms to what you describe, with the incorrect lyrics saved in there while I was experimenting with the add-on, and as it looks there for stored lyrics first it kept finding them instead of searching for the correct ones.
Quote:Hi CrankyCraig,
Yeah, know what you mean, but I actually renamed the old CU LRC folder and wanted to start from scratch saving the lyrics with my songs in a subfolder for every album so; Full control ;-) I now only use the old location in the addon folder as an empty test folder... and never more than one target location at the time. But thanks a lot for taking interest !
(2016-01-18, 05:06)Lappskij Wrote: Any possibility to get a more strict policy on the search? Because I can see that lyrics are being downloaded that have wrong title or artist or missing all in all... Would love to have an "Artist & Title" zero variation tolerance. If no hit on both criterias, then DO NOT download ....
(Do understand that using album in the search probably won't work with many scrapers, but one can dream...)
Any bright ideas?
(2016-01-18, 12:48)CrankyCraig Wrote:Quote:Hi CrankyCraig,
Yeah, know what you mean, but I actually renamed the old CU LRC folder and wanted to start from scratch saving the lyrics with my songs in a subfolder for every album so; Full control ;-) I now only use the old location in the addon folder as an empty test folder... and never more than one target location at the time. But thanks a lot for taking interest !
I've noticed the same thing with a small number of lyrics, and like yourself my suspicion is that it's because the lyrics themselves contain inaccurate tag information. I plan on playing about with the different scrapers, in the hope that some are more accurate than others, but my feeling is that they'll all probably contain both good and bad lyric files.
If I learn anything, I'll post back.
(2016-01-18, 13:20)ronie Wrote:(2016-01-18, 05:06)Lappskij Wrote: Any possibility to get a more strict policy on the search? Because I can see that lyrics are being downloaded that have wrong title or artist or missing all in all... Would love to have an "Artist & Title" zero variation tolerance. If no hit on both criterias, then DO NOT download ....
(Do understand that using album in the search probably won't work with many scrapers, but one can dream...)
Any bright ideas?
if you have one or more examples of song titles which return incorrect lyrics, i'll look into it.