Posts: 3,660
Joined: Feb 2008
Reputation:
93
Jeroen
Team-Kodi Member
Posts: 3,660
2017-05-11, 18:16
(This post was last modified: 2017-05-11, 18:28 by Jeroen.)
I am developing a new skin, which is currently in a private beta stage. One of the testers have submitted a bug report where switching from my skin to Estuary crashes Kodi (on Windows 10). I can reproduce the problem 100% (on OSX).
So far it seems to happen exclusively when switching to Estuary. I am at a loss as to what could be causing it. I can of course submit debug logs and crash reports, but as it seems to be skin related, what would be the best place? Here, trac, Git?
Cheers
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
2017-05-15, 12:44
(This post was last modified: 2017-05-15, 12:45 by BigNoid.)
I would start by eliminating any addons from the equation. Start with a fresh install, only the skin without dependencies. See if it still crashes then when switching to Estuary. It seems hard to believe its skin code from your skin as that's unloaded already when it crashes.
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
I could take a look if you want. Just need a link to the skin than.
Posts: 3,660
Joined: Feb 2008
Reputation:
93
Jeroen
Team-Kodi Member
Posts: 3,660
2017-05-15, 21:30
(This post was last modified: 2017-05-15, 21:30 by Jeroen.)
Thanks, sent you an invitation on Github (it's currently on a private repo)
Posts: 3,919
Joined: Jul 2010
Reputation:
154
BigNoid
Team-Kodi Member
Posts: 3,919
2017-05-15, 22:26
(This post was last modified: 2017-05-15, 22:30 by BigNoid.)
Okay, it's because Estuary uses a custom window with id 1100 as window. If that's changed to type="dialog" or if you remove 1100 from your skin, the crash is gone.
EDIT:
The crash is also gone when you only remove the visibility line in 1100 on ln 3. I bet the custom windows are kept in memory and it can't handle the change from window type to dialog type.
Posts: 3,660
Joined: Feb 2008
Reputation:
93
Jeroen
Team-Kodi Member
Posts: 3,660
2017-05-15, 22:35
(This post was last modified: 2017-05-16, 06:09 by Jeroen.)
Awesome that you were able to pinpoint the cause, it will be no problem to just use a different window ID. Huge thanks !
Posts: 708
Joined: Jul 2012
Reputation:
30
xhaggi
Team-Kodi Developer
Posts: 708
This is fixed in Kodi master (v18 nightly builds).