[Gerritenpietersen]

I donated to tinymediamanager to be able to use rotten tomatoes ratings which i find far superior to imdb.

Sadly the implementation seems broken if u use omdbapi or universal movie scraper both will add the rating and counted together so for instance 12 years a slave will have a rating of 95347 (it's at rotten tomatoes 95% 347 counted)

Also the audience score is not working at all, both (the audience and critic rating) works correctly in KODI

It's a shame as i need a mass updater for my movie collection which can replace the imdb ratings in my nfo's.

[mlaggner]

sorry, but I need more information to help you.

a) which scraper to you use?
b) which tmm version to you use?
c) do you have any logs where I can search for the error? (use https://paste.kodi.tv/ to post the logs)

btw: rotten tomates closed their API from being used for free (even for open source projects) - so I wonder where you get the data from.. (omdbapi?)

[Gerritenpietersen]

sorry, but I need more information to help you.

a) which scraper to you use?
b) which tmm version to you use?
c) do you have any logs where I can search for the error? (use https://paste.kodi.tv/ to post the logs)

btw: rotten tomates closed their API from being used for free (even for open source projects) - so I wonder where you get the data from.. (omdbapi?)

hello as requested the answers for troubleshooting.
a. Scraper is kodi universal movie scraper 4.1.11
b. tmm version is 2.9.14
c. https://paste.kodi.tv/egayeperop.kodi

The resulting nfo https://paste.kodi.tv/hajaxevinu.kodi

I have no idea about rotten tomatoes in settings there is only a   omdbapi key asked which i got at www.omdbapi.com the free one.

below a snippet and it seems all data is there only it gets parsed incorrectly

</GetRTDefaultRatingById><GetRTRatingsById><details><ratings><rating name="tomatometerallcritics" max="100"><value>95</value><votes>347</votes></rating><rating name="tomatometerallaudience" max="100"><value>90</value><votes>139678</votes></rating><rating name="tomatometeravgcritics" ><value>8.9</value><votes>347</votes></rating><rating name="tomatometeravgaudience" max="5" ><value>4.3</value><votes>139678</votes></rating></ratings></details></GetRTRatingsById>

[mlaggner]

thanks for the example - have to investigate whether the problem is on our side (parsing of the kodi scraper result) or at the kodi scraper side

[Gerritenpietersen]

Ok thank u,

I believe the kodi scraper is correct btw as it works just fine in kodi

[mlaggner]

wow this scraper has a bunch of setting.. to be able to reproduce, could you send me the file tinyMediaManager/data/scraper_metadata.universal.conf to [email protected] please?

I am not able to get the right settings to reproduce your issue

[mlaggner]

ok, I finally found it.

seems like Kodi changed the scraper infrastructure along with the changes to the NFO for ratings:
we've implemented the scraper parser to accept XML in the form (source https://kodi.wiki/view/Scrapers#.3CGetDetails.3E):

xml:


<rating></rating>

<votes></votes>

but with your scraper we get:

xml:


<GetRTRatingsById>

<details>

<ratings>

<rating name="tomatometerallcritics" max="100">

<value>95</value>

<votes>347</votes>

</rating>

</ratings>

</details>

</GetRTRatingsById>

well, needs a bit of work to make the parser aware of both styles

[Karellen]

we've implemented the scraper parser to accept XML in the form (source https://kodi.wiki/view/Scrapers#.3CGetDetails.3E):

That page has had no meaningful updates in 4 years. I would be very hesitant to rely on it. I think investigating the code would be better.

[mlaggner]

well, its about 4 years ago when I created the scraper parser

regularly checking the wiki if anything has been changed would need too much time :/

[myron]

Yes, the "new" format has never been implemented there... till now
Should work again in next version....

Remember: TMM v2 only supports ONE - the frist - rating.
Only in v3 we have multiple....

[akovia]

Is this still in the works?

I noticed that no mater the Preferred Rating I set, I always get TMDB Rating. I can't get IMDB or RT.

A small heads up. I was poking around and noticed what I think is a typo in the tmm.prop file.

javascript:
....

movieSetFilterW=0

movieSetFilterX=0

movieSetFilterY=0

nessageDialogH=695

nessageDialogW=835

nessageDialogX=825

nessageDialogY=180

ratingEditorH=166

ratingEditorW=477

.....

I'm guessing nessageDialog should be messageDialog?

[mlaggner]

@akovia fixed the type (but this had never caused any error since it has been written and read "wrong" ).
for the rating I am unsure what the problem is...

do we speak about v2 or v3? if v3 -> could you open an issue at gitlab (https://gitlab.com/tinyMediaManager/tiny...ger/issues)?

[akovia]

@akovia fixed the type (but this had never caused any error since it has been written and read "wrong" ).
for the rating I am unsure what the problem is...

I didn't think it was causing any trouble, but thought you might like to know if you happened to overloook it.

do we speak about v2 or v3? if v3 -> could you open an issue at gitlab (https://gitlab.com/tinyMediaManager/tiny...ger/issues)?

I feel like I'm overlooking something here which is why I posted here first before posting a bug, but It's posted now.

Thanks!