[edjalmo]

Do your guys have noticed that every time we move the mouse when we are in cast or crew video info they show the "please wait..." warning? I see this in Amber and Arctic Zephyr: 2 , so I think this is a issue of add-on and not skin.
Another thing is sometimes they not show biography info of cast, but if we go to TMDb site we can see it (I know that development is still in progress, but just in case you don't have noticed this yet). Mads Mikkelsen is a exemple https://www.themoviedb.org/person/1019-m...uage=en-US
Things I wish see in this add-on is "Known for" and trailers, but I imagine that this is already in your to do list.

[jurialmunkey]

@jurialmunkey , just tested.  This is what I have in the log (it pertains to the movie Fast & Furious Presents: Hobbes & Shaw):

html:


Exclude paramstring: info=discover&type=movie&with_cast=Dwayne Johnson / Jason Statham / Idris Elba&with_separator=OR&exclude_key=title&exclude_value=Fast & Furious Presents: Hobbs & Shaw

Wait, is this only happening with movies that have an ampersand (&) in the title?

There's nothing I can do about those because the & character is a reserved character in URL query string encoding. In URLs (which is what the plugin path essentially is), parameters are split at the & character. To use an & as text in a URL, it needs to be escaped using percent encoding but Kodi doesn't provide anyway to do this in the skinning engine.
https://en.wikipedia.org/wiki/Percent-en...characters

^ A lot of the reserved characters we can get away with using, but the & and ? simply cannot be used in plaintext due to the way the url paramstrings are split. There's no way for the plugin to distinguish reliably between an & used as part of the URL and an & used as part of a title.

[jurialmunkey]

Do your guys have noticed that every time we move the mouse when we are in cast or crew video info they show the "please wait..." warning? I see this in Amber and Arctic Zephyr: 2 , so I think this is a issue of add-on and not skin.
Another thing is sometimes they not show biography info of cast, but if we go to TMDb site we can see it (I know that development is still in progress, but just in case you don't have noticed this yet). Mads Mikkelsen is a exemple https://www.themoviedb.org/person/1019-m...uage=en-US
Things I wish see in this add-on is "Known for" and trailers, but I imagine that this is already in your to do list.

No, it is a skin issue. It is fixed in latest version of AZ2:
https://github.com/jurialmunkey/skin.arc...alpha8.zip

I don't have any problem with Mads Mikkelsen:


TMDb API doesn't provide a list of Known For movies for a person. It only provides movie credits which can then be sorted by rating or popularity etc. I already provide movie credits in AZ2.

Trailers will be coming at some stage.

[Hitcher]

I don't have any problem with Mads Mikkelsen

Neither do I, he is was a fantastic actor.

[edjalmo]

No, it is a skin issue. It is fixed in latest version of AZ2:
https://github.com/jurialmunkey/skin.arc...alpha8.zip

Right! @bsoriano please fix in Amber too.

I don't have any problem with Mads Mikkelsen:
[url=javascript:void(0)][/url]

TMDb API doesn't provide a list of Known For movies for a person. It only provides movie credits which can then be sorted by rating or popularity etc. I already provide movie credits in AZ2.

Trailers will be coming at some stage.

Here they not show, but I'm getting errors with this plugin. I started Kodi, open a movie with Mads Mikkelsen and click on him, check if my logs say something: https://pastebin.com/HqUE7LZa

Neither do I, he is was a fantastic actor.

Yeah, this guy rocks!

[bsoriano]

@jurialmunkey , just tested.  This is what I have in the log (it pertains to the movie Fast & Furious Presents: Hobbes & Shaw):

html:


Exclude paramstring: info=discover&type=movie&with_cast=Dwayne Johnson / Jason Statham / Idris Elba&with_separator=OR&exclude_key=title&exclude_value=Fast & Furious Presents: Hobbs & Shaw

Wait, is this only happening with movies that have an ampersand (&) in the title?

There's nothing I can do about those because the & character is a reserved character in URL query string encoding. In URLs (which is what the plugin path essentially is), parameters are split at the & character. To use an & as text in a URL, it needs to be escaped using percent encoding but Kodi doesn't provide anyway to do this in the skinning engine.
https://en.wikipedia.org/wiki/Percent-en...characters

^ A lot of the reserved characters we can get away with using, but the & and ? simply cannot be used in plaintext due to the way the url paramstrings are split. There's no way for the plugin to distinguish reliably between an & used as part of the URL and an & used as part of a title. 

@jurialmunkey , no, it is happening also with movies that have no & in the title.  Please try it with your own skin, use the In-Thatres plugin, and press i on "Angel has Fallen".  You will see (at least using the latest Matrix nightly under Windows) that in the "Films from 2019" custom list Angel has Fallen appears, even though you have the exclusion in your content code. 

Here is a screenshot: https://1drv.ms/u/s!AlII29kkG6TFiNkNJ6FN...A?e=aKu3UJ

Perhaps it is a Matrix issue?

Regards,

Bart

[bsoriano]

No, it is a skin issue. It is fixed in latest version of AZ2:
https://github.com/jurialmunkey/skin.arc...alpha8.zip

Right! @bsoriano please fix in Amber too.

I don't have any problem with Mads Mikkelsen:
[url=javascript:void(0)][/url]

TMDb API doesn't provide a list of Known For movies for a person. It only provides movie credits which can then be sorted by rating or popularity etc. I already provide movie credits in AZ2.

Trailers will be coming at some stage.

Here they not show, but I'm getting errors with this plugin. I started Kodi, open a movie with Mads Mikkelsen and click on him, check if my logs say something: https://pastebin.com/HqUE7LZa

Neither do I, he is was a fantastic actor.

Yeah, this guy rocks! 

@edjalmo, the mouse issue should be fixed already in the Amber GitHub repo.  Thanks @jurialmunkey for the solution, I would not have known how to solve this issue.

Regards,

Bart

[jurialmunkey]

@jurialmunkey , no, it is happening also with movies that have no & in the title.  Please try it with your own skin, use the In-Thatres plugin, and press i on "Angel has Fallen".  You will see (at least using the latest Matrix nightly under Windows) that in the "Films from 2019" custom list Angel has Fallen appears, even though you have the exclusion in your content code. 

Here is a screenshot: https://1drv.ms/u/s!AlII29kkG6TFiNkNJ6FN...A?e=aKu3UJ
Perhaps it is a Matrix issue?

And you are using latest version of my skin? (v0.9.47-alpha8)

Because it is working completely fine for me:


Might be a Matrix issue - but that seems strange if the filter_key/filter_value is working for "By Director" call. The exclude code is literally the same code as the filter but with a flag to invert the return values so that we are now excluding matching items rather than excluding non-matching items.

EDIT: What are your language settings in TMDbHelper?

[jurialmunkey]

Here they not show, but I'm getting errors with this plugin. I started Kodi, open a movie with Mads Mikkelsen and click on him, check if my logs say something: https://pastebin.com/HqUE7LZa

I don't see any errors in that log? Where are the errors?

What is your language setting in TMDbHelper?

It is possible that your simplecache.db became corrupted or when the info was cached there wasn't a bio available for some reason.
You can try deleting simplecache.db whilst kodi is closed from:
userdata/addon_data/script.module.simplecache/simplecache.db

I only recommend deleting simplecache.db as a last resort, because it is used by multiple plugins/script and will cause cache refreshes for all of them.

I need to add a cache refresh function for a specific entry in my plugin so that doing the above is not necessary.

[bsoriano]

@jurialmunkey , no, it is happening also with movies that have no & in the title.  Please try it with your own skin, use the In-Thatres plugin, and press i on "Angel has Fallen".  You will see (at least using the latest Matrix nightly under Windows) that in the "Films from 2019" custom list Angel has Fallen appears, even though you have the exclusion in your content code. 

Here is a screenshot: https://1drv.ms/u/s!AlII29kkG6TFiNkNJ6FN...A?e=aKu3UJ
Perhaps it is a Matrix issue?

And you are using latest version of my skin? (v0.9.47-alpha8)

Because it is working completely fine for me:


Might be a Matrix issue - but that seems strange if the filter_key/filter_value is working for "By Director" call. The exclude code is literally the same code as the filter but with a flag to invert the return values so that we are now excluding matching items rather than excluding non-matching items.

EDIT: What are your language settings in TMDbHelper?

@jurialmunkey, yes, I am using the latest version of your skin, pulled from GitHub like an hour ago.

I apologize for asking, but if you scroll right the movie does not appear? I find that it is not necessarily in the first 6 or so movies.

I will try installing Leia in one of my machines and see if the behavior is different.

Regards,

Bart

[jurialmunkey]

@jurialmunkey, yes, I am using the latest version of your skin, pulled from GitHub like an hour ago.

I apologize for asking, but if you scroll right the movie does not appear? I find that it is not necessarily in the first 6 or so movies.

Ah okay. Just wanted to check as I only added the exclusion params to my skin recently.

No it doesn't show when scrolling. It definitely excludes, because this is where the item shows if I don't add the exclusion param:

Without exclusion:


With exclusion:



The list stays in the same order, but you can see that the exclusion is working because that item is no longer there.

[edjalmo]

Here they not show, but I'm getting errors with this plugin. I started Kodi, open a movie with Mads Mikkelsen and click on him, check if my logs say something: https://pastebin.com/HqUE7LZa

I don't see any errors in that log? Where are the errors?

What is your language setting in TMDbHelper?

It is possible that your simplecache.db became corrupted or when the info was cached there wasn't a bio available for some reason.
You can try deleting simplecache.db whilst kodi is closed from:
userdata/addon_data/script.module.simplecache/simplecache.db

I only recommend deleting simplecache.db as a last resort, because it is used by multiple plugins/script and will cause cache refreshes for all of them.

I need to add a cache refresh function for a specific entry in my plugin so that doing the above is not necessary.  

I can see erros when I click for search people in add-on or popular people. The search for movies and tv show work. Check logs with I doing this: https://pastebin.com/Smf3ptaE

I use Portuguese Brazil language in add-on. I checked Mads Mikkelsen page in TMDb and not exist portuguese Brazil translation of his biography. I changed add-on language to English (EUA) and still not seeing his biography, but his movies titles still show with portuguese Brazil titles, so I imagine that they're cached. You use english as a fallback language if not exist infos in user language? Maybe this is the problem...

[jurialmunkey]

Here they not show, but I'm getting errors with this plugin. I started Kodi, open a movie with Mads Mikkelsen and click on him, check if my logs say something: https://pastebin.com/HqUE7LZa

I don't see any errors in that log? Where are the errors?

What is your language setting in TMDbHelper?

It is possible that your simplecache.db became corrupted or when the info was cached there wasn't a bio available for some reason.
You can try deleting simplecache.db whilst kodi is closed from:
userdata/addon_data/script.module.simplecache/simplecache.db

I only recommend deleting simplecache.db as a last resort, because it is used by multiple plugins/script and will cause cache refreshes for all of them.

I need to add a cache refresh function for a specific entry in my plugin so that doing the above is not necessary.  

I can see erros when I click for search people in add-on or popular people. The search for movies and tv show work. Check logs with I doing this: https://pastebin.com/Smf3ptaE

I use Portuguese Brazil language in add-on. I checked Mads Mikkelsen page in TMDb and not exist portuguese Brazil translation of his biography. I changed add-on language to English (EUA) and still not seeing his biography, but his movies titles still show with portuguese Brazil titles, so I imagine that they're cached. You use english as a fallback language if not exist infos in user language? Maybe this is the problem...

Okay I can see the error there about unicode. I'll look into a fix, but that's not really related.

If there isn't info in the language that you are using on TMDb then that field will be empty. The requests are cached in simplecache for 14 days, so even if you change the language it won't update (which is one of the reasons why I need to add an option to refresh the cached item).

TMDb API doesn't provide any way to set a fallback language:
https://www.themoviedb.org/talk/5abe2eff...uage=en-US

If I manually forced a fallback then I would need to make two requests every time, which would double the time the plugin takes to retrieve any list or info.

[edjalmo]

I don't see any errors in that log? Where are the errors?

What is your language setting in TMDbHelper?

It is possible that your simplecache.db became corrupted or when the info was cached there wasn't a bio available for some reason.
You can try deleting simplecache.db whilst kodi is closed from:
userdata/addon_data/script.module.simplecache/simplecache.db

I only recommend deleting simplecache.db as a last resort, because it is used by multiple plugins/script and will cause cache refreshes for all of them.

I need to add a cache refresh function for a specific entry in my plugin so that doing the above is not necessary.  

I can see erros when I click for search people in add-on or popular people. The search for movies and tv show work. Check logs with I doing this: https://pastebin.com/Smf3ptaE

I use Portuguese Brazil language in add-on. I checked Mads Mikkelsen page in TMDb and not exist portuguese Brazil translation of his biography. I changed add-on language to English (EUA) and still not seeing his biography, but his movies titles still show with portuguese Brazil titles, so I imagine that they're cached. You use english as a fallback language if not exist infos in user language? Maybe this is the problem...

Okay I can see the error there about unicode. I'll look into a fix, but that's not really related.

If there isn't info in the language that you are using on TMDb then that field will be empty. The requests are cached in simplecache for 14 days, so even if you change the language it won't update (which is one of the reasons why I need to add an option to refresh the cached item).

TMDb API doesn't provide any way to set a fallback language:
https://www.themoviedb.org/talk/5abe2eff...uage=en-US

If I manually forced a fallback then I would need to make two requests every time, which would double the time the plugin takes to retrieve any list or info.

Understand!
If you manually add a fallback language they will take more time to load only if user are in a language that no have text? If the answer is yes, I think is better take a little more time to load and get text, than load more fast and get nothing.

[jurialmunkey]

I will try installing Leia in one of my machines and see if the behavior is different.

I just installed latest Matrix nightly and it works fine for me there too, so not a Matrix issue.

What language do you have set in TMDbHelper settings?

Can you confirm that the title of the item in the list matches the main title?