• 1
  • 24
  • 25
  • 26(current)
  • 27
  • 28
Release Janitor
(2021-02-26, 22:55)Anthirian Wrote: Thanks for the kind words. Glad to hear that you guys enjoy the addon so much. I have indeed spent quite some time getting it ready for Kodi Matrix already, which is what you can see on the kodi-19-support branch on GitHub. If you’re feeling adventurous you are welcome to try that branch out, but keep in mind that functionality may break and files may end up lost while I’m still developing. I hope to ship a compatible version next month, but am unfortunately super busy with my day job these weeks. I’ll do what I can, it won’t be long now.

Great news! Thanks so much.

If you have a 'buy me a coffee' link or similar I'll be happy to contribute to your caffeine needs!
Reply
(2021-03-01, 00:51)FoxForceFive Wrote:
(2021-02-26, 22:55)Anthirian Wrote: Thanks for the kind words. Glad to hear that you guys enjoy the addon so much. I have indeed spent quite some time getting it ready for Kodi Matrix already, which is what you can see on the kodi-19-support branch on GitHub. If you’re feeling adventurous you are welcome to try that branch out, but keep in mind that functionality may break and files may end up lost while I’m still developing. I hope to ship a compatible version next month, but am unfortunately super busy with my day job these weeks. I’ll do what I can, it won’t be long now.

Great news! Thanks so much.

If you have a 'buy me a coffee' link or similar I'll be happy to contribute to your caffeine needs!
Hi all,
I'm new here and first of all, thx for upgrading Janitor which is for me a MUST HAVE!
But ... how can I get it to work in kodi Matrix ? You gave us a link to the repo but what do I do with it ? :-)
If you'd take some time to explain to me how to do, i would be the happiest man on this forum :-p

Thx in advance.
Reply
(2021-02-26, 22:55)Anthirian Wrote: Thanks for the kind words. Glad to hear that you guys enjoy the addon so much. I have indeed spent quite some time getting it ready for Kodi Matrix already, which is what you can see on the kodi-19-support branch on GitHub. If you’re feeling adventurous you are welcome to try that branch out, but keep in mind that functionality may break and files may end up lost while I’m still developing. I hope to ship a compatible version next month, but am unfortunately super busy with my day job these weeks. I’ll do what I can, it won’t be long now.

Is there any news about a new update for Janitor, by any chance? We too miss the plugin very much on V19.
And if there is a "buy me a coffee" link I'd like to fill it too Smile
Reply
Sorry to keep you guys waiting. The Matrix version is currently waiting to be accepted into the Kodi repository, but it's waiting for review. I expect it to be accepted within the coming week however. Thanks for the kind words. I also added a buy me a coffee link to the starting post of this thread if any of you feel like it.
Reply
(2021-05-01, 00:07)Anthirian Wrote: Sorry to keep you guys waiting. The Matrix version is currently waiting to be accepted into the Kodi repository, but it's waiting for review. I expect it to be accepted within the coming week however. Thanks for the kind words. I also added a buy me a coffee link to the starting post of this thread if any of you feel like it.

Enjoy your coffee, its just refilled :-))
Reply
I love this add-on, thank you.

One question: does it delete the folder if empty as well? The "Movies in separate folders" setting is set to True, and I've noticed that the movie gets deleted, but not the movie folder. Therefore I have a number of empty movie folders, e.g. The Negotiator (1998), The Place Beyond The Pines (2012), etc.
Reply
Good news everyone, Janitor has been accepted into the Kodi Matrix repositories and is now available for downloading! Please let me know if you encounter any bugs and don’t forget to post a debug log.

(2021-05-01, 12:17)Ralfjuh Wrote: Enjoy your coffee, its just refilled :-))

Thank you so much 😁


(2021-05-03, 21:15)DoctorJellybean Wrote: I love this add-on, thank you.

One question: does it delete the folder if empty as well? The "Movies in separate folders" setting is set to True, and I've noticed that the movie gets deleted, but not the movie folder. Therefore I have a number of empty movie folders, e.g. The Negotiator (1998), The Place Beyond The Pines (2012), etc.

Yes it does, even with that setting enabled. You may need to toggle the settings to expert mode so you can submit a list of files to ignore, e.g. subtitles and fanart, when checking if a movie folder is empty.
Reply
Hero. Thank you so much Anthirian.
Reply
(2021-05-05, 21:48)Anthirian Wrote:  
(2021-05-03, 21:15)DoctorJellybean Wrote: I love this add-on, thank you.

One question: does it delete the folder if empty as well? The "Movies in separate folders" setting is set to True, and I've noticed that the movie gets deleted, but not the movie folder. Therefore I have a number of empty movie folders, e.g. The Negotiator (1998), The Place Beyond The Pines (2012), etc.

Yes it does, even with that setting enabled. You may need to toggle the settings to expert mode so you can submit a list of files to ignore, e.g. subtitles and fanart, when checking if a movie folder is empty.

It doesn't appear to remove empty folders. I've checked my settings, and ran Janitor. 2 Movies were deleted, but the folders are still there. I'm attaching a screenshot of the Janitor settings, are there any Kodi settings which needs to be changed?


Image
Reply
(2021-05-05, 21:48)Anthirian Wrote: Good news everyone, Janitor has been accepted into the Kodi Matrix repositories and is now available for downloading! Please let me know if you encounter any bugs and don’t forget to post a debug log.

(2021-05-01, 12:17)Ralfjuh Wrote: Enjoy your coffee, its just refilled :-))

Thank you so much 😁


(2021-05-03, 21:15)DoctorJellybean Wrote: I love this add-on, thank you.

One question: does it delete the folder if empty as well? The "Movies in separate folders" setting is set to True, and I've noticed that the movie gets deleted, but not the movie folder. Therefore I have a number of empty movie folders, e.g. The Negotiator (1998), The Place Beyond The Pines (2012), etc.

Yes it does, even with that setting enabled. You may need to toggle the settings to expert mode so you can submit a list of files to ignore, e.g. subtitles and fanart, when checking if a movie folder is empty.

Everything works fine! Only "minor" is the "view log screen" after the cleaning. Backgroud is transparent.
Reply
(2021-05-06, 15:07)DoctorJellybean Wrote:
(2021-05-05, 21:48)Anthirian Wrote:  
(2021-05-03, 21:15)DoctorJellybean Wrote: I love this add-on, thank you.

One question: does it delete the folder if empty as well? The "Movies in separate folders" setting is set to True, and I've noticed that the movie gets deleted, but not the movie folder. Therefore I have a number of empty movie folders, e.g. The Negotiator (1998), The Place Beyond The Pines (2012), etc.

Yes it does, even with that setting enabled. You may need to toggle the settings to expert mode so you can submit a list of files to ignore, e.g. subtitles and fanart, when checking if a movie folder is empty.

It doesn't appear to remove empty folders. I've checked my settings, and ran Janitor. 2 Movies were deleted, but the folders are still there. I'm attaching a screenshot of the Janitor settings, are there any Kodi settings which needs to be changed?


Image
I suspect you removed the default settings and added .txt as the only ignored extension. Could you enable debug logging in the expert settings and post a debug log?

(2021-05-06, 16:35)Ralfjuh Wrote: Everything works fine! Only "minor" is the "view log screen" after the cleaning. Backgroud is transparent.

That’s strange. Are you using a custom skin or one of the defaults? In any case, please enable expert settings, turn on debug logging and post your logs so I can take a look at them.
Reply
(2021-05-06, 18:48)Anthirian Wrote:
(2021-05-06, 15:07)DoctorJellybean Wrote:
(2021-05-05, 21:48)Anthirian Wrote:  

Yes it does, even with that setting enabled. You may need to toggle the settings to expert mode so you can submit a list of files to ignore, e.g. subtitles and fanart, when checking if a movie folder is empty.

It doesn't appear to remove empty folders. I've checked my settings, and ran Janitor. 2 Movies were deleted, but the folders are still there. I'm attaching a screenshot of the Janitor settings, are there any Kodi settings which needs to be changed?


Image
I suspect you removed the default settings and added .txt as the only ignored extension. Could you enable debug logging in the expert settings and post a debug log?
(2021-05-06, 16:35)Ralfjuh Wrote: Everything works fine! Only "minor" is the "view log screen" after the cleaning. Backgroud is transparent.

That’s strange. Are you using a custom skin or one of the defaults? In any case, please enable expert settings, turn on debug logging and post your logs so I can take a look at them.

The log is here:

https://paste.kodi.tv/UMOPEDUJED

As for the possible removal of the default settings, I didn't touch that. If I select that option, the full list appears:

Image

I'm also encountering the transparent "view log" screen issue, as mentioned by Ralfjuh. My skin is Aeon Nox: SiLVO with a custom background image. The actual screen asking whether to view the log is not transparent.
Reply
Somehow the link you posted to the debug log is not working for me. Could you re-upload it please? I have a feeling that I have forgotten to include a particular texture with the new release, but would like to confirm this via your log files. Also then I can determine the issue with the deleting of folders. By the way, after typing this message I noticed that your screenshot shows version 4.4.1 instead of 5.0.0. Are you sure you have the right version installed?
Reply
(2021-05-18, 23:17)Anthirian Wrote: Somehow the link you posted to the debug log is not working for me. Could you re-upload it please? I have a feeling that I have forgotten to include a particular texture with the new release, but would like to confirm this via your log files. Also then I can determine the issue with the deleting of folders. By the way, after typing this message I noticed that your screenshot shows version 4.4.1 instead of 5.0.0. Are you sure you have the right version installed?

Yes, 4.4.1 is the installed version. Even after clicking Update, it remains at the same version. I'm using Kodi Leia 18.5, on a QNAP NAS.

I've uploaded the log (password: doctorjellybean) and attaching a screenshot which shows the deleted movie on the left (deleted items gets moved to a folder) and the empty non-deleted folder on the right. The log is available for 7 days.

Image
Reply
(2021-05-19, 12:09)DoctorJellybean Wrote: I'm using Kodi Leia 18.5, on a QNAP NAS.
I believe that's the source of the confusion. As soon as a new Kodi is released Janitor only supports that version. Due to my limited time I cannot support multiple versions of Janitor that work with multiple versions of Kodi. Therefore the most recent version of Janitor you will be able to install is 4.4.1, so that's the reason nothing happens when you click update.

As for the reason version 4.4.1 does not delete empty folders, I cannot determine this from the log file. The execution of Janitor I think is happening in these lines, but you haven't enabled debug logging in Janitor's settings so I cannot see what is going on under the hood.

Code:

2021-05-19 09:53:54.006 T:140496668178176   DEBUG: CPythonInvoker(5, /opt/Kodi18/.kodi/addons/script.service.janitor/default.py): start processing
2021-05-19 09:53:54.023 T:140496668178176   DEBUG: -->Python Interpreter Initialized<--
2021-05-19 09:53:54.023 T:140496668178176   DEBUG: CPythonInvoker(5, /opt/Kodi18/.kodi/addons/script.service.janitor/default.py): the source file to load is "/opt/Kodi18/.kodi/addons/script.service.janitor/default.py"
2021-05-19 09:53:54.023 T:140496668178176   DEBUG: CPythonInvoker(5, /opt/Kodi18/.kodi/addons/script.service.janitor/default.py): setting the Python path to /opt/Kodi18/.kodi/addons/script.service.janitor:/usr/lib/python2.7:/usr/lib/python2.7/plat-x86_64-linux-gnu:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/local/lib/python2.7/dist-packages:/usr/lib/python2.7/dist-packages
2021-05-19 09:53:54.023 T:140496668178176   DEBUG: CPythonInvoker(5, /opt/Kodi18/.kodi/addons/script.service.janitor/default.py): entering source directory /opt/Kodi18/.kodi/addons/script.service.janitor
2021-05-19 09:53:54.023 T:140496668178176   DEBUG: CPythonInvoker(5, /opt/Kodi18/.kodi/addons/script.service.janitor/default.py): instantiating addon using automatically obtained id of "script.service.janitor" dependent on version 2.26.0 of the xbmc.python api
2021-05-19 09:53:54.046 T:140496668178176   DEBUG: CAddonSettings[script.service.janitor]: loading setting definitions
2021-05-19 09:53:54.046 T:140496668178176   DEBUG: CAddonSettings[script.service.janitor]: trying to load setting definitions from old format...
2021-05-19 09:53:54.048 T:140496668178176   DEBUG: CAddonSettings[script.service.janitor]: loading setting values
2021-05-19 09:53:57.083 T:140496668178176   ERROR: Remove - Error removing /share/Multimedia/Movies/Drama/The Glass Shield (1994)
2021-05-19 09:54:07.646 T:140497378449152  NOTICE: CleanDatabase: Starting videodatabase cleanup ..
2021-05-19 09:54:08.282 T:140497378449152  NOTICE: CleanDatabase: Cleaning videodatabase done. Operation took 00:00
2021-05-19 09:54:08.317 T:140498323904640   DEBUG: CDirectoryProvider[videodb://movies/titles/]: refreshing..
2021-05-19 09:54:08.317 T:140498323904640   DEBUG: CDirectoryProvider[videodb://tvshows/titles/]: refreshing..
2021-05-19 09:54:08.317 T:140498323904640   DEBUG: CDirectoryProvider[videodb://musicvideos/titles/]: refreshing..
2021-05-19 09:54:08.319 T:140497087616768   DEBUG: CRecentlyAddedJob::UpdateVideos() - Running RecentlyAdded home screen update
2021-05-19 09:54:08.477 T:140497087616768   DEBUG: CRecentlyAddedJob::UpdateTotal() - Running RecentlyAdded home screen update
2021-05-19 09:54:08.480 T:140497087616768   DEBUG: GetArtistsByWhere query: SELECT COUNT(DISTINCT artistview.idArtist) FROM artistview  WHERE (EXISTS (SELECT 1 FROM song_artist WHERE song_artist.idArtist = artistview.idArtist AND song_artist.idRole = 1) OR EXISTS (SELECT 1 FROM album_artist WHERE album_artist.idArtist = artistview.idArtist)) AND (artistview.strArtist != '')
2021-05-19 09:54:11.946 T:140498323904640   DEBUG: ProcessMouse: trying mouse action leftclick
2021-05-19 09:54:12.262 T:140496668178176    INFO: CPythonInvoker(5, /opt/Kodi18/.kodi/addons/script.service.janitor/default.py): script successfully run

I do see an error related to deleting a movie:
Code:
2021-05-19 09:53:57.083 T:140496668178176   ERROR: Remove - Error removing /share/Multimedia/Movies/Drama/The Glass Shield (1994)

I suspect that this might be a reason folders aren't being deleted, but until I see the full debug logs I cannot say for certain. Also I suggest upgrading to Kodi Matrix, as Janitor was almost entirely rewritten to support it.
Reply
  • 1
  • 24
  • 25
  • 26(current)
  • 27
  • 28

Logout Mark Read Team Forum Stats Members Help
Janitor4
This forum uses Lukasz Tkacz MyBB addons.